From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758280AbbKSKLF (ORCPT ); Thu, 19 Nov 2015 05:11:05 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:58566 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755273AbbKSKK7 (ORCPT ); Thu, 19 Nov 2015 05:10:59 -0500 X-AuditID: cbfee68e-f79f56d000004437-7e-564da0321411 Date: Thu, 19 Nov 2015 10:10:58 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20151119100405754@myungjoo.ham Msgkey: 20151119100405754@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20151119100405754@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <932082455.1194101447927858604.JavaMail.weblogic@ep2mlwas06b> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkUNdogW+YwZ49uhaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvj5cdN7AWf+Cp6l8xibGDcw9fFyMkhJKAusWjJSbYuRg4OCQET ie2no0HCEgJiEhfurWeDKFnKKNH+3REibiJx58lDRoj4HEaJpZt4QGwWAVWJV0+/gI1hE9CT mPk5GSQsLBAm8bPvK1A5F4eIQB+jxOHfs9lBEswCVRKrjv1ih5ijJLFm3ysWEJtXQFDi5Mwn LBC7VCWWt71hhIirSSz7tJUNIi4ucWHuJXYIm1diRvtTqHo5iWlf1zBD2NIS52dtYIT5ZfH3 x1Bxfoljt3cwQdgCElPPHISq0ZL4s2IjVA2fxJqFb1lg6nedWs4Ms+v+lrlQvRISW1uesEL8 oigxpfshO8jvzAKaEut36aN7hVfAU2Jtxz82UDhICEzkkNhx9hDjBEalWUjqZiEZNQthFLKS BYwsqxhFUwuSC4qT0ouM9IoTc4tL89L1kvNzNzECU8Lpf8/6djDePGB9iFGAg1GJh3fDKZ8w IdbEsuLK3EOMpsBYmsgsJZqcD0w8eSXxhsZmRhamJqbGRuaWZkrivAlSP4OFBNITS1KzU1ML Uovii0pzUosPMTJxcEo1MMYGtUw9lSrSF7xsumvdi26Nfu/dPZKWbi9OTDvAYBuryyz0Ie/Q +jWBYSeeWK0Vqlyk2DktgG3/7G27V92Pf1Uk+cjG8ubc1SITtYNXz1n2K7pBQed4qkeG5Lv6 fTN1DOdfZpo5e+GZHU8L50vM9J37aOVBnlMd/1mDXBVOX972oNHmvJ2kUIUSS3FGoqEWc1Fx IgAqrsOgBAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tfl2jBb5hBlv+aVhc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIyX HzexF3ziq+hdMouxgXEPXxcjJ4eQgLrEoiUn2UBsCQETiTtPHjJC2GISF+6tZ4OomcMosXQT D4jNIqAq8erpF6A4BwebgJ7EzM/JIGFhgTCJn31fgVq5OEQE+hglDv+ezQ6SYBaoklh17Bc7 xBwliTX7XrGA2LwCghInZz5hgdilKrG87Q0jRFxNYtmnrVD3iEtcmHuJHcLmlZjR/hSqXk5i 2tc1zBC2tMT5WRvgbl78/TFUnF/i2O0dTBC2gMTUMweharQk/qzYCFXDJ7Fm4VsWmPpdp5Yz w+y6v2UuVK+ExNaWJ6wQvyhKTOl+yA7yO7OApsT6XfroXuEV8JRY2/GPbQKj7CwkqVlIumch dCMrWcDIsopRNLUguaA4Kb3CWK84Mbe4NC9dLzk/dxMjOAU9W7yD8f9560OMAhyMSjy8G075 hAmxJpYVV+YeYpTgYFYS4X06zTdMiDclsbIqtSg/vqg0J7X4EKMpMM4mMkuJJucD02NeSbyh sbGJmYmppYmFgam5kjjvm3SNMCGB9MSS1OzU1ILUIpg+Jg5OqQZGjWsvz+XHP0hoSd55Yvdy BasnjxkOC4sKnTSe8SXYQUS2bmr5hsQJj2Wn6891a/dlbJhwN9ztxabdbw2qDY47J5vxWewo PKVwqFq/RKLMltPD4UtMxLPXa/T/XdC7d7Jpx69tWcfnm/s5iv8M/q/7kvdR/v4gOaXtUWu0 Nn9qmPVsSu3Wzh+PlViKMxINtZiLihMBDZWhEFcDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAJABBaD024672 > After probing the devfreq device driver, the value of both min_freq and > max_freq are zero(0). So, this patch initializes the 'min_freq' and 'max_freq' > field of devfreq device by using the freq_table array. > > Signed-off-by: Chanwoo Choi > --- > drivers/devfreq/devfreq.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index c292ceb7ff19..0b24ae7b7a48 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -121,6 +121,11 @@ static void devfreq_set_freq_table(struct devfreq *devfreq) > profile->freq_table[i] = freq; > } > rcu_read_unlock(); > + > + mutex_lock(&devfreq->lock); > + devfreq->min_freq = profile->freq_table[0]; > + devfreq->max_freq = profile->freq_table[profile->max_state - 1]; > + mutex_unlock(&devfreq->lock); > } No, you should not do this. It is allowed to use devfreq without both OPP and freq_table assuming that the devfreq device may operate with very many frequencies so that practically, we can virtually give it any frequency numbers in a given range. (cases where profile->max_state is 0 and it is not an error) The value 0 is used for min/max_freq to declare that min/max_freq is deactivated. Therefore, it is not required to do so; they are not intended to show the hardware configuration as well. Cheers, MyungJoo {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I