From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57360213E9F for ; Mon, 6 Oct 2025 08:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759739429; cv=none; b=b5mMsUd1/q2BIzC9S6QylNUA7fu+L+H8FSfI3OBIy2FRALBpFDjtY95MgJgbxS/XzPD+l0Az8jNq3pH/yEMzxwO2L1Qv77WMFjeVCcG14FW+uYN70MEQu1isWxpS8CRwaJvnVYRki+Zt9s589R7Kw4PBjQIMLrfLl49lpYotWuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759739429; c=relaxed/simple; bh=h8CwgLFpO+TicqkeCoMFZK/tgdp9XzNO2dE1KL03W3g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vBR7/oDrcNTsDPExBtf3La0e+NrVlwaYTGLOQPp+fW9BWjJJftc+CSQogbZElU8tSMCWvHkGZjr2EWOUvIcny0jVDCHrRJNmtweB08Kv6cYx9E6Gy/UEb7ibySB3cFqFHSaBdHemWBX/WreqPTcuHWP4lcmQbXTY1Viku9wU+6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DDhVqSS9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DDhVqSS9" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 595LXSPe017633 for ; Mon, 6 Oct 2025 08:30:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /L1grXilGVTKm+qKpyor+cgwpOJFQIDTL8Rar0TzJG4=; b=DDhVqSS9JcY0Jc8m jyQMB9h0yP96EP61LBGxnmgdUpsPoKyoV/Kv7Y0jVT8kQFsJVQUiQL0T3UqexWIi 8hcWnW9yLrrxT5N6Qj1DqJ/QoMxSpLY9li+95Y4SiEf0fKT9TyfoV52glcV84Xdn YDwrZ5aMDoZWF+58kc5pNGsZyO0xJiUS3pysN844F30fZzwI92r4EIAo7Ke9it2G ewtmvhHcR5fHU3AJG6KiJbKt+UT30aHPT8+qDgYa4w+LIE9aGpgOj/+v6y37hg4p QJepv0vO+vzlDXpEEdiaudL/XHqGQaBuEHVgJH3yU+4xG1e0Z074q7ShDZBV7ws+ ufq+ng== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49jvrhk5mm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 06 Oct 2025 08:30:27 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-853f011da26so154748485a.0 for ; Mon, 06 Oct 2025 01:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759739426; x=1760344226; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/L1grXilGVTKm+qKpyor+cgwpOJFQIDTL8Rar0TzJG4=; b=ITMDs5n4ApYBowxgyQE5LtZwYFe4W1m22YHGri0VbE25a+GyY57OQz35NxU8RiR7sJ a7/W5fIKHQHZ7ZQRSeUM2LOkbsK5zrO+vCsBE2DqU3YrxpYSSl2Yx5Hc0aU/D+kRTC+P ocF10Olpwn7zNwk75eABHMw8F/G0sqceQYkWxtLdRJzn/qrE+1E3nOb5+/2YwHH6QpAo vkswEK71q98DLyFYhLPVfInP6ys75gXV5nPmSWCi8rbO7r7fgV2ms4VXTat4Sp7iR/be +4T2V1RySzOEvhNefREgvTsDNyUKNI8RWo/VeVIvIbeHMQV9WTh/GgJYT6E4hacByhj9 gINw== X-Forwarded-Encrypted: i=1; AJvYcCVsiGkTSH5LdgWfB/LAEGboqJr/EnsZQz2MvM3mGPa003Rf5SXWhMQ5VfGCh6KDb9Hj9Ei/2udabBbsEac=@vger.kernel.org X-Gm-Message-State: AOJu0YykDU7lShRDvWzzXOQfMdEO1iUq4pWvIfVGF8C6b96nvI2w2Tf8 YWEkmKYwi9YyURcXCDHu6NUssmRfdfTh279So2CPQv6E0HSUXXh7I7yqYD1QHlG5FyyjkYS/K2c mGnPG8ppaFMuqwolHA5zgstEkN0liElosG7yDEPyMV/qQFFHcGm3RsVHWa8H250Ou5MU= X-Gm-Gg: ASbGncsQ9J69KNMYbScHqN10FNwklRzhZcP2kHAzMKAXpXoXrxba40GnveZSOfS5I/R mqsIvGZq3GJqL3o63rnE/9LkgaMle/oAFvcERepKV0gluvyoeb7FmEnoY4d8y+qxNfFuYz0j/ZM AFl/eaaU/Nbp4nGK1GFEr5IdfTot/S35Ca7i68Ff631IRTw3f8GTAv3B+7s9ww6hfiBP5U4opoS KnAPXrgbfI9zKab1gXju++hkPeLs1BDnFTYEXB2uk+juqBGj/4Qz89V6e2u0RZEG+LxzAGE+NEc pDk4YC/usBJ+ryBJlnanJ8fB4ximBsbvB4VAt6w8z6nmWGFF54lQ3jgAldWhLOSZkyP0o3QRtKh 8fCaZci5DOPfi3+T/DCI56PTWSq0= X-Received: by 2002:a05:620a:254e:b0:7e8:c4f:614b with SMTP id af79cd13be357-87a35ce66b3mr915923485a.7.1759739425790; Mon, 06 Oct 2025 01:30:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXUjSORB8/gdVaqQhY61pOzDiPB5IX7IjdJsn8jA+4eHYgbYcSssD5tm9/R6DxLCyU1tYgZw== X-Received: by 2002:a05:620a:254e:b0:7e8:c4f:614b with SMTP id af79cd13be357-87a35ce66b3mr915921685a.7.1759739425283; Mon, 06 Oct 2025 01:30:25 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b486970b422sm1100481366b.54.2025.10.06.01.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 01:30:24 -0700 (PDT) Message-ID: <9320c599-c7e3-427c-a096-230037d5db43@oss.qualcomm.com> Date: Mon, 6 Oct 2025 10:30:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] drm/msm/dsi: add DSI PHY configuration on QCS8300 To: Ayushi Makhija , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: robdclark@gmail.com, dmitry.baryshkov@oss.qualcomm.com, sean@poorly.run, marijn.suijten@somainline.org, andersson@kernel.org, robh@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, konradybcio@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonathan@marek.ca, jonas@kwiboo.se, jernej.skrabec@gmail.com, quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com References: <20251006013924.1114833-1-quic_amakhija@quicinc.com> <20251006013924.1114833-5-quic_amakhija@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251006013924.1114833-5-quic_amakhija@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAzNiBTYWx0ZWRfX0ACr4zkI9pas QI0o0VXXfpzBtVqOxvYhq8mYa5UdLexogReYZnMQXuEI2VQ2O2VW7MK5AQipcXOzHQ7mr/vGUua GSVNi3fX7Aw/lYuY03TKrQw+/HeaVgvAS3T10p+WCD871U9oggto/Er7uFMfPSuFxuIBEUM6piJ d18rVS6YJtgs36HqebCh2hLp7fQYAnsAuAIURgGxnnE/ZkQteQY54wT7nslZ3Xw66jCiwGyF6I7 6+XyUCr5TkaJbMUl338Dh5N85qo5ErrbyvzMAb6gRFiRfWZfvU0QaZ0tQx2USrLaf4QMRdABLHS DaIeR15ro3xypTaHdt0gi8KnoSp84eDD0lJxVF4KIr3E6yjjZbqWYIDeg+ZCd1SDCuc6CVjaDO9 5FJpqe58PKVraAcgQ1GIYgI6JDrwRg== X-Proofpoint-GUID: jkE0XvF_Gu689koigdsHuYErqwXr4Gm7 X-Authority-Analysis: v=2.4 cv=XIQ9iAhE c=1 sm=1 tr=0 ts=68e37e23 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=COk6AnOGAAAA:8 a=pHedSVXj9zt6Nr3hYnwA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: jkE0XvF_Gu689koigdsHuYErqwXr4Gm7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-06_03,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040036 On 10/6/25 3:39 AM, Ayushi Makhija wrote: > The QCS8300 SoC uses the 5nm (v4.2) DSI PHY driver. > > Signed-off-by: Ayushi Makhija > --- [...] > +const struct msm_dsi_phy_cfg dsi_phy_5nm_8300_cfgs = { > + .has_phy_lane = true, > + .regulator_data = dsi_phy_7nm_48000uA_regulators, > + .num_regulators = ARRAY_SIZE(dsi_phy_7nm_48000uA_regulators), > + .ops = { > + .enable = dsi_7nm_phy_enable, > + .disable = dsi_7nm_phy_disable, > + .pll_init = dsi_pll_7nm_init, > + .save_pll_state = dsi_7nm_pll_save_state, > + .restore_pll_state = dsi_7nm_pll_restore_state, > + .set_continuous_clock = dsi_7nm_set_continuous_clock, > + }, > + .min_pll_rate = 600000000UL, > +#ifdef CONFIG_64BIT > + .max_pll_rate = 5000000000UL, > +#else > + .max_pll_rate = ULONG_MAX, > +#endif > + .io_start = { 0xae94400 }, > + .num_dsi_phy = 1, > + .quirks = DSI_PHY_7NM_QUIRK_V4_2, > +}; Again, this is not necessary, since the lookup code looks like this: for (i = 0; i < cfg->num_dsi_phy; i++) { if (cfg->io_start[i] == res->start) return i; } Konrad