From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1299E346AED for ; Fri, 19 Jun 2026 21:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781903626; cv=none; b=L6LTIRLKL7Dd24HarBWiUpI6p7rWZheEW6b48sk6rncsh3f7n59OvcgFnG+7EGgZ5srRb+kcbyrIkjzhCTPuuypAn7JLfHxy2i9NV14DawmyUMES+NXFFKYhn8QaxcN/AsWyaVUs5mWWRFJVFVHXyC13/6LnftVjJfo63eAaXYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781903626; c=relaxed/simple; bh=BGS1cKnVpnESSPNZl/4xTDNdUBGokNfeZlrzdewdYP0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MJxQhdPFXeLugj47PsRRUS5Nt97yfUTR+IKQtyayD5yUjwJ58b6RlJAV+dNbHqe/ftFomoFAh5Q9Mal9YvQja/pU8PFIx88TxYwg+3fAZwrR2TmExb38j2CWXyL7A15bMM6nwSbWUwbjnWFlNP9zGxV2D745vUsgAFurVXY2aw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O+LtbxUR; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+LtbxUR" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84531988438so1614452b3a.0 for ; Fri, 19 Jun 2026 14:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781903623; x=1782508423; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=lnxWivuqEQZ8dcpSoejNyWh6Ys/zhGqPoxY2tVIHTS8=; b=O+LtbxUR0ApbzTzo/JATSanrfLlTIRLdVOBOmfXM+daJv2HQzljJJgw3PSLoIWZnIS S5qzU4++0E0z00plii8CzYKD2Hmkl7Leq8Z3uAxywdC1g0gK9nsFldtw3MYXoV5mslOR 2sinMxMZyi7EvFMBnHNOlCtxyQVY5sVpgqZOTbGpjZzwhDTaO0U2XaQkeuQQjpu0uYMR zOTIwSJ/eeIHGw4xM3Qju3LAD9ePgbMc9SIPgGvBBMivGCO1T4zLo754C3O5aMGlsf3h /7f8NjiBHp/xnhZ1ouMizOBIb4rHjn0HwitOlJApCLSQDj0TuD7qnP4chdwi0y7ItIKP 4W+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781903623; x=1782508423; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lnxWivuqEQZ8dcpSoejNyWh6Ys/zhGqPoxY2tVIHTS8=; b=J4qnuNu8mp0di1mA11qdIpZxfyZJmOZCP5mt16gsVs5fj1ebXxHaKX0A33kVXSVhJC bh2PWA/oMA6MhsP9AKU4X6G314Ra7CkGcJeNxyaUcSZwbqzK3fSB0C+jpNsaFPtVE8Um R31gO5EzfK5of9npxtlzxlkRkStNi+ut8ZegtAyQclNsaXebT5JLOaY/HmX5RPslj6d3 wuxsosYa3e+H4DgpNpuwkum6YVgYF+dha2bSfvvZIY2zZbVGaGA9w74eS/kWdpTPbckP wlRTVR8ILYCX9wtjkN1WG2KrzzxqpwI9c5nk1B879X2L0M0o7wWztbLmgEuzyPXQYiaR VtMg== X-Forwarded-Encrypted: i=1; AFNElJ/L9qyeyjn+nL3m4x469YjvphZQQj9aCkWkrvcimahKfI5a5VGfjLQS0w75PseTj6frpFJ76MKtc+CIjEg=@vger.kernel.org X-Gm-Message-State: AOJu0YzyWQtJppPONDzWqV19LkyH1tMIVBkvjbJcfklL2sqdK6wV7HIQ SqfGKNny3yayCGKsr1SDHTBHBPamvndEOZ2xBd0froXc/c8oLHZf/ygT X-Gm-Gg: AfdE7cnfla+rdB8tde6cJAsatA9ecsDWOgIlpZ5KpD655PY74Fyqh+uZie7De77GqW1 vlS5qAnLSs4Cs7J7W72RZZtSuRO7lvWpF5Wg+GWJuP+bCfFB9pCLojqAd2puydtER+rIUYFp8VM 2CWxBTVirAdCJpTkHPnpTPOO9KRdKezdiDfmd5T6Li6nHAZHohl9h8JBkRJCHAVg6oJHv14e3Vn AG7W5mJDGH7/ZCbLZNcvQQxKeq5An/DZdtPOP4CTE4M1vC/RnZghHF4zDXuYf6RyXf5xW9f2B8V bRJwRmZxKSWjB6JiSnvG6W9yoYQszojr+y5bsgfzqfaT3dIF/+BcWnZS8T/uyKYG+5jmX6ryBUL 37vWxW+9fAmfvhEPHgecM5d/xD1jNW4kYN2TnhVCLyb1Q6TCfQus31h6XjWAlqIIDh4g7VpBY04 bHwOONAEWRoJRdHN7nffDT7ihJxDYRYm5WMelBzpKadw== X-Received: by 2002:a05:6a00:2e93:b0:842:5f67:eada with SMTP id d2e1a72fcca58-84550113eb5mr4506253b3a.5.1781903623224; Fri, 19 Jun 2026 14:13:43 -0700 (PDT) Received: from [192.168.0.226] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564eca7fcsm142782b3a.52.2026.06.19.14.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2026 14:13:42 -0700 (PDT) Message-ID: <9323b0acc22de75ead4732db464672443eb141ff.camel@gmail.com> Subject: Re: [PATCH bpf v2 1/8] libbpf: ringbuf: Honor zero consume bounds From: Eduard Zingerman To: Tamir Duberstein , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , Andrea Righi , Xu Kuohai , Andrea Righi , Bing-Jhong Billy Jheng , David Vernet Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Werner , Zvi Effron , Andrii Nakryiko , Emil Tsalapatis Date: Fri, 19 Jun 2026 14:13:39 -0700 In-Reply-To: <20260618-bpf-ringbuf-fixes-v2-1-33fde039ddf3@kernel.org> References: <20260618-bpf-ringbuf-fixes-v2-0-33fde039ddf3@kernel.org> <20260618-bpf-ringbuf-fixes-v2-1-33fde039ddf3@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-06-18 at 20:26 -0400, Tamir Duberstein wrote: > ringbuf_process_ring() checks the record bound only after advancing the > consumer position and invoking the callback. A zero bound therefore > consumes the first available record. >=20 > Return before reading the ring positions when the bound is zero so > ring_buffer__consume_n() and ring__consume_n() leave all records queued. >=20 > Fixes: 4d22ea94ea33 ("libbpf: Add ring__consume_n / ring_buffer__consume_= n") > Reviewed-by: Emil Tsalapatis > Assisted-by: Codex:gpt-5.5 > Signed-off-by: Tamir Duberstein > --- Acked-by: Eduard Zingerman [...] > diff --git a/tools/testing/selftests/bpf/prog_tests/ringbuf.c b/tools/tes= ting/selftests/bpf/prog_tests/ringbuf.c > index 64520684d2cb..4f0558f14847 100644 > --- a/tools/testing/selftests/bpf/prog_tests/ringbuf.c > +++ b/tools/testing/selftests/bpf/prog_tests/ringbuf.c > @@ -404,6 +404,7 @@ static int process_n_sample(void *ctx, void *data, si= ze_t len) > static void ringbuf_n_subtest(void) > { > struct test_ringbuf_n_lskel *skel_n; > + struct ring *ring; > int err, i; > =20 > skel_n =3D test_ringbuf_n_lskel__open(); > @@ -431,6 +432,18 @@ static void ringbuf_n_subtest(void) > for (i =3D 0; i < N_TOT_SAMPLES; i++) > syscall(__NR_getpgid); > =20 > + ring =3D ring_buffer__ring(ringbuf, 0); > + if (!ASSERT_OK_PTR(ring, "ring_buffer__ring")) > + goto cleanup_ringbuf; > + > + err =3D ring_buffer__consume_n(ringbuf, 0); > + if (!ASSERT_EQ(err, 0, "ringbuf_consume_zero")) > + goto cleanup_ringbuf; > + > + err =3D ring__consume_n(ring, 0); > + if (!ASSERT_EQ(err, 0, "ring_consume_zero")) > + goto cleanup_ringbuf; > + > /* Consume all samples from the ring buffer in batches of N_SAMPLES */ > for (i =3D 0; i < N_TOT_SAMPLES; i +=3D err) { > err =3D ring_buffer__consume_n(ringbuf, N_SAMPLES); Could you please pack the tests as a separate commit (or commits) at the end of the series?