mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Apurva Nandan <a-nandan@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: ti: Add support for J784S4 EVM board
Date: Fri, 18 Nov 2022 12:15:09 -0600	[thread overview]
Message-ID: <93242211-95e7-09a0-fced-5ef2deb9fc08@ti.com> (raw)
In-Reply-To: <20221118180808.wnel7d6gswsnooww@junkman>

On 11/18/22 12:08 PM, Nishanth Menon wrote:
> On 11:56-20221118, Andrew Davis wrote:
>> On 11/18/22 11:47 AM, Nishanth Menon wrote:
>>> On 11:40-20221118, Andrew Davis wrote:
>>>> On 11/16/22 7:04 AM, Apurva Nandan wrote:
>>>
>>> [...]
>>>
>>>>> +#include <dt-bindings/net/ti-dp83867.h>
>>>>> +#include <dt-bindings/gpio/gpio.h>
>>>>> +#include "k3-j784s4.dtsi"
>>>>> +
>>>>> +/ {
>>>>> +	compatible = "ti,j784s4-evm", "ti,j784s4";
>>>>> +	model = "Texas Instruments J784S4 EVM";
>>>>> +
>>>>> +	chosen {
>>>>> +		stdout-path = "serial2:115200n8";
>>>>> +	};
>>>>> +
>>>>> +	aliases {
>>>>> +		serial2 = &main_uart8;
>>>>
>>>> This feels hacky. Your chosen node picks serial2 as that is usually
>>>> the one that is wired up on K3 boards. But on this board it is main_uart8.
>>>> So why not have this be serial10, then choose
>>>>
>>>> stdout-path = "serial10:115200n8";
>>>>
>>>> Also, I've made comments on previous version of this series, it is
>>>> nice to include folks who have commented before in the CC for future
>>>> versions, that way our filters don't hide these away and we can more
>>>> easily check that our comments have been addressed.
>>>
>>> Please stick with the standard of serial2 as the linux console standard.
>>> We ended up with that to ease up capabilities of various distros to
>>> uniformly work across SoC and board variants.
>>>
>>
>> The chosen "stdout-path" is for setting the kernel's default output terminal.
>> Distros and other userspaces need to use their own policy mechanisms for
>> picking what serial port to run getty on or whatever the issue may be.
>>
>> Some look at the kernel command line, and our bootloader provides
>> that too, so still no reason to fake alias names here.
> 
> 
> We have had this conversation earlier as well.
> 
> https://lore.kernel.org/linux-arm-kernel/CAK8P3a2VSBvOn1o+q1PYZaQ6LS9U4cz+DZGuDbisHkwNs2dAAw@mail.gmail.com/T/#m4ecb0dc6a78c84631f072faa1b0df0df46333d09
> 
> This is also the reason why we picked serial2 as linux console as a
> standard across the boards based on the ecosystem.
> 

I don't see either of those addressed in that thread, only that
the aliases should go in the .dts files and be trimmed, nothing
stops us from:

chosen {
	stdout-path = "serial10:115200n8";
};

aliases {
	serial10 = &main_uart8;
};

Andrew

  reply	other threads:[~2022-11-18 18:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 13:04 [PATCH v3 0/4] Add initial support for J784S4 SoC Apurva Nandan
2022-11-16 13:04 ` [PATCH v3 1/4] dt-bindings: arm: ti: Add bindings for J784s4 SoC Apurva Nandan
2022-11-16 13:04 ` [PATCH v3 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4 Apurva Nandan
2022-11-16 13:04 ` [PATCH v3 3/4] arm64: dts: ti: Add initial support for J784S4 SoC Apurva Nandan
2022-11-18 17:32   ` Andrew Davis
2022-11-18 17:45     ` Nishanth Menon
2022-11-18 19:41     ` Apurva Nandan
2022-11-16 13:04 ` [PATCH v3 4/4] arm64: dts: ti: Add support for J784S4 EVM board Apurva Nandan
2022-11-18 13:46   ` Manorit Chawdhry
2022-11-18 17:40   ` Andrew Davis
2022-11-18 17:47     ` Nishanth Menon
2022-11-18 17:56       ` Andrew Davis
2022-11-18 18:08         ` Nishanth Menon
2022-11-18 18:15           ` Andrew Davis [this message]
2022-11-18 19:27             ` Nishanth Menon
2022-11-18 21:08               ` Andrew Davis
2022-11-18 22:15                 ` Nishanth Menon
2022-11-22  7:35                   ` Tony Lindgren
2022-12-22 17:55                   ` Apurva Nandan
2022-11-22  7:51                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93242211-95e7-09a0-fced-5ef2deb9fc08@ti.com \
    --to=afd@ti.com \
    --cc=a-nandan@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hnagalla@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®