From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752545AbdJSMgy (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 08:36:54 -0400
Received: from mout.web.de ([217.72.192.78]:61159 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752507AbdJSMgw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 08:36:52 -0400
Subject: Re: [PATCH 4/4] char/tpm: Less checks in tpm_ibmvtpm_probe() after
 error detection
To: =?UTF-8?Q?Michal_Such=c3=a1nek?= <msuchanek@suse.de>,
        linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        Kenneth Goldman <kgold@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nayna Jain <nayna@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
 <09a2c3a1-1b10-507d-a866-258b570f6da1@users.sourceforge.net>
 <20171019135632.4af42743@kitsune.suse.cz>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <9327cc83-448e-8404-af00-73f6409e269e@users.sourceforge.net>
Date: Thu, 19 Oct 2017 14:36:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171019135632.4af42743@kitsune.suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:g68hRLDZRve4rTbrxidXs33UD7WWeUx79+3aE9XZL4Vq+MHrTbl
 Grqo595Xgniy7z71xDm8U8pEycwb/F0M088+0LFc7bsM/mcJMdPZj2YkjjNA+roSxGyQell
 iTNawjrEfoHJQdtUVGKCmlfiKeEY1T7FSPaJvznLObmSxYkvqtoy3bHjpxTqEjQWesE69vO
 mqvTco7NvSPn3RfB+IDIA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:zUIYy6Qfyuo=:2fIKjJzzig6lroowYKuGyn
 l0mcIRu6pDqzRpT4nNLWRedD+AsYEVulG61lKCzJeYmcuU2IXVM+bjNAKXNPEDbr2Bg/xAhSP
 ShNZypJ1r2QsBzyOM08YIOAyK6gR67RK7hkq/O+TDNw6NHkb8RIUaQN2RnTXjXI5yQHcLXBuq
 ySJWG9se/OEkutvsL3Gdqe0XecyMYLH50/D9JMF5CvxrmQfrGstN6AgHZ4RRCnPfaWRl5UBDD
 5j1OlsWGRh2wNSSoLNcit2ifRUbhmTjjnnBh015NaWjinGmO7cpG59YbkBoUXx7QpSBy8rMq0
 nbbiEAgCz67QKDpNXJeZWP47+k63GIIayM7UqCTM8/lCDYP1oZ/lLaPNNOzJ3evI51WxTnG3u
 2WZtXlBIFwTxiXUqfql2/lH8EOU19ec2iCHOu7Yx43vMR/F1MsIrqErtWKuydtXa/E5tUdpjf
 8r7h3QE8si7/CU5kw4KFZ06Q2VZb9PuI6ASsl4VVVRl116LqnNeSpmL+o7qq4xGQF8ovSCmuX
 +mFZznWu9OFxFPjhaMX5TYQz3aY756HxKtxXBr9gWo3ROW0psekaBumBhXtR3sNs4QB+1m7IK
 XmjSJlug8vciJJvjhuWOsDRZLyTph2fNBi+wzNNw79qGM9+/ahhXWWs7hh/zGAXOJr3KQVRlX
 U/7mSKYYa8W+3hxrxBS0OhOlIDM+nbLJGBnJmhh+Oju3fs0bra1SGUoljdR7PFy0JmeyqwTe1
 sPuuuXcnyqqvPgbsMxUVFXPGfayUcDkrOghOM55DA+tKxliJpp3+RC9ISWR/p+RTpPsyB87jr
 CafIsQ4I7fACoiHGcNx3rKJjZq91K5k/lLjdwsckUve3g0JZV0=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -683,13 +683,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
>> reg_crq_cleanup:
>>  	dma_unmap_single(dev, ibmvtpm->crq_dma_handle,
>> CRQ_RES_BUF_SIZE, DMA_BIDIRECTIONAL);
>> -cleanup:
>> -	if (ibmvtpm) {
>> -		if (crq_q->crq_addr)
>> -			free_page((unsigned long)crq_q->crq_addr);
>> -		kfree(ibmvtpm);
>> -	}
>> -
> 
> I think a single cleanup section is better than many labels that just
> avoid a single null check.

I proposed to delete two unnecessary condition checks together with
an adjustment of jump targets.

Regards,
Markus