From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbdBNJUr convert rfc822-to-8bit (ORCPT ); Tue, 14 Feb 2017 04:20:47 -0500 Received: from smtp.eu.citrix.com ([185.25.65.24]:34000 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdBNJUo (ORCPT ); Tue, 14 Feb 2017 04:20:44 -0500 X-IronPort-AV: E=Sophos;i="5.35,160,1484006400"; d="scan'208";a="40721738" From: Paul Durrant To: "'Boris Ostrovsky'" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" CC: Juergen Gross Subject: RE: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Thread-Topic: [PATCH v3 2/3] xen/privcmd: Add IOCTL_PRIVCMD_DM_OP Thread-Index: AQHShhsZ3/cU3+zvwkS5wM5k355CTKFnPNsAgAD9pdA= Date: Tue, 14 Feb 2017 09:20:42 +0000 Message-ID: <9328bb49eb634b0994e41f19733a373e@AMSPEX02CL03.citrite.net> References: <1487005404-3183-1-git-send-email-paul.durrant@citrix.com> <1487005404-3183-3-git-send-email-paul.durrant@citrix.com> <0ae0162c-4317-7dbf-fdce-354f71583d0a@oracle.com> In-Reply-To: <0ae0162c-4317-7dbf-fdce-354f71583d0a@oracle.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org My previous reply got bounced because my tablet insisted on using HTML... > -----Original Message----- > > These need to be static. (I can fix it when committing.) Ok, thanks. > > And I am still not sure about using XEN_PAGE_SIZE. There is no > dependency in the hypervisor on buffers being page-sized, is there? If > not, XEN_PAGE_SIZE is here just because it happens to be 4K, which is a > reasonable value. > > How about just setting it to 4096? > I chose XEN_PAGE_SIZE because the hypercall will eventually copy in the buffer so it seemed like a reasonable value to use. If you want to just use 4096 then I am ok with that. Paul PS: If you want to change from XEN_PAGE_SIZE to 4096 then I assume you are happy to do this at commit and don't need me to send a v4? > > -boris