mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add camera fixed regulators
Date: Tue, 16 Dec 2025 14:51:15 +0100	[thread overview]
Message-ID: <932a87de-ab2d-4a60-a188-04cc2c00898c@oss.qualcomm.com> (raw)
In-Reply-To: <20251210-fp4-cam-prep-v1-3-0eacbff271ec@fairphone.com>

On 12/10/25 2:05 AM, Luca Weiss wrote:
> Add multiple fixed regulators that are found on the phone, which provide
> power to the cameras.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 40 +++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index c2f856a56b2b..0cfb24e3941d 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -246,6 +246,46 @@ active-config0 {
>  			};
>  		};
>  	};
> +
> +	vreg_32m_cam_dvdd_1p05: regulator-32m-cam-dvdd-1p05 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "32M_CAM_DVDD_1P05";
> +		regulator-min-microvolt = <1050000>;
> +		regulator-max-microvolt = <1050000>;
> +		gpio = <&pm6150l_gpios 2 GPIO_ACTIVE_HIGH>;

It'd be useful to also explicitly describe the pinmux/cfg states
of the PMIC pins, since these can be a little surprising at boot

Konrad

  parent reply	other threads:[~2025-12-16 13:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10  1:05 [PATCH 0/4] Preparations for camera support on Fairphone 4 Luca Weiss
2025-12-10  1:05 ` [PATCH 1/4] dt-bindings: eeprom: at24: Add compatible for Giantec GT24P64A Luca Weiss
2025-12-11 16:55   ` Rob Herring (Arm)
2025-12-10  1:05 ` [PATCH 2/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add camera EEPROMs Luca Weiss
2025-12-16 12:10   ` Konrad Dybcio
2025-12-10  1:05 ` [PATCH 3/4] arm64: dts: qcom: sm7225-fairphone-fp4: Add camera fixed regulators Luca Weiss
2025-12-16 12:48   ` Bryan O'Donoghue
2025-12-16 13:51   ` Konrad Dybcio [this message]
2025-12-10  1:05 ` [PATCH 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Enable CCI pull-up Luca Weiss
2025-12-16 12:10   ` Konrad Dybcio
2025-12-17  9:22 ` (subset) [PATCH 0/4] Preparations for camera support on Fairphone 4 Bartosz Golaszewski
2026-01-05 14:07 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932a87de-ab2d-4a60-a188-04cc2c00898c@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®