From: James Smart <james.smart@broadcom.com>
To: Sagi Grimberg <sagi@grimberg.me>,
Johannes Thumshirn <jthumshirn@suse.de>,
Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] nvmet: use atomic allocations when allocating fc requests
Date: Tue, 12 Jun 2018 13:36:22 -0700 [thread overview]
Message-ID: <9331096f-8e5c-d029-e41c-96d5fa8b14fe@broadcom.com> (raw)
In-Reply-To: <3c91cf45-aa85-e1a5-6d25-5654131626dd@grimberg.me>
On 5/31/2018 2:31 AM, Sagi Grimberg wrote:
>
> Question, why isn't tfcp_req embedded in fcpreq? don't they have
> the same lifetime?
>
no they don't. To properly simulate cable-pulls, etc - the host side
and controller side effectively have their own "exchange" structure.
tfcp_req corresponds to the controller side. The lifetimes of the two
halves can differ.
-- james
next prev parent reply other threads:[~2018-06-12 20:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 7:40 [PATCH 0/5] Misc NVMe lockdep fixes Johannes Thumshirn
2018-05-15 7:40 ` [PATCHv2 1/5] nvme: fix lockdep warning in nvme_mpath_clear_current_path Johannes Thumshirn
2018-05-15 8:11 ` Christoph Hellwig
2018-05-31 9:22 ` Sagi Grimberg
2018-05-15 7:40 ` [PATCH 2/5] nvme: don't hold nvmf_transports_rwsem for more than transport lookups Johannes Thumshirn
2018-05-15 7:48 ` Christoph Hellwig
2018-05-31 9:24 ` Sagi Grimberg
2018-05-15 7:40 ` [PATCH 3/5] nvme: call nvmf_create_ctrl before checking for duplicate assignment Johannes Thumshirn
2018-05-15 7:50 ` Christoph Hellwig
2018-05-15 7:52 ` Johannes Thumshirn
2018-05-31 9:26 ` Sagi Grimberg
2018-05-15 7:40 ` [PATCH 4/5] nvmet: use atomic allocations when allocating fc requests Johannes Thumshirn
2018-05-31 9:31 ` Sagi Grimberg
2018-06-12 20:36 ` James Smart [this message]
2018-06-12 20:39 ` James Smart
2018-05-15 7:40 ` [PATCH 5/5] nvmet: fcloop: use irqsave spinlocks Johannes Thumshirn
2018-05-31 9:37 ` Sagi Grimberg
2018-06-12 20:41 ` James Smart
2018-06-12 20:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9331096f-8e5c-d029-e41c-96d5fa8b14fe@broadcom.com \
--to=james.smart@broadcom.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®