From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC8143D34BE for ; Wed, 18 Mar 2026 15:44:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773848684; cv=none; b=Mxjt1BpX/V7iWhJI+6WCrQad/XZqW+fUyPgfK6AAGSMthNkXCEis1OKwHluBqAVhS4gTn+Wq/7RQuMzh1qWnDOkWPAff49mOPHQe2YP01o9rGpXqkrPjteSZZARqzMdaSpqWVt8KmVadRNA7CtD3uj48lcRCq+GtKdR/yguS6hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773848684; c=relaxed/simple; bh=ZV3KInQLGd3uPYzuORJ1X33S+SuwwMzUMowroUZEgOo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=e24sT4RRMUlXT9oNjhNL2SOWqfMCMaXXCYy9dAM4TBk4lq/KeL4X8v4OdiUNgb8zIOmFLuqel0muyAUPhvvbLatRxsb5ZpPTqRj0nOoUGOGnOOMKwW/NzcJ73PhNS0wtWQSaZiQYSIfC/DxHw/0bTbcymYQQFub9Al9vMEdv1YY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BRpEnBds; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=f28ylMnF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BRpEnBds"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="f28ylMnF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773848680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LESUGcaG78coVQnZtnSJQ6wL5uHkv7Ld/Kg5l704lIY=; b=BRpEnBdsNwoCz7ncPDhj4rNjAPKNPbXwePjNaMBHy7kmY5kvUw5Hxpk7BH1cqP1JzWPFNm ZuaovOq1rO2WY933O5kTMBYZ4yCC0snTfe9IOgPR3RGIRE56dxwdSqHSz2pD4i4YZNmEi7 2OgEkI08mlNX/3Ct/dqDvikPPeS17Eg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-NSWuM02IPXmi1StiexPsXQ-1; Wed, 18 Mar 2026 11:44:39 -0400 X-MC-Unique: NSWuM02IPXmi1StiexPsXQ-1 X-Mimecast-MFC-AGG-ID: NSWuM02IPXmi1StiexPsXQ_1773848678 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43b46b2b161so3291973f8f.0 for ; Wed, 18 Mar 2026 08:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773848678; x=1774453478; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=LESUGcaG78coVQnZtnSJQ6wL5uHkv7Ld/Kg5l704lIY=; b=f28ylMnFmOzCeMbEVb9SS3n8AlJIYyBKDDGdh5nIVbLxq4JCNmTTI4zCmRQvJTATQc DqJ44GNi1z6hw+hut7DegTY+7YQneKnOGbJvjEisoGam6cU083yKi0uyHX8Yn+PMCq4+ TPK5PsySPAFimIZURGyIaqEJDyBwlGkehZog/lXvvrQKfqMigyFfjuOyzSz+sJnKVxgx iHYGGP0SQfWE3U2pUESi+0+2sZyT+LVrhiIAdP/QeDG7nPNi2W94PwOieBlnya/dzIme /U+13TImT4dH0cylK3Zm7UIgpQN31jtXs2Gys4m3u3wxenoCJ7+5aWL5HvVpbuOacUeT HcNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773848678; x=1774453478; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LESUGcaG78coVQnZtnSJQ6wL5uHkv7Ld/Kg5l704lIY=; b=l+hbccToD2NI4mlEgEw9609IYeuQ3GJnglkD8dyv7mSCgXd0egKBO72jLAUkLj5o8Z d1G0RiJ8heub84oNy1H0T6P8b3CdGMXqcE9cEGur4Q2w+SarTyvBY+uXnP0HQP3gKKvs H4fxDRGym5rYwIua9hRMqpajiX/PE5H+CguCmKXkqR3zc5zrFPcROzCeH9PEGzBw0DeY tStRRzXlGDrjltvDH08NDra63iTcDFbyzuNE2kOak09yf0vzKLP45BXgGYpDHYfWGO30 gmW2af9zTTlDjxg1V4Zd+gTDBp7kIM6/9u1KzLupKSiDy6g80koFttV1bvLCcm8T46VQ ooqg== X-Forwarded-Encrypted: i=1; AJvYcCXaAbilUPmKGklZc1aq7aqccKWNvMn/e+4T2sQfat6wHwzaPVL9lUaLAZalCW1KxbfiH8bQh5iNJp2f+xo=@vger.kernel.org X-Gm-Message-State: AOJu0YyD097wcoETMB6sMdUmQfyI0F36U4dOnoe2pv3KS+VpgKGI3wPR mx0mswqGtF4if0PxZig4uXTc7cNLHz944bn3nuFx2d8RGfgW2CA9ksviFkzxin31fG9aL9/boyo 6O13aJ+h63zhOKlD4SbJYSZN6azyKVJi/MXLnrSEqgIx+Vfcrxm08D0oIRBEiVWfgqQ== X-Gm-Gg: ATEYQzwLF2LXQMvH8UrofwRmM4SdJ3/m1dnNoj+gPpVQD32aZLFmMeNMw8GaLlHeaCK l7KosYwfzcgep3+yebZzCTc+pDUG4AzmrIO590SarhITHMfVUq8nY6aD/Xk2bygiDZ+WB31ZmWM 2u7UzPXLrMlgUMdwTHXD86jSDHcjvof/RqLXiUk2j1GArzzU9zlzeSpNHdeuHakypap7ANM313j B5JpODznw/EyM+bO4svEOZAmDoPZ0LYgoGy9efBE4q7p+j/aetN94OqK9KWqxQPnNVaI+tIH6OB PZbYi1NbxApBJ1p857yZtcnqilGePaOC3+jF4oe46rAwxACF8nm9lZ06xOiPTvzxKDUpltyV2DK 55/1SRMme5/4JtPYDUhA8BT48rA== X-Received: by 2002:a05:6000:2dc5:b0:43b:433f:95c9 with SMTP id ffacd0b85a97d-43b527c4e15mr6772123f8f.35.1773848677986; Wed, 18 Mar 2026 08:44:37 -0700 (PDT) X-Received: by 2002:a05:6000:2dc5:b0:43b:433f:95c9 with SMTP id ffacd0b85a97d-43b527c4e15mr6772075f8f.35.1773848677496; Wed, 18 Mar 2026 08:44:37 -0700 (PDT) Received: from [192.168.1.166] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5184961csm9522411f8f.6.2026.03.18.08.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 08:44:36 -0700 (PDT) Message-ID: <93326862189ea258b17edfd2a272be82834092fa.camel@redhat.com> Subject: Re: [PATCH v7 08/15] sched: Add task enqueue/dequeue trace points From: gmonaco@redhat.com To: Peter Zijlstra , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Steven Rostedt , Nam Cao , Juri Lelli , Masami Hiramatsu , Ingo Molnar , K Prateek Nayak , Tomas Glozar , Clark Williams , John Kacur Date: Wed, 18 Mar 2026 16:44:34 +0100 In-Reply-To: <20260310105627.332044-9-gmonaco@redhat.com> References: <20260310105627.332044-1-gmonaco@redhat.com> <20260310105627.332044-9-gmonaco@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Peter, On Tue, 2026-03-10 at 11:56 +0100, Gabriele Monaco wrote: > From: Nam Cao >=20 > Add trace points into enqueue_task() and dequeue_task(). >=20 > Signed-off-by: Nam Cao > Suggested-by: Peter Zijlstra > Reviewed-by: K Prateek Nayak > Co-developed-by: Gabriele Monaco > Signed-off-by: Gabriele Monaco > --- Could I get an Ack for this? Thanks, Gabriele >=20 > Notes: > =C2=A0=C2=A0=C2=A0 V7: > =C2=A0=C2=A0=C2=A0 * Use cpu_of(rq) helper in tracepoint calls > =C2=A0=C2=A0=C2=A0 V5: > =C2=A0=C2=A0=C2=A0 * Do not fire enqueue tracepoint for delayed enqueues >=20 > =C2=A0include/trace/events/sched.h |=C2=A0 8 ++++++++ > =C2=A0kernel/sched/core.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 12 +++++++++++- > =C2=A0kernel/sched/sched.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 2 ++ > =C2=A03 files changed, 21 insertions(+), 1 deletion(-) >=20 > diff --git a/include/trace/events/sched.h > b/include/trace/events/sched.h > index 7b2645b50e78..5844147ec5fd 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -896,6 +896,14 @@ DECLARE_TRACE(sched_set_need_resched, > =C2=A0 TP_PROTO(struct task_struct *tsk, int cpu, int tif), > =C2=A0 TP_ARGS(tsk, cpu, tif)); > =C2=A0 > +DECLARE_TRACE(sched_enqueue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > +DECLARE_TRACE(sched_dequeue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > =C2=A0#endif /* _TRACE_SCHED_H */ > =C2=A0 > =C2=A0/* This part must be outside protection */ > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index b7f77c165a6e..c9ca1e048612 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -122,6 +122,8 @@ > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_compute_energy_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_entry_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_enqueue_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dequeue_tp); > =C2=A0 > =C2=A0DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > =C2=A0DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); > @@ -2094,6 +2096,9 @@ unsigned long get_wchan(struct task_struct *p) > =C2=A0 > =C2=A0void enqueue_task(struct rq *rq, struct task_struct *p, int flags) > =C2=A0{ > + if (trace_sched_enqueue_tp_enabled() && !(flags & > ENQUEUE_DELAYED)) > + trace_sched_enqueue_tp(p, cpu_of(rq)); > + > =C2=A0 if (!(flags & ENQUEUE_NOCLOCK)) > =C2=A0 update_rq_clock(rq); > =C2=A0 > @@ -2120,6 +2125,8 @@ void enqueue_task(struct rq *rq, struct > task_struct *p, int flags) > =C2=A0 */ > =C2=A0inline bool dequeue_task(struct rq *rq, struct task_struct *p, int > flags) > =C2=A0{ > + bool ret; > + > =C2=A0 if (sched_core_enabled(rq)) > =C2=A0 sched_core_dequeue(rq, p, flags); > =C2=A0 > @@ -2136,7 +2143,10 @@ inline bool dequeue_task(struct rq *rq, struct > task_struct *p, int flags) > =C2=A0 * and mark the task ->sched_delayed. > =C2=A0 */ > =C2=A0 uclamp_rq_dec(rq, p); > - return p->sched_class->dequeue_task(rq, p, flags); > + ret =3D p->sched_class->dequeue_task(rq, p, flags); > + if (trace_sched_dequeue_tp_enabled() && !(flags & > DEQUEUE_SLEEP)) > + trace_sched_dequeue_tp(p, cpu_of(rq)); > + return ret; > =C2=A0} > =C2=A0 > =C2=A0void activate_task(struct rq *rq, struct task_struct *p, int flags) > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 43bbf0693cca..d7ab0aa58a70 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -2955,6 +2955,8 @@ static inline void sub_nr_running(struct rq > *rq, unsigned count) > =C2=A0 > =C2=A0static inline void __block_task(struct rq *rq, struct task_struct > *p) > =C2=A0{ > + trace_sched_dequeue_tp(p, cpu_of(rq)); > + > =C2=A0 if (p->sched_contributes_to_load) > =C2=A0 rq->nr_uninterruptible++; > =C2=A0