From: Mimi Zohar <zohar@linux.ibm.com>
To: "Jérémy Jean" <Jeremy.Jean@oss.cyber.gouv.fr>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>
Cc: Eric Snowberg <eric.snowberg@oracle.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ima: audit failure to supply detached data for modsig
Date: Fri, 23 Oct 2026 13:36:17 -0400 [thread overview]
Message-ID: <9336bd484bcd0af6e9c88b7b546434e5081ab449.camel@linux.ibm.com> (raw)
In-Reply-To: <20261021210145.1851396-5-Jeremy.Jean@oss.cyber.gouv.fr>
On Wed, 2026-10-21 at 21:01 +0000, Jérémy Jean wrote:
>
> @@ -326,15 +329,20 @@ int ima_collect_measurement(struct ima_iint_cache *iint, struct file *file,
> if (!result)
> iint->flags |= IMA_COLLECTED;
> out:
> - if (result) {
> + if (result || modsig_result) {
> if (file->f_flags & O_DIRECT)
> audit_cause = "failed(directio)";
>
> take_dentry_name_snapshot(&filename, file->f_path.dentry);
>
> - integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode,
> - filename.name.name, "collect_data",
> - audit_cause, result, 0);
> + if (modsig_result)
> + integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode,
> + filename.name.name, "collect_data",
> + "failed-modsig", modsig_result, 0);
> + if (result)
> + integrity_audit_msg(AUDIT_INTEGRITY_DATA, inode,
> + filename.name.name, "collect_data",
> + audit_cause, result, 0);
Frederick Lawler's patch updated integrity_audit_msg() to include errno. These
calls need to be updated.
Mimi
>
> release_dentry_name_snapshot(&filename);
> }
next prev parent reply other threads:[~2026-10-23 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 21:01 [PATCH v3 0/2] ima: reject modsig when detached data cannot be supplied Jérémy Jean
2026-10-21 21:01 ` [PATCH v3 1/2] ima: discard " Jérémy Jean
2026-10-23 17:34 ` Mimi Zohar
2026-10-21 21:01 ` [PATCH v3 2/2] ima: audit failure to supply detached data for modsig Jérémy Jean
2026-10-23 17:36 ` Mimi Zohar [this message]
2026-10-24 9:40 ` Jérémy Jean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9336bd484bcd0af6e9c88b7b546434e5081ab449.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=Jeremy.Jean@oss.cyber.gouv.fr \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®