From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751530AbdGZPuy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Jul 2017 11:50:54 -0400
Received: from mx2.suse.de ([195.135.220.15]:56643 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751013AbdGZPux (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Jul 2017 11:50:53 -0400
Subject: Re: [PATCH v1] xen: get rid of paravirt op adjust_exception_frame
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        X86 ML <x86@kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>
References: <20170724142853.26448-1-jgross@suse.com>
 <CALCETrVqUYbFiGLi1mqNq5ej5zT1cnfPk=3dwDu9D8kNFTQasw@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <93384be6-55b8-47e1-0478-150f9c906605@suse.com>
Date: Wed, 26 Jul 2017 17:50:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CALCETrVqUYbFiGLi1mqNq5ej5zT1cnfPk=3dwDu9D8kNFTQasw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26/07/17 15:48, Andy Lutomirski wrote:
> On Mon, Jul 24, 2017 at 7:28 AM, Juergen Gross <jgross@suse.com> wrote:
>> When running as Xen pv-guest the exception frame on the stack contains
>> %r11 and %rcx additional to the other data pushed by the processor.
>>
>> Instead of having a paravirt op being called for each exception type
>> prepend the Xen specific code to each exception entry. When running as
>> Xen pv-guest just use the exception entry with prepended instructions,
>> otherwise use the entry without the Xen specific code.
> 
> I think this is a nice cleanup, but I'm wondering if it would be even
> nicer if the Xen part was kept out-of-line.  That is, could Xen have
> little stubs like:
> 
> xen_alignment_check:
>   pop %rcx
>   pop %r11
>   jmp alignment_check
> 
> rather than using the macros in entry_64.S that you have?  Then you
> could adjust set_trap_gate instead of pack_gate and maybe even do
> something like:
> 
> #define set_trap_gate(..., name, ...) set_native_or_xen_trap_gate(...,
> name, xen_##name, ...)

I think I'll have something like:

#define pv_trap_entry(name) (xen_pv_domain() ? xen_ ## name : name)

and use it like:

set_intr_gate(X86_TRAP_AC, pv_trap_entry(alignment_check));

This will avoid having to define macros for all variants of
set_intr_gate(), e.g. set_intr_gate_ist(), set_system_intr_gate().

Do you have any objections?


Juergen