mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Biancaa Ramesh <biancaa2210329@ssn.edu.in>,
	linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [PATCH] ath9k_htc: fix WMI command handling and improve message sending
Date: Tue, 21 Oct 2025 22:11:08 +0200	[thread overview]
Message-ID: <933b7662-8ed2-40d0-b959-fba4f7342d71@web.de> (raw)
In-Reply-To: <20251021141337.33268-1-biancaa2210329@ssn.edu.in>

…
> ---
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c | 139 +++++++-----------
…

Thanks for your try to improve the implementation of the function “ath9k_htc_add_monitor_interface”.
https://elixir.bootlin.com/linux/v6.18-rc2/source/drivers/net/wireless/ath/ath9k/htc_drv_main.c#L350-L437

Please recheck the indentation approach accordingly.
Not all leading tab characters need to be replaced by space characters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc2#n18


I miss some information so far.

1. Helpful change description
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n45

2. More appropriate recipient selection
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n231


…
> -- 
> ::DISCLAIMER::
…
> The 
> contents of this e-mail and any attachment(s) are confidential and
…

Please reconsider such hints once more for communication by the means of public mailing lists.
https://subspace.kernel.org/etiquette.html#do-not-include-confidentiality-disclaimers

Regards,
Markus

  reply	other threads:[~2025-10-21 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 14:13 Biancaa Ramesh
2025-10-21 20:11 ` Markus Elfring [this message]
2025-10-22  3:24 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=933b7662-8ed2-40d0-b959-fba4f7342d71@web.de \
    --to=markus.elfring@web.de \
    --cc=biancaa2210329@ssn.edu.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®