From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ezequiel Garcia <ezequiel@collabora.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Tomasz Figa <tfiga@chromium.org>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
kernel@collabora.com,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Jonas Karlman <jonas@kwiboo.se>, Heiko Stuebner <heiko@sntech.de>,
Boris Brezillon <boris.brezillon@collabora.com>,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: [PATCH v5 0/6] media: rockchip: Add the rkvdec driver
Date: Thu, 20 Feb 2020 09:45:37 +0100 [thread overview]
Message-ID: <933b8189-5541-a7ff-e1dc-05ca3b2d65d5@xs4all.nl> (raw)
In-Reply-To: <20200219173750.26453-1-ezequiel@collabora.com>
On 2/19/20 6:37 PM, Ezequiel Garcia wrote:
> Hello,
>
> This is v5 of Boris' rkvdec driver.
>
> This version corrects wrong copyright notices and then adds
> a TODO file for the staging driver. The only reason to keep the
> driver in staging are the staging uAPI controls.
I got some sparse warnings for this series, should be trivial to fix:
sparse: WARNINGS
drivers/media/v4l2-core/v4l2-h264.c:214: warning: Function parameter or member 'reflist' not described in 'v4l2_h264_build_p_ref_list'
drivers/media/v4l2-core/v4l2-h264.c:214: warning: Excess function parameter 'p_reflist' description in 'v4l2_h264_build_p_ref_list'
SPARSE:drivers/staging/media/rkvdec/rkvdec.c drivers/staging/media/rkvdec/rkvdec.c:561:22: warning: symbol 'rkvdec_queue_ops' was not
declared. Should it be static?
Also, checkpatch.pl --strict complains about empty trailing lines in two
files.
Together with the missing MAINTAINERS it is probably best if you post
a v6.
Regards,
Hans
>
> Thanks,
> Ezequiel
>
> Boris Brezillon (5):
> media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists
> media: hantro: h264: Use the generic H264 reflist builder
> media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings
> media: rkvdec: Add the rkvdec driver
> arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node
>
> Jonas Karlman (1):
> media: uapi: h264: Add DPB entry field reference flags
>
> .../bindings/media/rockchip,vdec.yaml | 71 +
> .../media/uapi/v4l/ext-ctrls-codec.rst | 16 +
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +-
> drivers/media/v4l2-core/Kconfig | 4 +
> drivers/media/v4l2-core/Makefile | 1 +
> drivers/media/v4l2-core/v4l2-h264.c | 258 ++++
> drivers/staging/media/Kconfig | 2 +
> drivers/staging/media/Makefile | 1 +
> drivers/staging/media/hantro/Kconfig | 1 +
> drivers/staging/media/hantro/hantro_h264.c | 237 +---
> drivers/staging/media/rkvdec/Kconfig | 15 +
> drivers/staging/media/rkvdec/Makefile | 3 +
> drivers/staging/media/rkvdec/TODO | 11 +
> drivers/staging/media/rkvdec/rkvdec-h264.c | 1154 +++++++++++++++++
> drivers/staging/media/rkvdec/rkvdec-regs.h | 223 ++++
> drivers/staging/media/rkvdec/rkvdec.c | 1134 ++++++++++++++++
> drivers/staging/media/rkvdec/rkvdec.h | 123 ++
> include/media/h264-ctrls.h | 2 +
> include/media/v4l2-h264.h | 86 ++
> 19 files changed, 3126 insertions(+), 230 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> create mode 100644 drivers/media/v4l2-core/v4l2-h264.c
> create mode 100644 drivers/staging/media/rkvdec/Kconfig
> create mode 100644 drivers/staging/media/rkvdec/Makefile
> create mode 100644 drivers/staging/media/rkvdec/TODO
> create mode 100644 drivers/staging/media/rkvdec/rkvdec-h264.c
> create mode 100644 drivers/staging/media/rkvdec/rkvdec-regs.h
> create mode 100644 drivers/staging/media/rkvdec/rkvdec.c
> create mode 100644 drivers/staging/media/rkvdec/rkvdec.h
> create mode 100644 include/media/v4l2-h264.h
>
prev parent reply other threads:[~2020-02-20 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:37 Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 1/6] media: uapi: h264: Add DPB entry field reference flags Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 2/6] media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 3/6] media: hantro: h264: Use the generic H264 reflist builder Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 4/6] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 5/6] media: rkvdec: Add the rkvdec driver Ezequiel Garcia
2020-02-19 17:37 ` [PATCH v5 6/6] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node Ezequiel Garcia
2020-02-20 8:24 ` [PATCH v5 0/6] media: rockchip: Add the rkvdec driver Hans Verkuil
2020-02-20 8:45 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933b8189-5541-a7ff-e1dc-05ca3b2d65d5@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas@ndufresne.ca \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®