mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Nikhil Solanke <nikhilsolanke5@gmail.com>
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, michal.pecio@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] usbcore: Add quirk for 255-bytes initial config read
Date: Tue, 23 Jun 2026 09:17:38 -0400	[thread overview]
Message-ID: <933c5d7a-e512-460a-992c-25be64ff48cf@rowland.harvard.edu> (raw)
In-Reply-To: <CAFgddhLVAp7nMX4YUHoaG+Q_Hm6w1uq9df2kH+4RWiJJGYDdhw@mail.gmail.com>

On Tue, Jun 23, 2026 at 01:01:12PM +0530, Nikhil Solanke wrote:
> I have a v2 patch ready with all the requested changes along with the
> documentation in Documentation/admin-guide/kernel-parameters.txt. Is
> there any other place where I have to write documentation?

No.

> Also, I would like to know the "low-level" type reason as to why do we
> have 2 separate buffers. a desc and then a bigbuffer? Why don't we
> just realloc the desc buffer? Does this have something to do with
> reallocs in general?

No particular reason.  I guess it just seemed more straightforward to 
allocate a second, larger buffer than to expand the first, smaller 
buffer.

> Also (a bit more tangent), can the usb device potentially fingerprint
> the host os? if we are asking for 9 bytes first and windows ask for
> 255, is it possible that some usb devices will fingerprint the OS
> based on this, and behave differently? are there any other such places
> where fingerprinting is possible? In those cases, is it theoretically
> possible that this patch might fix some weird devices that "seem to
> work" on windows but not on linux?

Of course it's possible.  Devices can do whatever they want, as long as 
they obey the requirements of the USB spec.

>  I might just add this one line to
> documentation that it might theoretically fix other usb devices as
> well instead of it just being a quirk to fix a game controller.

Isn't that true of any quirk?  As a theoretical possibility, I mean.

Alan Stern

      reply	other threads:[~2026-06-23 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  9:59 Nikhil Solanke
2026-06-19 19:46 ` Alan Stern
2026-06-20  7:08   ` Nikhil Solanke
2026-06-20 14:37     ` Alan Stern
2026-06-23  7:31       ` Nikhil Solanke
2026-06-23 13:17         ` Alan Stern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=933c5d7a-e512-460a-992c-25be64ff48cf@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.pecio@gmail.com \
    --cc=nikhilsolanke5@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®