From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942825AbdAJCud (ORCPT ); Mon, 9 Jan 2017 21:50:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3809 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584AbdAJCuU (ORCPT ); Mon, 9 Jan 2017 21:50:20 -0500 Subject: Re: [PATCH] vhost: scsi: constify target_core_fabric_ops structures To: Bhumika Goyal , julia.lawall@lip6.fr, mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1483975262-1260-1-git-send-email-bhumirks@gmail.com> From: Jason Wang Message-ID: <933d05a8-aabd-0cd8-1adf-d36af62a8e0c@redhat.com> Date: Tue, 10 Jan 2017 10:50:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483975262-1260-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 10 Jan 2017 02:50:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年01月09日 23:21, Bhumika Goyal wrote: > Declare target_core_fabric_ops strucrues as const as they are only > passed as an argument to the functions target_register_template and > target_unregister_template. The arguments are of type const struct > target_core_fabric_ops *, so target_core_fabric_ops structures having > this property can be declared const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct target_core_fabric_ops i@p={...}; > > @ok@ > position p; > identifier r.i; > @@ > ( > target_register_template(&i@p) > | > target_unregister_template(&i@p) > ) > @bad@ > position p!={r.p,ok.p}; > identifier r.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > +const > struct target_core_fabric_ops i; > > File size before: drivers/vhost/scsi.o > text data bss dec hex filename > 18063 2985 40 21088 5260 drivers/vhost/scsi.o > > File size after: drivers/vhost/scsi.o > text data bss dec hex filename > 18479 2601 40 21120 5280 drivers/vhost/scsi.o > > Signed-off-by: Bhumika Goyal > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 253310c..620366d 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -2087,7 +2087,7 @@ static void vhost_scsi_drop_tport(struct se_wwn *wwn) > NULL, > }; > > -static struct target_core_fabric_ops vhost_scsi_ops = { > +static const struct target_core_fabric_ops vhost_scsi_ops = { > .module = THIS_MODULE, > .name = "vhost", > .get_fabric_name = vhost_scsi_get_fabric_name, Acked-by: Jason Wang