From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbeEQGnc (ORCPT ); Thu, 17 May 2018 02:43:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:57866 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbeEQGna (ORCPT ); Thu, 17 May 2018 02:43:30 -0400 Subject: Re: [PATCH] xen-netfront: fix xennet_start_xmit()'s return type To: Luc Van Oostenryck , linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org, netdev@vger.kernel.org References: <20180424131815.5064-1-luc.vanoostenryck@gmail.com> From: Juergen Gross Message-ID: <934aa4fe-30ef-10b7-96d7-995ee7a4d6a0@suse.com> Date: Thu, 17 May 2018 08:43:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180424131815.5064-1-luc.vanoostenryck@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/04/18 15:18, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Pushed to xen/tip.git for-linus-4.18 Juergen