mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Frank Wunderlich <linux@fw-web.de>
Cc: "MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Georgi Djakov" <djakov@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Jia-Wei Chang" <jia-wei.chang@mediatek.com>,
	"Johnson Wang" <johnson.wang@mediatek.com>,
	"Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"DENG Qingfang" <dqfext@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Felix Fietkau" <nbd@nbd.name>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
Date: Sun, 8 Jun 2025 23:31:39 +0200	[thread overview]
Message-ID: <934b1515-2da1-4479-848e-cd2475ebe98d@lunn.ch> (raw)
In-Reply-To: <20250608211452.72920-13-linux@fw-web.de>

> +&gmac1 {
> +	phy-mode = "internal";
> +	phy-connection-type = "internal";

ethernet-controller.yaml says:

  phy-connection-type:
    description:
      Specifies interface type between the Ethernet device and a physical
      layer (PHY) device.
    enum:
      # There is not a standard bus between the MAC and the PHY,
      # something proprietary is being used to embed the PHY in the
      # MAC.
      - internal
      - mii
      - gmii
  ...

  phy-mode:
    $ref: "#/properties/phy-connection-type"


so phy-mode and phy-connection-type are the same thing.

> +	/* SFP2 cage (LAN) */
> +	sfp2: sfp2 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&i2c_sfp2>;
> +		los-gpios = <&pio 2 GPIO_ACTIVE_HIGH>;
> +		mod-def0-gpios = <&pio 83 GPIO_ACTIVE_LOW>;
> +		tx-disable-gpios = <&pio 0 GPIO_ACTIVE_HIGH>;
> +		tx-fault-gpios = <&pio 1 GPIO_ACTIVE_HIGH>;
> +		rate-select0-gpios = <&pio 3 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <3000>;

sff,sfp.yaml says:

  maximum-power-milliwatt:
    minimum: 1000
    default: 1000
    description:
      Maximum module power consumption Specifies the maximum power consumption
      allowable by a module in the slot, in milli-Watts. Presently, modules can
      be up to 1W, 1.5W or 2W.

I've no idea what will happen when the SFP core sees 3000. Is the
comment out of date?

	Andrew


  reply	other threads:[~2025-06-08 21:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-08 21:14 [PATCH v3 00/13] further mt7988 devicetree work Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 01/13] dt-bindings: net: mediatek,net: update for mt7988 Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 02/13] dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition " Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 03/13] dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 04/13] dt-bindings: interconnect: add mt7988-cci compatible Frank Wunderlich
2025-06-11  9:40   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 05/13] arm64: dts: mediatek: mt7988: add cci node Frank Wunderlich
2025-06-11  9:34   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 06/13] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Frank Wunderlich
2025-06-08 21:23   ` Andrew Lunn
2025-06-09 10:28     ` Aw: " Frank Wunderlich
2025-06-09 12:12       ` Andrew Lunn
2025-06-10  9:42         ` Aw: " Frank Wunderlich
2025-06-08 21:24   ` Daniel Golle
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-11  9:53     ` Aw: " Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 07/13] arm64: dts: mediatek: mt7988: add switch node Frank Wunderlich
2025-06-08 21:25   ` Andrew Lunn
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 08/13] arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 09/13] arm64: dts: mediatek: mt7988a-bpi-r4: drop unused pins Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 10/13] arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-11 10:33     ` Aw: " Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 11/13] arm64: dts: mediatek: mt7988a-bpi-r4: add aliase for ethernet Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-08 21:14 ` [PATCH v3 12/13] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac Frank Wunderlich
2025-06-08 21:31   ` Andrew Lunn [this message]
2025-06-10  9:03     ` Aw: " Frank Wunderlich
2025-06-10 12:58       ` Andrew Lunn
2025-06-10 13:32         ` Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno
2025-06-11 10:44     ` Aw: " Frank Wunderlich
2025-06-08 21:14 ` [PATCH v3 13/13] arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds Frank Wunderlich
2025-06-11  9:33   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=934b1515-2da1-4479-848e-cd2475ebe98d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Landen.Chao@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arinc.unal@arinc9.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=frank-w@public-files.de \
    --cc=jia-wei.chang@mediatek.com \
    --cc=johnson.wang@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@fw-web.de \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®