From: Zijun Hu <zijun_hu@icloud.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages
Date: Fri, 25 Apr 2025 19:36:42 +0800 [thread overview]
Message-ID: <934c275b-1ea8-4a09-b2cb-6c9bca2860f3@icloud.com> (raw)
In-Reply-To: <CAL_JsqKs=5Uf1rJy3iBROL5ZZVo62cTbNq+yzKr2DXU+Nhabbg@mail.gmail.com>
On 2025/4/25 02:34, Rob Herring wrote:
>> @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
>> goto err_rpm_disable;
>> }
>>
>> - dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
>> - dev_name(&ctrl->dev), &ctrl->dev);
> I don't understand why you add dev_name() and then turn around and
> remove it in the next patch. Just squash the patches.
okay, will do it in next revision.
next prev parent reply other threads:[~2025-04-25 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 12:23 [PATCH v2 0/2] serdev: Improve messages printed by dev_err() and dev_dbg() Zijun Hu
2025-04-24 12:23 ` [PATCH v2 1/2] serdev: Get serdev controller's name by dev_name() Zijun Hu
2025-04-24 12:23 ` [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages Zijun Hu
2025-04-24 18:34 ` Rob Herring
2025-04-25 11:36 ` Zijun Hu [this message]
2025-04-25 5:38 ` Jiri Slaby
2025-04-25 11:37 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=934c275b-1ea8-4a09-b2cb-6c9bca2860f3@icloud.com \
--to=zijun_hu@icloud.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®