From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9781D3E9C0B for ; Fri, 15 May 2026 09:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836234; cv=none; b=nOE/q/5+5K5w1J8FkwO8wYy17d4aWG+wTuxnVaXUfyjPcIAQi6hd1ZvBn1odgqneNAnCpto3A1BtO8xTD5TbLsGbt7M01a3Ys2C1Pktita/xq4Qkma6dUA1z8RBY/dSQKFPW8LDNTFfv2joRRHVNPmdiW6a2fjDNmh9+MzpAFAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778836234; c=relaxed/simple; bh=NAlYr5OBkji2DJxmosxyZUEB0sJ0e4O5IXDaacLjWjI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M4swcX1Q3r++niaaP2vg5s+LkdA481ENdTWOBwx5z5KhT4lSCXsCXeq0VnMAQoSY+II4Kvlb2zs41S2Dkt0w/wdad1CPHfYg7oY1eL9wk2jK0EGC6vhInAWy5kB0bD8OVadJBN7xgwKAzmbSWh9L3si/lYUCX4UwdqFQWesJA5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K4twMkWs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C2TzaBV0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K4twMkWs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C2TzaBV0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F5GvKt3198067 for ; Fri, 15 May 2026 09:10:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Y33Kq8jS4pkB9lQwGZwmPZHQOGa7dfJetj4tNP3diP8=; b=K4twMkWsVKO4ydqM +x7fLcIUaYUdC4pZjQ4nzmCwJCNDSpko9ngzcGuQ7lfJI5A4gLCXHL81OpCqbGOG yhasSoIeNqzJiNwh1/RafZEvUpGZrp0tjybRvB4iP/sRM1zcgO0Iri0a/QKtqQ3a QYL4LX60xgHH68IMK/tb9gD87084M5OpiNYKDYHAW6K5MRomzYic50cPbfbfAWFU IeMu+4qqlENVZAULizM91LjB4jtfQdv83n2G8H+k8BpUH9obttqNPpZGpSR45cC+ R2ZS7gpswo00/woXaYryEbWcMeEkQ2xQwQ32hEt2MaCiGrk0DN9DUBPoU0JBKh0+ dgQr7g== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1qahdp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 09:10:32 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-6313443ffa2so646033137.2 for ; Fri, 15 May 2026 02:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778836232; x=1779441032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y33Kq8jS4pkB9lQwGZwmPZHQOGa7dfJetj4tNP3diP8=; b=C2TzaBV01qjOFUAjkfk4GhhuZ6zjdAZ4KNwrLseErhUZwCKLch4ygFbUvD2jv/2n0g GPf5OSfTo82maKf2Ib3cXpXY1H1YJKR+kIClo45ba10/1LWAxWHnHsN6U7knh0yuLjYb CMM1pWokuXSSM0aKFi0APiMcq4sHH5huvlZ4Ihgska4b1d0rN8spNDBUgZ15HtFbjkOs PypVbg+SpQyZC4TJB9jY4ZRdQ+tQiZbH8k39kSWHJGNGRZlIB8u8neWaiPA6azMQL2XR oEMLW59cp6D8McxZKhFGoGu2yu/MJTvFNVyDYIL7CkWusxMk2cY5+keU+LbG+lfzUULa /gaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778836232; x=1779441032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y33Kq8jS4pkB9lQwGZwmPZHQOGa7dfJetj4tNP3diP8=; b=KQQB5/EgYn5ev8KZefMQ0/ZNq5x0juA7DpWMIuQjUURmSk/OHfL69OPj+u3AGcfEBX yr4Nohpgzs0f/q2k5LslpAIKf1P0aFo9Y63esOT7+3EfifVnUgOzPHWV6nTmzOV02f6S TvyF6aORstW4dRNFx77e5zHAguVW9pBdPbfp7d6xVRlU/alrm8Gij0E7xwlewgZEH3qC sG33154f/6QzvETHwKShpCR2OIAmeU3eWDIBSmK+1Ct84lioetib/hRgDJ3NZG1B8Ulo Vf6bdcYvs6ghxn2wIlHX0KBjFxm2pWqdw0JTrFm+k9ApLrPCkzoH7X7Iw4EddIEfrowq Nqzw== X-Forwarded-Encrypted: i=1; AFNElJ99tzG3slTYIz0idEDp6pyhfqFevuUN992IgoKr3T7zBYmBf8bIBVu3fuB+yDn9SpcTCBpRlj4YpnGZFNY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2SN0E8XTU2V2Ory5FULGlH8hMtkPm94BN6C+monOvgPesOqNT 7Jvt+8ClTSd/v8lZE52ZvEYEp8o+Oyl8gomoNP9OdiAJWP/gwJSzX3ydaTiBZjroRYH9oIKlMD/ 0Csfy38ARFWDIp6DJP2eTjloIXQntqyYRtkMrJuIfMmPSRBD7RVHHrqZeL1cSsbq9depZ+yhjEn I= X-Gm-Gg: Acq92OGfWucB+43mELGIObpoXZV/KI31x5FOQD1GFRxwoyvE3jL71aGK36v2HhdwJ3v +/R1g+IwtfTzJAAuV5LduH5lGQxsS+/mcSXmdM3uqWYn35wrNO90owdc/TH+2lwn6txWTAeTNU7 eSRL8+KybXIqL/ZGiicAQQX/1KHlCFk4jtRLR+G8l/QZLTmXcwqqPaamdfKVZlZLD3L5xb0fxWj AjqTh/0FiTHl6TlPZlBYrWCGmrEf/fPF5xwPbmOcAIiZoyp2pEYe/yK2JwAYtBvybisHyr0yIp0 lcpdQ2BtUFXLDq9nxM/YGJgQr7eKOqa/nIMZqouOg6SMc25rfm5M+QuliaeInDZ6CuiNSMwoEm3 Th0RTRxAJkceEM2SGHnVwl6Anla16z/EFa9rpLrNxQ9gI7GloWcgJRTC5Q3Dgjn50RTRVnuoW98 O6bCk= X-Received: by 2002:a05:6102:1242:b0:62f:46c:40bb with SMTP id ada2fe7eead31-63a402a0379mr383764137.5.1778836231749; Fri, 15 May 2026 02:10:31 -0700 (PDT) X-Received: by 2002:a05:6102:1242:b0:62f:46c:40bb with SMTP id ada2fe7eead31-63a402a0379mr383755137.5.1778836231245; Fri, 15 May 2026 02:10:31 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4c23feasm200169966b.14.2026.05.15.02.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 02:10:30 -0700 (PDT) Message-ID: <934d6876-3c83-43de-b155-d435af4c3547@oss.qualcomm.com> Date: Fri, 15 May 2026 11:10:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: eliza: Add QUPv3, GPI DMA, SDHCI and LLCC nodes To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260513-eliza-dts-fix-debug-uart-and-more-support-v1-0-05814d24f4cf@oss.qualcomm.com> <20260513-eliza-dts-fix-debug-uart-and-more-support-v1-2-05814d24f4cf@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260513-eliza-dts-fix-debug-uart-and-more-support-v1-2-05814d24f4cf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wUQ9RdKQJzYgzV4oBnpY207uYeik0ZSr X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a06e308 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=olRgGBVlyjl6rEf_PyYA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA5MSBTYWx0ZWRfX5cr5dGU+kGHt UkF25F/UsiG5iDaoCNlvizwUSX8OkXumaLW7J/mSG1mgiNpKO/HLnA4eEOtZH2oPDbblKEbG/3h sCShwbwbpjTKElEqMIVqpqdWww6YP7SlG5plMsvRRqa8QIwN0PcZ6kqxOzv9x5CUz/Z6jmtCFv+ BepnhMQtDoVLqSjCbkUHfUp1M48YRCFvVqNV5iqDUSClE7iHz8j920OSHEx/72Pa7bxKXlAdiT0 MbhZElSRbYLv0LqaqxDw6mZeyQPxowJKz6xwZ32DT1XpCxGluYRNqY9GqDIzRU2IQOdKiEKOf67 hZwCgU50kQQOyxl1DlPd/jVIlPcOdcarPo0/AiqFhajlpxROnzoCouM9IGvEi7q8pDrSZgIbSb2 0ZmAc0T1bRPIqgTVnUd8nDb0mb3qYmbjpq1KRYDQbmzr7zLrxZv6xOuzBse/+rImfzEUO0utMhg w1bTMptUity7CBFMoFA== X-Proofpoint-ORIG-GUID: wUQ9RdKQJzYgzV4oBnpY207uYeik0ZSr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150091 On 5/13/26 2:33 PM, Abel Vesa wrote: > Describe the missing Eliza SoC nodes for the QUPv3 WRAP1 and WRAP2 serial > engines, add the matching GPI DMA controllers, the SDHCI controllers and > the LLCC system cache controller. > > Also add the TLMM pinctrl states for the QUPv3 serial engines and the > SD card/eMMC interfaces, plus OPP tables for the SDHCI controllers. > > Signed-off-by: Abel Vesa > --- [...] > + gpi_dma1: dma-controller@a00000 { > + compatible = "qcom,eliza-gpi-dma", "qcom,sm6350-gpi-dma"; > + reg = <0x0 0x00a00000 0x0 0x60000>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + dma-channels = <12>; > + dma-channel-mask = <0x3f>; > + #dma-cells = <3>; > + > + iommus = <&apps_smmu 0xb6 0x0>; > + dma-coherent; > + > + status = "disabled"; Let's keep the GPIs enabled [...] > + sdhc_1: mmc@f44000 { > + compatible = "qcom,eliza-sdhci", "qcom,sdhci-msm-v5"; > + reg = <0x0 0x00f44000 0x0 0x1000>, > + <0x0 0x00f45000 0x0 0x1000>, > + <0x0 0x00f48000 0x0 0x8000>; > + reg-names = "hc", > + "cqhci", > + "ice"; This should be a separate node > + > + interrupts = , > + ; > + interrupt-names = "hc_irq", > + "pwr_irq"; > + > + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > + <&gcc GCC_SDCC1_APPS_CLK>, > + <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "iface", > + "core", > + "xo"; > + > + interconnects = <&aggre2_noc MASTER_SDCC_1 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_SDCC_1 QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "sdhc-ddr", > + "cpu-sdhc"; > + > + power-domains = <&rpmhpd RPMHPD_CX>; > + operating-points-v2 = <&sdhc1_opp_table>; > + > + qcom,dll-config = <0x000f44ec>; > + qcom,ddr-config = <0x80040868>; > + > + iommus = <&apps_smmu 0x520 0x0>; > + dma-coherent; > + > + bus-width = <4>; That's definitely 8 > + max-sd-hs-hz = <37500000>; This should be fixed in Eliza [...] > + max-sd-hs-hz = <37500000>; ditto for sdcc2 > + > + resets = <&gcc GCC_SDCC2_BCR>; > + > + status = "disabled"; > + > + sdhc2_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-100000000 { > + opp-hz = /bits/ 64 <100000000>; The clock plan says 100, but the SDC doc says 50. What does downstream set here? Konrad