From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB0C5C433DF for ; Tue, 2 Jun 2020 13:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CB4B206A2 for ; Tue, 2 Jun 2020 13:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727813AbgFBNof (ORCPT ); Tue, 2 Jun 2020 09:44:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:24956 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbgFBNoe (ORCPT ); Tue, 2 Jun 2020 09:44:34 -0400 IronPort-SDR: W7vQptyI5pLIqXoMqjCflOS7OTXa0wSLH9Msvd91c+2uS8fEYscqW3LTEDmOvDIRHrKmccpskS L0urDQRnymZw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 06:44:34 -0700 IronPort-SDR: 1hLlep6tcToeKjR8jx1vzpz2MQV4f9AqvBcce0HhaQb5ZJ77PNJgxxNEIep+8MOMP+XFnEb0xJ Ok8nJIQV+IcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,464,1583222400"; d="scan'208";a="444697984" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.157]) ([10.237.72.157]) by orsmga005.jf.intel.com with ESMTP; 02 Jun 2020 06:44:31 -0700 Subject: Re: [PATCH v5 13/13] perf record: introduce --ctl-fd[-ack] options To: Alexey Budankov , Andi Kleen Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel References: <8ffc9f9f-af58-deea-428b-f8a69004e3cb@linux.intel.com> <923c40c7-7c0b-9fad-314d-69e7acbee201@intel.com> <937c8cc1-b4c2-8531-3fa4-d0ad9df6a65f@linux.intel.com> <20200601233732.GA691017@tassilo.jf.intel.com> <1bc7c72b-9d78-5184-a27c-8025beadaaf0@linux.intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <935187e8-6fc8-5f47-b88d-6e8c92a27286@intel.com> Date: Tue, 2 Jun 2020 16:43:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/06/20 12:12 pm, Alexey Budankov wrote: > > On 02.06.2020 11:32, Alexey Budankov wrote: >> >> On 02.06.2020 2:37, Andi Kleen wrote: >>>>> or a pathname, or including also the event default of "disabled". >>>> >>>> For my cases conversion of pathnames into open fds belongs to external >>>> controlling process e.g. like in the examples provided in the patch set. >>>> Not sure about "event default of 'disabled'" >>> >>> It would be nicer for manual use cases if perf supported the path names >>> directly like in Adrian's example, not needing a complex wrapper script. >> >> fds interface is required for VTune integration since VTune wants control >> over files creation aside of Perf tool process. The script demonstrates >> just one possible use case. >> >> Control files could easily be implemented on top of fds making open operations >> for paths and then initializing fds. Interface below is vague and with explicit >> options like below it could be more explicit: >> --ctl-file /tmp/my-perf.fifo --ctl-file-ack /tmp/my-perf-ack.fifo > > Or even clearer: > > --ctl-fifo /tmp/my-perf --ctl-fifo-ack /tmp/my-perf-ack If people are OK with having so many options, then that is fine by me. > >> >> Make either fds and or files provided on the command line. Implement file >> options handling callbacks that would open paths and setting fds. Close fds >> if they were opened by Perf tool process. >> >> Adrian, please share your mind and use case. >> >> ~Alexey >> >>> >>> -Andi >>>> >>>>> >>>>> e.g. add "--control" and support all of: >>>>> >>>>> --control >>>>> --control 11 >>>>> --control 11,15 >>>>> --control 11,15,disabled >>>>> --control 11,,disabled >>>>> --control /tmp/my-perf.fifo >>>>> --control /tmp/my-perf.fifo,/tmp/my-perf-ack.fifo >>>>> --control /tmp/my-perf.fifo,/tmp/my-perf-ack.fifo,disabled >>>>> --control /tmp/my-perf.fifo,,disabled >>>>> >>>>> Regards >>>>> Adrian >>>>> >>>> >>>> Regards, >>>> Alexey >>>>