From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 270F31FDE37 for ; Fri, 17 Jan 2025 12:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737117669; cv=fail; b=DKtBTVdkxnalTqM0jKutKW9ifa9VIEdKucTtLH5WDTgoGI4moKzIHJvzBwfemMPJBFgSbuPwn9BE1b/gpS252csIJF81O/KqcakhQ0NhZWKw/tj/mfecbRTVSvv3mMsijTbqfeurxeCgxxnTRKn5h5UTlBI0LGXX2Z2lotvZ/Lw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737117669; c=relaxed/simple; bh=cNqb1Hx8dABFc3qTszC4Od1P4W+RrMyDbWVYogCKD58=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=BlwD9VVVewH2V0vMCMx4iQ+amDzsonYbdjXxMxudgMyxMFpdsE7dCBnROcOKg6lsNTcY+h+2gC/2c2qwCEnRjCMJ1in0ed4vJ0YBA9pMlJ85TYWbokOMKlaeorFMkDUWaSaNEdejisEftkFhel4S1VKg8ywNmcO9DaxXd1XOCIM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com; spf=pass smtp.mailfrom=axis.com; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b=U0fOD+5t; arc=fail smtp.client-ip=40.107.22.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=axis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=axis.com header.i=@axis.com header.b="U0fOD+5t" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sobf+bZDDix/xv2HjiRNE1z/Z1eaP6Tkxm+6qdAvjwRVp9ULvIZkcy1BIKPnt7IfKM3NR/8EZ8tMsL+3acDJo8bDUHG5TqM7VZ33Sni/1jpTeKs4DyTpVlN5cM4IrYgFJ5fzTWz4236WnsGRSlsQ6fbrERKPTtZMrJc3gNMaBmRMU+ksok2LsMa2AQuoX9vPHvT1bfXbhVDXdPvQA6qqt0aMH0ZtcjN+r/24ieth9g9Pmqg7RHCY2bL04hzieHrcbi5ZR2cNzT9oUVklvKBU1ZgCVJvwE8z5PcSegD7cpH/BXpxD1BEfbx+CX82Tfb+VjoaUZtzo6CB0uYKqhI8L0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NETehT5/3QoQvzqH6D6hdQRD0I2VRBIxIFAMY2bPkAQ=; b=g/cvPC464DLPXBAuFAtXzVDt8WOmjfLeqrA5kx4KCElIxqiF3PSqTopuZK91aNtTLWZ1fHBt8hUQ6MVSHBmBs8o5rzUkOQHE90CQNU+UIunLyFHYalfCRF4Z8Wk9RdmIthqzbSSlDkQdtScFtjl8W52AZyFSnfOpEiy7RTvimbEQ2NzAVFAScgCOW0yUek9CiXdYhYix/7SHKX7VEAceeJlOAQHPHplYPUDciSUIoKWHAREEJ3CCmBWpPOwqQwKXnJS/Hw0B0OzQeOz76tZtYyAUtAYLt6a0JP6gzJn3BHeECY+X1aL+RWBUREySuhV2QGIenuoPUyCf7bsOpE6wzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axis.com; dmarc=pass action=none header.from=axis.com; dkim=pass header.d=axis.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NETehT5/3QoQvzqH6D6hdQRD0I2VRBIxIFAMY2bPkAQ=; b=U0fOD+5tGtMxoQTmTc3gDNM9RoyygZ1cnAa7HLrLDN3i0wpZsmPyQrkNSP0o8zl9tG0/tcgBk9ZlNRzIeezUqaAuN38S7Mf5wGIsmJDbcplbIJJU9yu3dXLK5SaX3L8pbcj7mHFSIv64d9AaVIrmRK4HSIx+geZpR0NevzQtHuE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=axis.com; Received: from DB7PR02MB4106.eurprd02.prod.outlook.com (2603:10a6:10:4c::17) by VI1PR02MB6080.eurprd02.prod.outlook.com (2603:10a6:800:182::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Fri, 17 Jan 2025 12:41:02 +0000 Received: from DB7PR02MB4106.eurprd02.prod.outlook.com ([fe80::3ac7:5723:2364:3f50]) by DB7PR02MB4106.eurprd02.prod.outlook.com ([fe80::3ac7:5723:2364:3f50%4]) with mapi id 15.20.8335.017; Fri, 17 Jan 2025 12:41:02 +0000 Message-ID: <93530df2-f1c0-4eb0-9955-90856570deea@axis.com> Date: Fri, 17 Jan 2025 13:40:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org, kernel@axis.com References: <20250115-tps-fix-v1-1-2bd7b316409d@axis.com> Content-Language: en-US From: Jonas Andreasson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MM0P280CA0003.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:a::14) To DB7PR02MB4106.eurprd02.prod.outlook.com (2603:10a6:10:4c::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR02MB4106:EE_|VI1PR02MB6080:EE_ X-MS-Office365-Filtering-Correlation-Id: fde1efc7-9c57-4cbe-549f-08dd36f43251 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bXR1a3YwRmN4d2FXWjRoL1oxZnVrOUZJNm93cUNVaHFqanlISDFqWThXM3NG?= =?utf-8?B?NnB3bDFEemNXcDRvc0tKY21QaGVMQTFHclVVMTg4c2UzUENyempjRzVYbm15?= =?utf-8?B?Z3RlTVZKWUU2ejFwVCtuSzdMOGJSWDliNkhVV2Vwa3YrOE9pTkU0b3duRi9t?= =?utf-8?B?ZGNqNmc2R3hla1dla010K0JNL05XRDVGTHBpNjBlazFvQzlvV0RnSEFvcWxE?= =?utf-8?B?citSNVpNcDM4a2R3eXVzcnprVkp6Rjdpa1FIc1MyL1djdnZiQUtDeXhzV05O?= =?utf-8?B?T01BYXNTckpHdFQvSHhWQ2VuQm9DYnlwekQ5YVp2Y25HMk1yMFl6WVdFM09p?= =?utf-8?B?dmlwUm9kU29TbFI0dllrNzF6RExzSDNBUEEvY3BwVXE4RnVZNUxqc2RqTlJl?= =?utf-8?B?TWg3S2hwWVNjQzA3emNtb3ZpSUp4dWNycnlvWDRsM1psNkxFbnFpVjllSmxi?= =?utf-8?B?YWpxUkluRVBWTjB0WEc0ZWl4MzdsMHpiZmZTQ1VwakN1R0NyUjFxVDBETjdY?= =?utf-8?B?VFl4cStLMDZDb0ljRjNiUm9vUDMwV29ieDNRd0c2R2MzMk1tSUxieElsMytY?= =?utf-8?B?TGo1aTZRaVFZdVlQQzNYdTFwL3k1ZlVpSnJycEI1Y2EzMHpKLzgyYmFPZFhy?= =?utf-8?B?SlpCMld0SkREL2krdHNqUlJIeVBoUlA2bU9aRnZuN3ZLSlhRWm5hTTdjMzlO?= =?utf-8?B?aFhNbjd1R0F5VVdTSjhlUzd4QmFaT3ZRVll1ZTdxUWFOOFI0YndqeXMrdTl4?= =?utf-8?B?NWR3dTYrd0dxSzQ2bERLaU9iUllMTUIrbWNjNXNqRzRrOWpTS1hCMjFUMTZ0?= =?utf-8?B?dFVJTUdvaW50TTZDbVpnR1lnOFJoV04vRDdwWEJtcSsvMTkyRDVUSGN6WWht?= =?utf-8?B?UE1FRlYzM3RjVXVWTGFiQ1EyLzQ4UDhIYjFLVXNCclpoVTFjNDJPR3VWMWF0?= =?utf-8?B?S1VycnFGd21BRTlmc1p1RGZ5VGhzd0tsRUlob3BrcDlyMlB3WXZBekJoeWZU?= =?utf-8?B?SDdKNFdxbDlKc1kxYTR3dXM3QjlXbXVETVR5dUNkbTJHdUc4MElGUUUvcWNQ?= =?utf-8?B?N2lsRnVVN3VjRjRGL0pZNkcza1c0MllXZEdNcDRCaHppbC8xY0RjeG8rWklO?= =?utf-8?B?UlZkdDRGR0Frd1l6SEg1dEcvM2o5TE9iZVlxR3FaaE9DVGNZMUlydkZqUVVW?= =?utf-8?B?bHFnbU5UMVNKdnJpVGdnVVZOQWl5b2dPL1M5Z2xQeVBiYVJtWVJ1SU5odUtX?= =?utf-8?B?NGR5a1RWT0s3Y0ZuK1V1NkE0NkNldnM2YitZbTlJaWhHeTFJNnFiTUZ5MW83?= =?utf-8?B?Z0hOQlRtYmpyNGRmUVh5MFluRXd1eUtNVnBzRXJrSzkvcEY4SkpEMXRCelVz?= =?utf-8?B?dHFpVmg4bnZGR1Z5U0RDRnJWVEJkWnAwblNRMnlwRi9MeDR6SVhvWkdEUXZL?= =?utf-8?B?SVduNHR1WGpoeGVjK0RUTmpUMEdlay8xcEtHMy9VVkZQSXE3ZDBtWVFmM3Ba?= =?utf-8?B?MWFHbndMSHplcE01Mkp4V0dDTW1WUUphRHVkMlN0eXRaTTFraEFLeTVEWlpE?= =?utf-8?B?WGlkVDh6YmhrTDdwN0pUaWgrZEttNC9RZTRsZmtFMm8rQTY1bzVlRkl0NVZI?= =?utf-8?B?WmlHQzN5QVZuNHNyZG5pejArSWVKVTJIeXZkUEZmTEFyWGthWXZHS2pJUGJk?= =?utf-8?B?WTU1UVFlcS9aa0ozN0F5YXhVOGlHNnFIQnkzYTdMem5FRndNSk0vcVc0QlY0?= =?utf-8?B?SVlJVTRMeWJlN1IwcEhOaTU2Q2hvbVJQUUhJSm5NWEVLbTF4ajBzMUxlSmhL?= =?utf-8?B?Qy9vVlRRQ0RXNlMvUy8xcUNQNVAwL1IvV0ZXeVZmdXZVaHVFcnR4SkZsUmpz?= =?utf-8?Q?SGAd5DrRdFG9k?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR02MB4106.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2h4TEtna0Fqczl6ejNGMHcyQ2NYc3NkZEtIZVlGUEUyNmJSdnhHamhIQi9v?= =?utf-8?B?dzdUSk8xMGtiaFB5OHVPUWt3cjlUZVJGc3UwVTJ4WnZ4dlBuWnROMjhjTlVH?= =?utf-8?B?Z2pwazFRd2FHdUpuVldXc3dWRnZ6blZvMXY2cE5OVHhZSjhmV2RmajQ2VXRT?= =?utf-8?B?L0xFb1pGaTliTkNia0o5WlVaZ21UMWEzdFhZajdzTndrV3RZQ1ZhMU15UWps?= =?utf-8?B?TVhqcXBLbGZNNDdJQ2tYWVRkTEFCdG1IaGVkckk3VW40RFliYU9jOTcxa2Iy?= =?utf-8?B?QkNJZXJmcUpMd1k4Sm9CbmIwcnY3Sm5HU1JGV0JjOHlqbXErRGJDY3VmTFlo?= =?utf-8?B?RTNvdVhtNEZsVElyajUrajVIVjBXNzQ2dThsWkJIM0dZVCtTR3FRaWZRVThO?= =?utf-8?B?d0l5Y3YzOHRUL01BZzVESGFUUU9SSVlYZzkvZ3hJUFY1Q1hzSGJjd3Z4N3JG?= =?utf-8?B?WGp0N1VkQ1NpcFhreWlaRDFncVdkY2x0NFQ5RU1ON0lHS1ZVWUtQSGU3dWZz?= =?utf-8?B?ZEFVak5ZWlc3c3V2eXdac3I2aGhmR2Rwb3plNTNTQVQyekltZ3YyRU5jbXNa?= =?utf-8?B?QkVOY0lrQUdTUmkwNTJpVVF6emZ5aWVoZW1Ma2JxR2hYbGlMaWV6NStsS3h3?= =?utf-8?B?RlNyT2p6WjVMOUhLWWtjT3pCbEhEaEF6SzdIYzRYRndPT0hnbU5DYkErNFMz?= =?utf-8?B?Vkh6UEkxdWN4ZUZrSGtkcmNqSW1SN0VmdTZkVzNqcGpaTnAwWWh4b1VvQkFC?= =?utf-8?B?eURhQmdDZVh5RkZHYldSRGVxRlkwWGxxcUpuTXI5ajhvSnAwOGkxRVJ6dlN4?= =?utf-8?B?aDlLaGRFekxnQ3l6OURUQnkxRzFuc2ZzYjFMcHh1OTBZNGxBa0Q0c3ZCcHR6?= =?utf-8?B?RnRIZ0FmV0JLa2NIZk5xOGtPWGdVWG0wTDVLVU14SXV3TUgxNWw2SnBEQkFi?= =?utf-8?B?SG40M05ZSVVnVkRJQTZQdzhzMExVTS82akVsbmRrZlg4aXRsYlo3OXV0bUk2?= =?utf-8?B?bXN1UTlrS2lxSjJmQ0xoQTFWS3BmNC9rcm1iTUZTMUpXQ1dXZlNWTXJuayty?= =?utf-8?B?NHpYY0FNY1VHd0pxQnVVMittTzgreTRPbnkyU0pNWW1WdnUwY24rMy9nUGZP?= =?utf-8?B?Y3VkR291bUJVM0hDSy9pbjBQWkNLSi9Ra3Frek13bXk2dmgxaEsycU9xQkFV?= =?utf-8?B?Nnl4RWE0TytTWmdHSkFheS9PZVZzclZLY1dYOFZpYTVhYXdNWkx6UlZ1VHp6?= =?utf-8?B?ampCS0ZwREZtdmNJK2M1T2N1anc1NFZRZExpQktiSlZFUCswZ0dEeUM4L0pG?= =?utf-8?B?bndyem50Vk91c2k1T0tRMnNDQnNSOGx4ZmYxOVZraGwxVDFVU3haZ1VQYTR6?= =?utf-8?B?SjgzbCtHVHF5YldoTGI3YytCcnJzQWNaV2dxQlNHNnlYMlhDdVFJWXlMcWMy?= =?utf-8?B?QXd6Sit4eWN6Si9UZGsxcy9zVGlWUjhBREp6NDFOU1J2SkE2YXNuNnkxei9I?= =?utf-8?B?Z25GOEVRb0c1TDg1M0lSTjhnWDh0NWEzVTU2T1JSaDlrQTJheVlBU29kNHRW?= =?utf-8?B?b0w2Z1ZCUFFSb2JVMFNuUUh0T0RBaUtYNmJGZTNBTXA2Q1pjMmg1QjhqV05C?= =?utf-8?B?Y0Z0VU1mMS9ja2sraURWZ2lpNGo0a3BMTTVrMkwyYnFKZVRwRmtYSzM2OGVJ?= =?utf-8?B?S2JBek4vZ2lmWDFNYjdVTjFGU2gwa3dyRVJRZ0Zub1NEVUc5UGxHbmNmR1E4?= =?utf-8?B?OEU2VjVRU0w5WDVzbUJUZ0g0Z2lZK213dFY3YUJMVTVqL3gydjA1L2ErNUVG?= =?utf-8?B?dGZDMDZQRUE4TFl6b0Z0TFB5dEl4Y24zSWFmRVZvejgzb1Z6Z25wNlEzSmE0?= =?utf-8?B?VDdNVzdka2VOUDVNUzBTTE5MQ05SUGplNEtVU0U1T2RrTGNMcElaeVpOK3R1?= =?utf-8?B?T0Q4UjJGS21vZ1F2KzBtT1lTSjZobnhuekRHak4vU2V2cmhsamdkc2lFdXMy?= =?utf-8?B?Q0Vwc0pCZlFqb01KR3hsWGlLaExQbWdZVXRxRlN2clVCdHZhWFRTOHg3T0NI?= =?utf-8?B?RnJKa240UjhiQ3RzaW42VEY3SkNJVEtldm1XVTAvUFlMdGtweTNBN24wampD?= =?utf-8?Q?RIFc=3D?= X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-Network-Message-Id: fde1efc7-9c57-4cbe-549f-08dd36f43251 X-MS-Exchange-CrossTenant-AuthSource: DB7PR02MB4106.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 12:41:02.2652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QAj0uZM3QAjC4BPyVM5gzmQDmcZJXPXcGxx5+r5KLi6wBMF3ASE5othfDdTIM3bI X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB6080 On 1/16/25 16:58, Mark Brown wrote: > On Wed, Jan 15, 2025 at 10:55:22AM +0100, Jonas Andreasson wrote: > >> + if (!data || data->range == -1) >> + goto fallback; > > ... > >> + return selector; >> + >> +fallback: >> + return regulator_map_voltage_pickable_linear_range(rdev, min_uV, max_uV); > > You could just have the return statement directly and avoid the goto > which would make this easier to follow. Hello. Thanks for looking at my code! That is a good point which I will fix. Kind Regards, Jonas