From: "Csókás Bence" <csokas.bence@prolan.hu>
To: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] dma: Add devm_dma_request_chan()
Date: Mon, 3 Feb 2025 14:09:54 +0100 [thread overview]
Message-ID: <9354a990-b4ef-4ca1-8666-6c5905eaf86d@prolan.hu> (raw)
In-Reply-To: <20250203-chalice-ninth-8235590e29d2@thorsis.com>
Hi,
On 2025. 02. 03. 13:27, Alexander Dahl wrote:
>> + if (!IS_ERR(chan))
>> + ret = devm_add_action_or_reset(dev, dmaenginem_release_channel, chan);
>
> Why not using dma_release_channel() directly here? What's the point
> of introducing dmaenginem_release_channel() further above?
I followed the existing practice, used by
`dmaenginem_async_device_unregister()`. I suspect it was done like this
because the devm callback function's signature takes a `void *` and not
`struct dma_chan *`.
Bence
next prev parent reply other threads:[~2025-02-03 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250124085221.766303-4-csokas.bence@prolan.hu>
2025-01-24 8:52 ` Bence Csókás
2025-02-03 12:27 ` Alexander Dahl
2025-02-03 13:09 ` Csókás Bence [this message]
2025-01-24 8:52 ` [PATCH v2 2/4] pm: runtime: Add new devm functions Bence Csókás
2025-01-24 8:52 ` [PATCH v2 3/4] spi: atmel-quadspi: Use `devm_dma_request_chan()` Bence Csókás
2025-01-24 8:52 ` [PATCH v2 4/4] spi: atmel-quadspi: Fix unbalanced pm_runtime by using devm_ API Bence Csókás
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9354a990-b4ef-4ca1-8666-6c5905eaf86d@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®