From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, msbarth@linux.vnet.ibm.com,
tpearson@raptorengineering.com, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v3] hwmon: Add support for MAX31785 intelligent fan controller
Date: Thu, 8 Jun 2017 05:37:06 -0700 [thread overview]
Message-ID: <9358484b-ceb2-6fe4-deef-54372a3f12da@roeck-us.net> (raw)
In-Reply-To: <1496908393.23335.3.camel@aj.id.au>
On 06/08/2017 12:53 AM, Andrew Jeffery wrote:
> On Wed, 2017-06-07 at 08:55 -0700, Guenter Roeck wrote:
>> On Tue, Jun 06, 2017 at 04:32:30PM +0930, Andrew Jeffery wrote:
>>> Add a basic driver for the MAX31785, focusing on the fan control
>>> features but ignoring the temperature and voltage monitoring
>>> features of the device.
>>>
>>> This driver supports all fan control modes and tachometer / PWM
>>> readback where applicable.
>>>
>>>>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
>>>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>>> ---
>>> Hello,
>>>
>>> This is a rework of Timothy Pearson's original patch:
>>>
>>> https://www.mail-archive.com/linux-hwmon@vger.kernel.org/msg00868.html
>>>
>>> I've labelled it as v3 to differentiate from Timothy's postings.
>>>
>>> The original thread had some discussion about the MAX31785 being a PMBus device
>>> and that it should thus be a PMBus driver. The implementation still makes use
>>
>> After thinking about it, that is what it should be. If I accept it as non-PMBus
>> driver, it will be all but impossible to convert it to a PMBus driver later on,
>> and that just doesn't make any sense.
>
> Hopefully not being too ignorant here, but can you expand on why it
> would be all but impossible to convert?
>
I've got a lot of noise recently just for converting a driver from the old to the
new API (which changes the attribute location). Changing the driver from non-PMBus
to PMBus would very quite likely change some attributes as well.
Besides that, I think it is a bad idea to bypass an infrastructure just because
it may require a few tweaks. That generates a bad precedent, and people _would_
use that to argue that the next PMBus chip driver should not use the infrastructure
either.
Guenter
>>
>> With no one interested in writing that driver, I'll try to give it some more
>> priority myself. I do have an evaluation board somewhere, which should help.
>>
>> Note that the second fan reading should be implemented as just that, not with
>> a non-standard attribute.
>
> Agreed.
>
> Andrew
>
next prev parent reply other threads:[~2017-06-08 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 7:02 Andrew Jeffery
2017-06-06 13:33 ` Guenter Roeck
2017-06-06 16:20 ` Matthew Barth
2017-06-07 2:48 ` Joel Stanley
2017-06-07 6:45 ` Andrew Jeffery
2017-06-07 17:37 ` Guenter Roeck
2017-06-08 6:27 ` Andrew Jeffery
2017-06-07 7:15 ` Andrew Jeffery
2017-06-07 0:45 ` kbuild test robot
2017-06-07 15:55 ` Guenter Roeck
2017-06-08 7:53 ` Andrew Jeffery
2017-06-08 12:37 ` Guenter Roeck [this message]
2017-06-09 0:52 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9358484b-ceb2-6fe4-deef-54372a3f12da@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msbarth@linux.vnet.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®