mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Jens Axboe <axboe@kernel.dk>,
	Kentaro Takeda <takedakn@nttdata.co.jp>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-security-module@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tomoyo: don't special case PF_IO_WORKER for PF_KTHREAD
Date: Fri, 26 Mar 2021 09:03:31 -0700	[thread overview]
Message-ID: <935b000c-77df-fa88-6e2e-daffc256a11e@schaufler-ca.com> (raw)
In-Reply-To: <46f6e3cb-cc96-d214-e183-71dd238da075@kernel.dk>

On 3/25/2021 5:44 PM, Jens Axboe wrote:
> The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no
> need to special case them for credential checks.

Could you cite the commit where that change was made?

>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
>  security/tomoyo/network.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/tomoyo/network.c b/security/tomoyo/network.c
> index 478f757ff843..8dc61335f65e 100644
> --- a/security/tomoyo/network.c
> +++ b/security/tomoyo/network.c
> @@ -613,7 +613,7 @@ static int tomoyo_check_unix_address(struct sockaddr *addr,
>  static bool tomoyo_kernel_service(void)
>  {
>  	/* Nothing to do if I am a kernel service. */
> -	return (current->flags & (PF_KTHREAD | PF_IO_WORKER)) == PF_KTHREAD;
> +	return current->flags & PF_KTHREAD;
>  }
>  
>  /**

  reply	other threads:[~2021-03-26 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  0:44 Jens Axboe
2021-03-26 16:03 ` Casey Schaufler [this message]
2021-03-26 16:05   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=935b000c-77df-fa88-6e2e-daffc256a11e@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=takedakn@nttdata.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®