From: <Arun.Ramadoss@microchip.com>
To: <o.rempel@pengutronix.de>, <kuba@kernel.org>, <andrew@lunn.ch>
Cc: <kernel@pengutronix.de>, <olteanv@gmail.com>,
<davem@davemloft.net>, <Woojung.Huh@microchip.com>,
<linux-kernel@vger.kernel.org>, <pabeni@redhat.com>,
<f.fainelli@gmail.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net v2 1/1] net: dsa: microchip: make sure drive strength configuration is not lost by soft reset
Date: Wed, 6 Mar 2024 03:29:32 +0000 [thread overview]
Message-ID: <935b7bd6fe116291ff5f1f5a7a52cdad89e4607a.camel@microchip.com> (raw)
In-Reply-To: <20240305191457.37419bd4@kernel.org>
Hi Jakub,
On Tue, 2024-03-05 at 19:14 -0800, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Tue, 5 Mar 2024 07:48:02 +0100 Oleksij Rempel wrote:
> > This driver has two separate reset sequence in different places:
> > - gpio/HW reset on start of ksz_switch_register()
> > - SW reset on start of ksz_setup()
> >
> > The second one will overwrite drive strength configuration made in
> > the
> > ksz_switch_register().
> >
> > To fix it, move ksz_parse_drive_strength() from
> > ksz_switch_register() to
> > ksz_setup().
> >
> > Fixes: d67d7247f641 ("net: dsa: microchip: Add drive strength
> > configuration")
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> Hm, this is much larger than I anticipated, and also doesn't apply,
> so there will be conflict with -next. Andrew, should we go back to
> the v1?
Suggestion: Instead of moving ksz_parse_drive_strength() from end of
file to above, can we move ksz_setup() & ksz_teardown() down. So that
the changes will be minimal. Will that work?
next prev parent reply other threads:[~2024-03-06 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 6:48 Oleksij Rempel
2024-03-05 8:03 ` Arun.Ramadoss
2024-03-06 3:14 ` Jakub Kicinski
2024-03-06 3:29 ` Arun.Ramadoss [this message]
2024-03-06 6:03 ` Oleksij Rempel
2024-03-07 9:03 ` Oleksij Rempel
2024-03-07 17:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=935b7bd6fe116291ff5f1f5a7a52cdad89e4607a.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome