From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757749AbcHYKjU (ORCPT ); Thu, 25 Aug 2016 06:39:20 -0400 Received: from www381.your-server.de ([78.46.137.84]:42058 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbcHYKjS (ORCPT ); Thu, 25 Aug 2016 06:39:18 -0400 Subject: Re: [PATCH 2/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit To: Zach Brown , adrian.hunter@intel.com References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <1472080984-17373-2-git-send-email-zach.brown@ni.com> Cc: robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-arm-kernel@lists.infradead.org From: Lars-Peter Clausen X-Enigmail-Draft-Status: N1110 Message-ID: <935c7618-a403-775b-b45c-c3b97e0ed252@metafoo.de> Date: Thu, 25 Aug 2016 12:37:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1472080984-17373-2-git-send-email-zach.brown@ni.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25/2016 01:23 AM, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the cd bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the cd bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function with out the cd bit. > > The device property "fake-cd" will let the arasan driver know it needs > to fake the cd bit for the controller inorder for the controller to > function with a SD card that does not provide the CD bit. The devicetree is supposed to be descriptive rather than imperative. fake-cd is a bit more on the later side. There is already a standard property for describing that the card-detect pin is not connected, called 'broken-cd'. Can that be used instead?