From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31B2C433F5 for ; Fri, 27 May 2022 13:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352281AbiE0Ngo (ORCPT ); Fri, 27 May 2022 09:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235855AbiE0Ngl (ORCPT ); Fri, 27 May 2022 09:36:41 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32F35C378; Fri, 27 May 2022 06:36:37 -0700 (PDT) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24RDNkix007065; Fri, 27 May 2022 13:36:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : reply-to : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UvFfAb7XzrtbZWcakjYDQFR097d/QQ6h3USU5tf9mOU=; b=Dgepv199RVUJ5xaCICOhCfrCKHv6E+cWaiobNYIRVwwIUgQ8FRvTr5ur8M4q7kKRF7S3 hQmREqzcTV+aBs/Cp1ZrlD34l1nNWzdmlxPDjflZrZJDFFX2jNwO40arVXC+Rojls6C3 89mSdxY///C8T10LYEP4gBNoPnE2ZSCTn0eMt7IiVxiuxYN7a6NDjf1Tc8k3rHKS98S7 tjpcIi8nTm8mAYrILujes+mJhrEcRi381vJUS1ig7Ms58nLvUP3sPh/e7VK7Cn4O5t7B h5ojqQREfZpaIzwwwn5Z+mb2VxYUJEEfRMSaV6I4Myw8uDf+yPrgxAFHeSWez91ZmA0q Vw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gayg807ty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 May 2022 13:36:34 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24RDUW4L002489; Fri, 27 May 2022 13:36:33 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gayg807tp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 May 2022 13:36:33 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24RDYWhL013836; Fri, 27 May 2022 13:36:33 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03wdc.us.ibm.com with ESMTP id 3gabgmf0d4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 May 2022 13:36:33 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24RDaWPQ39387498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 May 2022 13:36:32 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F91F28058; Fri, 27 May 2022 13:36:32 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2EDE828065; Fri, 27 May 2022 13:36:32 +0000 (GMT) Received: from [9.60.75.219] (unknown [9.60.75.219]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 27 May 2022 13:36:32 +0000 (GMT) Message-ID: <9364a1b7-9060-20aa-b0d6-88c41a30e7d4@linux.ibm.com> Date: Fri, 27 May 2022 09:36:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Reply-To: jjherne@linux.ibm.com Subject: Re: [PATCH v19 11/20] s390/vfio-ap: prepare for dynamic update of guest's APCB on queue probe/remove Content-Language: en-US To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com, pasic@linux.ibm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, fiuczy@linux.ibm.com References: <20220404221039.1272245-1-akrowiak@linux.ibm.com> <20220404221039.1272245-12-akrowiak@linux.ibm.com> From: "Jason J. Herne" Organization: IBM In-Reply-To: <20220404221039.1272245-12-akrowiak@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: xRlckxqCRc19NbXDI99X_qHWEu4qeofs X-Proofpoint-ORIG-GUID: bBkFK8XaS7mL1iDBCEYFcvvYWPergox1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-27_03,2022-05-27_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205270063 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/22 18:10, Tony Krowiak wrote: > The callback functions for probing and removing a queue device must take > and release the locks required to perform a dynamic update of a guest's > APCB in the proper order. > > The proper order for taking the locks is: > > matrix_dev->guests_lock => kvm->lock => matrix_dev->mdevs_lock > > The proper order for releasing the locks is: > > matrix_dev->mdevs_lock => kvm->lock => matrix_dev->guests_lock > > A new helper function is introduced to be used by the probe callback to > acquire the required locks. Since the probe callback only has > access to a queue device when it is called, the helper function will find > the ap_matrix_mdev object to which the queue device's APQN is assigned and > return it so the KVM guest to which the mdev is attached can be dynamically > updated. > > Note that in order to find the ap_matrix_mdev (matrix_mdev) object, it is > necessary to search the matrix_dev->mdev_list. This presents a > locking order dilemma because the matrix_dev->mdevs_lock can't be taken to > protect against changes to the list while searching for the matrix_mdev to > which a queue device's APQN is assigned. This is due to the fact that the > proper locking order requires that the matrix_dev->mdevs_lock be taken > after both the matrix_mdev->kvm->lock and the matrix_dev->mdevs_lock. > Consequently, the matrix_dev->guests_lock will be used to protect against > removal of a matrix_mdev object from the list while a queue device is > being probed. This necessitates changes to the mdev probe/remove > callback functions to take the matrix_dev->guests_lock prior to removing > a matrix_mdev object from the list. > > A new macro is also introduced to acquire the locks required to dynamically > update the guest's APCB in the proper order when a queue device is > removed. > > Signed-off-by: Tony Krowiak > --- > drivers/s390/crypto/vfio_ap_ops.c | 126 +++++++++++++++++++++--------- > 1 file changed, 88 insertions(+), 38 deletions(-) > > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index 2219b1069ceb..080a733f7cd2 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -116,6 +116,74 @@ static const struct vfio_device_ops vfio_ap_matrix_dev_ops; > mutex_unlock(&matrix_dev->guests_lock); \ > }) > > +/** > + * vfio_ap_mdev_get_update_locks_for_apqn: retrieve the matrix mdev to which an > + * APQN is assigned and acquire the > + * locks required to update the APCB of > + * the KVM guest to which the mdev is > + * attached. > + * > + * @apqn: the APQN of a queue device. > + * > + * The proper locking order is: > + * 1. matrix_dev->guests_lock: required to use the KVM pointer to update a KVM > + * guest's APCB. > + * 2. matrix_mdev->kvm->lock: required to update a guest's APCB > + * 3. matrix_dev->mdevs_lock: required to access data stored in a matrix_mdev > + * > + * Note: If @apqn is not assigned to a matrix_mdev, the matrix_mdev->kvm->lock > + * will not be taken. > + * > + * Return: the ap_matrix_mdev object to which @apqn is assigned or NULL if @apqn > + * is not assigned to an ap_matrix_mdev. > + */ > +static struct ap_matrix_mdev *vfio_ap_mdev_get_update_locks_for_apqn(int apqn) vfio_ap_mdev_get_update_locks_for_apqn is "crazy long". How about: get_mdev_for_apqn() This function is static and the terms mdev and apqn are specific enough that I don't think it needs to start with vfio_ap. And there is no need to state in the function name that locks are acquired. That point will be obvious to anyone reading the prologue or the code. Aside from that, Reviewed-by: Jason J. Herne -- -- Jason J. Herne (jjherne@linux.ibm.com)