From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 377B7C7EE2E for ; Mon, 5 Jun 2023 19:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235757AbjFETkZ (ORCPT ); Mon, 5 Jun 2023 15:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbjFETkX (ORCPT ); Mon, 5 Jun 2023 15:40:23 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 350B3AF for ; Mon, 5 Jun 2023 12:40:22 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-33bcc8f0d21so2434555ab.1 for ; Mon, 05 Jun 2023 12:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1685994021; x=1688586021; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pSCTHh0/+bNATByAsUgmwiP+hFeMNJkT6J92qlZVpFs=; b=dtAHvThcg4aNGSQ913U3mJcT51DfHlnPIomJIPoaOYJC7ydC/a08Yi/nkRlzyL/fDX 1qitrjr/BugM2dN/4FJe8AejRktG+yrcV8u6jm8GiynuSiVxsv5fwMyYqFG+QZFdm8f+ TxW8rnJKe6895GHa/gt96mubg1XpaqQ5nTF3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685994021; x=1688586021; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pSCTHh0/+bNATByAsUgmwiP+hFeMNJkT6J92qlZVpFs=; b=Ib267PTyYNkcFOvQQ7lmNCdzsOqbz/9nk+UxMLhhl+dEcomiJRWW77vRbSPVuf38ou cSKKYeGFMqVjhwP831srJyG09TmVz4wTGUDupEWuOrKs4K8OLlbT72C8guLDLeVLeqF9 W89SszRSOablHNC2yXqgJByWkuPezO1hLSQLdAJUgZmCTBXGjDFAZllMouC1V2mMu0fF VY7qiVNB/P7qg4nBFYcYo67IRa7nIdAIsiW75PvAj52kcAFudowxaapO/gadMilYxw2J P30cIu5J9bTcBWVIffwb87cNuYEPY2GZOk3/FbOOU0dKGpV5ot6IOt3ydPdu/NjYiehM 2h+w== X-Gm-Message-State: AC+VfDwnf4vLL3EPHgzEj4Sryy42XsuHDFxKw3dNrw8RUcyQnmX7xaB0 L1vU296BMcOVRlBfFxsQ9wemSA== X-Google-Smtp-Source: ACHHUZ4ALFEeOShyYs4ZR1D96r9L04QZMWgT8pY9pitWcfD/3Roa1gTw3zGYN6dsxwB4LDSQ1eT5Dg== X-Received: by 2002:a6b:8d8e:0:b0:777:a5a4:c6cb with SMTP id p136-20020a6b8d8e000000b00777a5a4c6cbmr117369iod.1.1685994021528; Mon, 05 Jun 2023 12:40:21 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id a5-20020a6b6c05000000b0075c37601b5csm2713016ioh.4.2023.06.05.12.40.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 12:40:21 -0700 (PDT) Message-ID: <93651468-daa2-1530-f94e-b66a4fd4bdf8@linuxfoundation.org> Date: Mon, 5 Jun 2023 13:40:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] kselftests: Sort the collections list to avoid duplicate tests Content-Language: en-US To: Rishabh Bhatnagar , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230601211112.12724-1-risbhat@amazon.com> From: Shuah Khan In-Reply-To: <20230601211112.12724-1-risbhat@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/23 15:11, Rishabh Bhatnagar wrote: > If the collections list is not sorted uniq doesn't weed out duplicate > tests correctly. Make sure to sort it before running uniq. > > Signed-off-by: Rishabh Bhatnagar > --- > tools/testing/selftests/run_kselftest.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/run_kselftest.sh b/tools/testing/selftests/run_kselftest.sh > index 97165a83df63..e0cb10c85169 100755 > --- a/tools/testing/selftests/run_kselftest.sh > +++ b/tools/testing/selftests/run_kselftest.sh > @@ -85,7 +85,7 @@ if [ -n "$TESTS" ]; then > available="$(echo "$valid" | sed -e 's/ /\n/g')" > fi > > -collections=$(echo "$available" | cut -d: -f1 | uniq) > +collections=$(echo "$available" | cut -d: -f1 | sort | uniq) > for collection in $collections ; do > [ -w /dev/kmsg ] && echo "kselftest: Running tests in $collection" >> /dev/kmsg > tests=$(echo "$available" | grep "^$collection:" | cut -d: -f2) Applied to linux-kselftest next for Linux 6.5-rc1. thanks, -- Shuah