mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jori Koolstra <jkoolstra@xs4all.nl>
To: "Shuah Khan" <skhan@linuxfoundation.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"David Ahern" <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Hangbin Liu" <hangbin.liu@linux.dev>,
	"Ricardo B. Marlière" <ricardo@marliere.net>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] selftests: add option to print the time spent per test
Date: Fri, 20 Nov 2026 12:27:24 +0100 (CET)	[thread overview]
Message-ID: <936710069.2100225.1795174044091@kpc.webmail.kpnmail.nl> (raw)
In-Reply-To: <13c6ec9c-c4ea-4471-b5e8-77d1a786796b@linuxfoundation.org>


> Op 18-11-2026 11:15 EST schreef Shuah Khan <skhan@linuxfoundation.org>:
> 
>  
> On 11/18/26 06:40, Jori Koolstra (CIQ) wrote:
> > For CI/CD purposes it is useful to know how much time each selftest
> > took to complete, for instance, to know which suites to run for a
> > quick-fail diagnostic, or what percentage of tests you can expect to
> > complete on a paricular --override-timeout value.
> > 
> > Add a -T/--timed option to run_kselftest.sh. When it is set, run_one()
> > prints a KTAP diagnostic line with the elapsed wall-clock time just
> > before the result line of each test that is actually run, e.g.:
> > 
> >        # selftests: timers: nanosleep
> >        # time: 12.34s
> >        ok 3 selftests: timers: nanosleep
> > 
> > The other two patches clean up the use of 'local' in runner.sh and fix a
> > bug when using --netns in run_kselftest.sh. Strictly these could be sent
> > as separate patches, but "selftests: add option to print the time spent
> > per test" builds on these, and it would otherwise require needless
> > rebasing for two small fixes.
> > 
> > Signed-off-by: Jori Koolstra (CIQ) <jkoolstra@xs4all.nl>
> > ---
> > Jori Koolstra (CIQ) (3):
> >        selftests: use local variables consistently in runner.sh
> 
> Please spilt the convention related changes and real changes.
> 

Do you want me to send it separately or drop it altogether? It isn't really
important really, just a clean up. I have some more changes submitted a
couple days ago that I'd like review more than this.

> >        selftests: pass the timeout override to tests run in a netns
> >        selftests: add option to print the time spent per test
> 
> These two look good to me. I will pull them all as a series once you
> fix the problem with patch 1/3
> 

Just sent the v2. Thanks for the review.

> > 
> >   tools/testing/selftests/kselftest/runner.sh | 50 ++++++++++++++++++++++-------
> >   tools/testing/selftests/run_kselftest.sh    |  8 +++++
> >   2 files changed, 47 insertions(+), 11 deletions(-)
> > ---
> > base-commit: 666539eecdf4db623f5e3c3e55cf9f2dfad24aa4
> > change-id: 20261117-kselftest-run-timer-df3ac531652e
> > 
> > Best regards,
> 
> thanks,
> -- Shuah

Best,
Jori.

      reply	other threads:[~2026-11-20 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:40 Jori Koolstra (CIQ)
2026-11-18 13:40 ` [PATCH 1/3] selftests: use local variables consistently in runner.sh Jori Koolstra (CIQ)
2026-11-18 16:13   ` Shuah Khan
2026-11-20 11:14     ` Jori Koolstra
2026-11-18 13:40 ` [PATCH 2/3] selftests: pass the timeout override to tests run in a netns Jori Koolstra (CIQ)
2026-11-18 13:40 ` [PATCH 3/3] selftests: add option to print the time spent per test Jori Koolstra (CIQ)
2026-11-18 16:15 ` [PATCH 0/3] " Shuah Khan
2026-11-20 11:27   ` Jori Koolstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=936710069.2100225.1795174044091@kpc.webmail.kpnmail.nl \
    --to=jkoolstra@xs4all.nl \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=hangbin.liu@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ricardo@marliere.net \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®