From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EAA92F25EB for ; Tue, 28 Oct 2025 10:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761647056; cv=none; b=WVd8Xd9iJWyCLh6rVMVjiAJN5+8YfsPNwtGQEJGLGyH9HaX6Qbxq9m+ITo5SYIVJ1p/nMYH9308f5LwoVBcd7ZS6uThtJ6tP2V9ZWUmMhlLZw8jEmnnt2TQYhZRQ70JxHsBVonBTO3DykXrZ++qldnbBBatfANLYL+Tvhhpwv+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761647056; c=relaxed/simple; bh=EL5sc4Geev4x+fvpuOCTZdXy/2d70RTa1mtpThD3oD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lj3g9BlQE2XIltn4Olt3pe7An79FNYri7U7oaPzanl9bJtNpec2ImhqYQo1dCyHOHWge+lcLjDksQDynel2BYvBD20fEMIhzCtjM0uhfmYxVa+8gqHiMgzSQyb25mXno5KmTQcuqIoLTfIsU/4j/FQttnJSW3qBp4WRLedTpZCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ojAk/8oc; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ojAk/8oc" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3f0ae439bc3so3672810f8f.1 for ; Tue, 28 Oct 2025 03:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761647052; x=1762251852; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2VJok45Nt3q/TDUcEtsKTirjSQJi6dBAwOmqzr+WbBo=; b=ojAk/8ocervYZa/5GvWAdV139epv9rlShWhHNY7KSMf5Y00ocoerYMtLqJRsmgs++q M1LCbCoU7uvJNJ/ekZ9gWUnqIOU1n0AtLvFfTvZxWv4UfS70fL2h+OU0lO7IZzFrqiQ4 GEaQlBCqeUSP9BtLKzDyekw/8sEIhdSGv582TJKE7eyUXfjdKHdCUy4vMvHWxe5VQJcC 7DLxW8hgO9GE2jRg366JS6xtNHH0iiUPnDuBL0ppqQoSwMIZm25gopP7eQ/ipDwYZM9t BOrCFvfx+0hmDXT4MT6MFtJSNKAVt/m5FMXXxmIxXfkNhzuZ2MMhA1JvVyEUT6BX/hqs kYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761647052; x=1762251852; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2VJok45Nt3q/TDUcEtsKTirjSQJi6dBAwOmqzr+WbBo=; b=vSEYuM52Ttir1zeMh2BeQnh0uP2wtTwLl0C6QOdiBcOv2dtzJgbsuN+m1m6qbBraYe Zg06vwauJOnaSuW23F358ZnE9g9CAhFzr2Iryynop5LB+3S09pJEWAMBzYbWXbGAMuzd Z/KqFm7Q1i1MA5uPzTBwpPMrLW0qyp9EKk0CCd/woifi8GYwJ0/3o/bMUvG2dvmEIsBi iv/mhQqlhn29FQ0bXoMI3MohMyhcS19D3KdYQnjBqjjHJFFegzaxaR9aCt3T0wxYn91b S+K3kBhSuuaKeQhSuuvYHfmpX9RGyFREH7wtNZlRswU9Vo2NNywRzGgA+4m0HGOT3y73 fhAg== X-Forwarded-Encrypted: i=1; AJvYcCXGb53sQkgjNwumbudRFin3u6RXfhXL9H19WMSjMSYVTeEzyTVbPf+tcCpiC6fOb8oy5KNJvgGs5VUe0vw=@vger.kernel.org X-Gm-Message-State: AOJu0YzI5Ghpq4AGcoEQBhRkE2ATRqcDFGzKwUMYh2kPN2r0ziSG+SNd fX3jlXb85gPe1s1wM5fzF4UjzjncwIoiisiKpnWrcx9Az8sFRTu8iXx+XMMN+E2I7pA= X-Gm-Gg: ASbGncsiqZI4RCRipNmAesrnB8wmCPBpSm7ooKTqniVcLbahgrOoI+yF8d+41qv3w0d O+KAlbt9XleNroAxxECdaK4W6CUO+86fURluH/q1CL4774tgF79RYsTH9k2iNOAg32LximwII0e E43dPOWARLye3LcxxZ1oo2R54Oyb2A/ByAXSUrldqkDbGGPOdXeHrDd1PjGRaJL/K1ujDloFqiD f1YxE4D90jQY/iGDpEP4pWWrLofrFeIKwGuX9V37Db8SPkQs9uTG9NvdmVmtOsrtOYgW0ytpCFU v1PBjXXXMh0PLIydB9OVAsP5y3uXyIRFtv2RaMeltIxmBgTqy7NVdjnW8Oh6e7J8dUukvnbhkiE 3wvCFCNgTFMTWKL9Sj9PlCIana/gXB4IjOszCGnm50+M/RiC1gF4DXZj/8Jgt16MlbWBSeB7oUu qNqNVpPaFeIQa0DipsTtu/rWNsTgeUGJOeiOtM5aTA0BA= X-Google-Smtp-Source: AGHT+IEW6jnKStLoBQEjVC10xDA/sEUNafyP+ddUhg13U6lTe/41VGR5b+Ux9xIvwfx/4vyZeYspcA== X-Received: by 2002:a5d:5d05:0:b0:3ea:e0fd:290a with SMTP id ffacd0b85a97d-429a7e36d88mr2380269f8f.12.1761647052499; Tue, 28 Oct 2025 03:24:12 -0700 (PDT) Received: from [192.168.0.163] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952df62dsm21236416f8f.45.2025.10.28.03.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 03:24:12 -0700 (PDT) Message-ID: <936ecaf4-8b48-4c93-a666-153a13ee9e16@linaro.org> Date: Tue, 28 Oct 2025 10:24:10 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss To: Krzysztof Kozlowski , Luca Weiss Cc: Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251024-sm6350-camss-v1-0-63d626638add@fairphone.com> <20251024-sm6350-camss-v1-1-63d626638add@fairphone.com> <20251028-defiant-visionary-rottweiler-f97cda@kuoka> <0bf4ab2e-9846-4f8b-ad72-e9db6fb7d08e@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <0bf4ab2e-9846-4f8b-ad72-e9db6fb7d08e@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/10/2025 09:46, Krzysztof Kozlowski wrote: >>>> + power-domain-names: >>>> + items: >>>> + - const: ife0 >>>> + - const: ife1 >>>> + - const: ife2 >>>> + - const: top >>> Uh, not your fault, but who came with this list in previous generations? >>> Instead of simple and obvious "top+ifeX" which allows growing/shrinking, >>> someone put "top" at the end which means this cannot follow same order >>> as X1E for example... Heh, it follows at least sm8550. >> Shall we put top as first power-domain? I don't think it's an issue to >> change the order. > Well, it matches sm8550, so I am just grumpy complaining. It's fine. The provenance here is "top" was required to be added last because the code depended on magic indexing in dtb to know which was the TOP GDSC. But since power-domain names are now required, you can have any order you want. > >>> >>>> + >>>> + vdda-0.9-supply: >>> There are no dots in property names. Are you sure these are called >>> VDDA_0.9 in the device datasheet (not schematics)? Please look at other >>> bindings how this is being named, depending whether this is PHY or PLL >>> supply (or only PHY). >> The following power supplies are mentioned: >> >> * VDD_CAMSS_PLL_0P9 - Camera SS PLL 0.9 V circuits >> (not referenced in downstream kernel, connected to vreg_s5a in >> schematics) > So that's vdda-pll-supply > >> * VDD_A_CSI_x_0P9 - MIPI CSIx 0.9 V circuits >> With pad names VDD_A_CSI_0_0P9 to VDD_A_CSI_3_0P9 > vdd-csiphy-0p9-supply > >> * VDD_A_CSI_x_1P25 - MIPI CSIx 1.25 V circuits >> With pad names VDD_A_CSI_0_1P25 to VDD_A_CSI_3_1P25 > vdd-csiphy-1p25-supply @Luca VDD_A_CSI_X_0P9 VDD_A_CSI_X_1P25 Agree see this on schematics. and look indeed there it is VDD_CAMSS_PLL_0P9 but if you look at where that rail comes from its SM_VDD_MX So I believe the MX power-domain should cover this instead of having a new separate rail defined in CAMSS for this. --- bod