From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7648037B024 for ; Tue, 10 Mar 2026 09:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133834; cv=none; b=laqHq8xnfvXiluzMm96RTNKC7ccPIcksdRjmFjSP5LXddWnpXahQF/WG8Dbzp8G+oDmNztdn/p+j/pma6+XYxvx4nbqoHga5XZs5ZMhl5Mq7pcznHvZYnO5hFugvv72NFt0xRfZT/82x5IRsod1eekQpPwvMW0SYOlCSlinQ8sA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133834; c=relaxed/simple; bh=s+OUoJ6rhCNOIhR6tOCrs+3AXmnOId6glH0NozQ1NOc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KdfMclX5BCvimwfGvDecYVZVBOc6Ubj20DnIi3MzK6OxM9QsMp8oUSi9+FIwiQjQ9VUjF2woA9IOWh/ndBJfd1CYhEew5meT5knXE0C3VnK2yT/Kn9LCJCMePGni1zFfuYLPTFwm59tWxD+N7qW1EuwCxAKhsW39TqvUzA7D3GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=U3udbL0V; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Ir8p0gsm; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=BGnBMHxC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0ZvwxkkX; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="U3udbL0V"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Ir8p0gsm"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="BGnBMHxC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0ZvwxkkX" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A45E75BCC5; Tue, 10 Mar 2026 09:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773133831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUI9A/hgnHSkXupPDIlmI7YUhNDaSAHGF86k4pKh9CE=; b=U3udbL0Vn82XgjljuF6pqKQLPLh96ex4QB3mWVAb/KuLUTjIKmuLeSwxn05BBBlmaUls9h MXyyBmZotqulTqHuQFUVHIoMCPALRuy8j76JQTRaT2xwuW2w412Pk9MrFp2NnSzyZgq86c BDX3plReNCdJCD4qdfsuyYFTyCQVuLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773133831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUI9A/hgnHSkXupPDIlmI7YUhNDaSAHGF86k4pKh9CE=; b=Ir8p0gsm8GBllwCCpSBCp5NQ4UIj1lwbbXNXQdJWjYyjm7mAyGvKRyztKpimY/VkWyASAD 5qBk202dge0DsdCA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773133830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUI9A/hgnHSkXupPDIlmI7YUhNDaSAHGF86k4pKh9CE=; b=BGnBMHxCr9PjSMsn5Ty2G9GvZZgn9EQY3LG8OZWGBqxdUD6iSZ1k1q0tHBL0io1YPRkkAg Uv0AlWpIOdZ5QdGp8laWpSKq4+Opb2C9j0akUn7ybP9ERY8JKQplOrpl50ISJewIWJYvsK +WxurjpjBvRHAItUbYjU0nFjocNp0jQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773133830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUI9A/hgnHSkXupPDIlmI7YUhNDaSAHGF86k4pKh9CE=; b=0ZvwxkkXpNRbGO2y1rE+zUEF6Up1W4zGgN4qIGi9Kqdc9pQwatnGofZ+kQO1jkJfgJ68zY 5XaCTMpcVdlrxuCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69CFD3F398; Tue, 10 Mar 2026 09:10:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ilCjGAbgr2kxPwAAD6G6ig (envelope-from ); Tue, 10 Mar 2026 09:10:30 +0000 Message-ID: <937580b6-7433-41e8-9d65-e84385b7b4dd@suse.de> Date: Tue, 10 Mar 2026 10:10:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next 1/2] drm: verisilicon: add max cursor size to HWDB To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Icenowy Zheng , Han Gao References: <20260309085302.3132732-1-zhengxingda@iscas.ac.cn> <20260309085302.3132732-2-zhengxingda@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260309085302.3132732-2-zhengxingda@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[iscas.ac.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,lists.freedesktop.org,icenowy.me,gmail.com]; RCPT_COUNT_SEVEN(0.00)[9]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo,iscas.ac.cn:email] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: Hi Am 09.03.26 um 09:53 schrieb Icenowy Zheng: > Different display controller variants support different maximum cursor > size. All known DC8200 variants support both 32x32 and 64x64, but some > DC8000 variants support either only 32x32 or up to 256x256. > > The minimum size is fixed at 32 and only PoT square sizes are supported. > > Add the max cursor size field to HWDB and fill all entries with 64. > > Signed-off-by: Icenowy Zheng > --- > drivers/gpu/drm/verisilicon/vs_hwdb.c | 4 ++++ > drivers/gpu/drm/verisilicon/vs_hwdb.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.c b/drivers/gpu/drm/verisilicon/vs_hwdb.c > index 09336af0900ae..2a0f7c59afa3a 100644 > --- a/drivers/gpu/drm/verisilicon/vs_hwdb.c > +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.c > @@ -95,6 +95,7 @@ static struct vs_chip_identity vs_chip_identities[] = { > .customer_id = ~0U, > > .display_count = 2, > + .max_cursor_size = 64, > .formats = &vs_formats_no_yuv444, > }, > { > @@ -103,6 +104,7 @@ static struct vs_chip_identity vs_chip_identities[] = { > .customer_id = 0x30B, > > .display_count = 2, > + .max_cursor_size = 64, > .formats = &vs_formats_no_yuv444, > }, > { > @@ -111,6 +113,7 @@ static struct vs_chip_identity vs_chip_identities[] = { > .customer_id = 0x310, > > .display_count = 2, > + .max_cursor_size = 64, > .formats = &vs_formats_with_yuv444, > }, > { > @@ -119,6 +122,7 @@ static struct vs_chip_identity vs_chip_identities[] = { > .customer_id = 0x311, > > .display_count = 2, > + .max_cursor_size = 64, > .formats = &vs_formats_no_yuv444, > }, > }; > diff --git a/drivers/gpu/drm/verisilicon/vs_hwdb.h b/drivers/gpu/drm/verisilicon/vs_hwdb.h > index 92192e4fa0862..c54c9326c1681 100644 > --- a/drivers/gpu/drm/verisilicon/vs_hwdb.h > +++ b/drivers/gpu/drm/verisilicon/vs_hwdb.h > @@ -20,6 +20,7 @@ struct vs_chip_identity { > u32 customer_id; > > u32 display_count; > + int32_t max_cursor_size; Just 'unsigned int'. BTW the other fields should have used regular C types unless they are required to have a certain size. I would also store this as max_cursor_width and max_cursor_height. The term size somehow implies "raw size in bytes". Best regards Thomas > const struct vs_formats *formats; > }; > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)