From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756661AbdAGT4q (ORCPT ); Sat, 7 Jan 2017 14:56:46 -0500 Received: from mout.web.de ([212.227.15.4]:64876 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbdAGT4i (ORCPT ); Sat, 7 Jan 2017 14:56:38 -0500 Subject: [PATCH 4/9] memstick: Improve two size determinations in msb_resume() To: Maxim Levitsky , kernel-janitors@vger.kernel.org References: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net> Cc: LKML From: SF Markus Elfring Message-ID: <9375faf8-986d-e642-df14-1dd2b97d7025@users.sourceforge.net> Date: Sat, 7 Jan 2017 20:56:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <64dfa775-4e4a-bdb0-7b55-41f43ccdf11a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Dq4FhluTSzQB3aYAMdJP4Jgy5iaEeZmZg9Zgo9SqT+p0//5QYHw 8JuyZpzQ1vBBXmu+ojGeGopOK0o8yTJxr4WkjpOJCXbXUKVvVX9mdyWD/ocdBbtiTOHFyld 3HwbdecnqH3h8qwDXLq71jNmNN1id8pvPTdfCo2tI2C6jwbKnWzO9XaM21tyoQXGnUvY4db ngFwsLeqK6XPh8z0v7fVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:gQ4iqFU/Iy0=:du844Jk8k2nE15RnS5KOKl +FKenJK5ANjGOfWvgw/7zgyVgm+eLAnYHvdlktkuc38YM1vFrofCvfAG0DVXtfVzcWfDbAT7C XzLqpFco4pl9XX0D8GaKtNZ9a49imwpofBV/hD+jizJgRO3B/6dyqzxZE2XvNLNW+NxfFClHL LHSvcWIW7p/T677SfdbHaz/1rCtubdaoPOgYmg8x5ByGX3XjRuFMS/cgLKBjk5XiBnn5n++8i BYm9W8aAJ+ptOCGdGubfqVDpyF97i4S2Ll4ngeIBTaLb+bKqn7KZZBf3RnB8HqLh1h1vPrm15 GC3IBiX3e8vSB/5ZgN2XkoasYleR5SF81BQRmpe8iulQdM6BcXXUYiIN1/tNAhlayj046IfS5 qcqtSS7nDRMAw+WmW1PbSByuCa2pusZtfsFq+eTLtVjyWxD0qSfynGh7ZCELMm6xJBKuu2wgy uFPa1Wf7s12JirddRU7EMDqshNTi7a89f4qGh/PvRpMmCQh5CCxYUZlCSaPZawWh+oIc7OsCw 95yoA/6zC7+FEIHIB5Rn6x8iEjLg0IAsD+aXsxO7Lr3+k/q6wQzdbrdGkodQZ7YGU762eQqi1 EI88P/sEMm7lBBSr8dllBdSFf5Xe5XsJhZWhlaRHRjIlRElUspO2gAH5GIrXCsVZKuoVB4nka m9XvWV/MxiP9h+Hnhxx8BwO77J9aSbu6LK/bDM6lfLj8TxxOEksD+HUW1KKkPjythaY6QYJyq vibbaIIBCUZb+KuYLHPvJnIr7itavYrSt49ni3oRaDBsJcKeI1J0bBsSIJkj1Pr+OaQLkDTiw tqOv6H/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 7 Jan 2017 19:17:07 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/memstick/core/ms_block.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index 526e671a3435..fd3d9f78bcba 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -2261,8 +2261,7 @@ static int msb_resume(struct memstick_dev *card) return 0; #endif mutex_lock(&card->host->lock); - - new_msb = kzalloc(sizeof(struct msb_data), GFP_KERNEL); + new_msb = kzalloc(sizeof(*new_msb), GFP_KERNEL); if (!new_msb) goto out; @@ -2277,8 +2276,9 @@ static int msb_resume(struct memstick_dev *card) if (msb->block_size != new_msb->block_size) goto out; - if (memcmp(msb->boot_page, new_msb->boot_page, - sizeof(struct ms_boot_page))) + if (memcmp(msb->boot_page, + new_msb->boot_page, + sizeof(*msb->boot_page))) goto out; if (msb->logical_block_count != new_msb->logical_block_count || -- 2.11.0