From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdE3KAO (ORCPT ); Tue, 30 May 2017 06:00:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52606 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdE3KAM (ORCPT ); Tue, 30 May 2017 06:00:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 41645C04B321 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 41645C04B321 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170528102008.30276-2-hch@lst.de> References: <20170528102008.30276-2-hch@lst.de> <20170528102008.30276-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, Andy Shevchenko , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9376.1496138404.1@warthog.procyon.org.uk> Date: Tue, 30 May 2017 11:00:04 +0100 Message-ID: <9377.1496138404@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 30 May 2017 10:00:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c. > > The V1 uuid intrepreatation in struct form isn't really useful to the > rest of the kernel, and not really compatible to it either, so move it > back to AFS instead of polluting the global uuid.h. This isn't going to work. You've effectively changed the types of the fields in the UUID struct from BE to CPU-endian, but you're still calling generate_random_uuid(), which produces a BE UUID. You need to leave the struct members as __beXX or stop using the core UUID routines. Just move the struct uuid_v1 as-is to the afs headers and rename it to struct afs_uuid. You can then leave the (un)marshalling code alone. David