From: Dan Carpenter <dan.carpenter@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sasha Levin <sashal@kernel.org>
Cc: Qiu-ji Chen <chenqiuji666@gmail.com>,
dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3] staging: greybus: uart: Fix atomicity violation in get_serial_info()
Date: Mon, 11 Nov 2024 12:14:21 +0300 [thread overview]
Message-ID: <9378fe55-66d5-4a11-9524-a0ed01f458ed@stanley.mountain> (raw)
In-Reply-To: <2024110724-overbuilt-liquid-3734@gregkh>
On Thu, Nov 07, 2024 at 04:11:00PM +0100, Greg KH wrote:
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> a patch that has triggered this response. He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created. Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
>
> - You have marked a patch with a "Fixes:" tag for a commit that is in an
> older released kernel, yet you do not have a cc: stable line in the
> signed-off-by area at all, which means that the patch will not be
> applied to any older kernel releases. To properly fix this, please
> follow the documented rules in the
> Documentation/process/stable-kernel-rules.rst file for how to resolve
> this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
Like Johan said, this doesn't really belong in stable because it doesn't affect
users. It's mostly about correctness and static analysis.
The linux-media CI system has also started complaining if we don't add a stable
tag and it suggests that the correct thing is to add:
Cc: <stable+noautosel@kernel.org> # reason goes here, and must be present
Do we really have to do that? Applying it to stable doesn't cause a problem,
it's just not necessary.
regards,
dan carpenter
prev parent reply other threads:[~2024-11-11 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:33 Qiu-ji Chen
2024-11-07 15:11 ` Greg KH
2024-11-07 15:22 ` Johan Hovold
2024-11-11 9:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9378fe55-66d5-4a11-9524-a0ed01f458ed@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=baijiaju1990@gmail.com \
--cc=chenqiuji666@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®