From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC1FFC31E49 for ; Thu, 13 Jun 2019 15:47:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF526208CA for ; Thu, 13 Jun 2019 15:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389465AbfFMPrk (ORCPT ); Thu, 13 Jun 2019 11:47:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55346 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731750AbfFMJ1m (ORCPT ); Thu, 13 Jun 2019 05:27:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AD9430A6986; Thu, 13 Jun 2019 09:27:34 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-109.rdu2.redhat.com [10.10.120.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8457E600C0; Thu, 13 Jun 2019 09:27:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20190612225431.p753mzqynxpsazb7@brauner.io> To: Linus Torvalds Cc: dhowells@redhat.com, "Eric W. Biederman" , Christian Brauner , Al Viro , Linux List Kernel Mailing , linux-fsdevel , Linux API Subject: Re: Regression for MS_MOVE on kernel v5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9382.1560418050.1@warthog.procyon.org.uk> Date: Thu, 13 Jun 2019 10:27:30 +0100 Message-ID: <9383.1560418050@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 13 Jun 2019 09:27:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Adding Eric to the cc list since he implemented MNT_LOCKED] Linus Torvalds wrote: > > The commit changes the internal logic to lock mounts when propagating > > mounts (user+)mount namespaces and - I believe - causes do_mount_move() > > to fail at: > > You mean 'do_move_mount()'. > > > if (old->mnt.mnt_flags & MNT_LOCKED) > > goto out; > > > > If that's indeed the case we should either revert this commit (reverts > > cleanly, just tested it) or find a fix. > > Hmm.. I'm not entirely sure of the logic here, and just looking at > that commit 3bd045cc9c4b ("separate copying and locking mount tree on > cross-userns copies") doesn't make me go "Ahh" either. > > Al? My gut feel is that we need to just revert, since this was in 5.1 > and it's getting reasonably late in 5.2 too. But maybe you go "guys, > don't be silly, this is easily fixed with this one-liner".