Re: [PATCH RESEND 31/31] ASoC: amd/sdw_utils: add sof based soundwire generic machine driver

["Mukunda,Vijendar" <vijendar.mukunda@amd.com>]

On 02/08/24 14:07, Krzysztof Kozlowski wrote:
> On 01/08/2024 13:18, Vijendar Mukunda wrote:
>> Add sof based Soundwire generic driver for amd platforms.
>> Currently support added for ACP6.3 based platforms.
>>
> ...
>
>> +static const struct platform_device_id mc_id_table[] = {
>> +	{ "amd_sof_sdw", },
>> +	{}
>> +};
>> +MODULE_DEVICE_TABLE(platform, mc_id_table);
>> +
>> +static struct platform_driver sof_sdw_driver = {
>> +	.driver = {
>> +		.name = "amd_sof_sdw",
>> +		.pm = &snd_soc_pm_ops,
>> +	},
>> +	.probe = mc_probe,
>> +	.remove_new = mc_remove,
>> +	.id_table = mc_id_table,
>> +};
>> +
>> +module_platform_driver(sof_sdw_driver);
>> +
>> +MODULE_DESCRIPTION("ASoC AMD SoundWire Generic Machine driver");
>> +MODULE_AUTHOR("Vijendar Mukunda <Vijendar.Mukunda@amd.com");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:amd_sof_sdw");
> That's a total duplicate... standard form letter:
>
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.
Agreed. Will remove MODULE_ALIAS().
>
>
> Best regards,
> Krzysztof
>