From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbcBLOhK (ORCPT ); Fri, 12 Feb 2016 09:37:10 -0500 Received: from m12-12.163.com ([220.181.12.12]:57204 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbcBLOhI convert rfc822-to-8bit (ORCPT ); Fri, 12 Feb 2016 09:37:08 -0500 Content-Type: text/plain; charset=gb2312 Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 14/54] perf tools: Support setting different slots in a BPF map separately From: pi3orama X-Mailer: iPhone Mail (13D15) In-Reply-To: <20160212142341.GK16190@krava.redhat.com> Date: Fri, 12 Feb 2016 22:34:44 +0800 Cc: Wang Nan , Alexei Starovoitov , Arnaldo Carvalho de Melo , Arnaldo Carvalho de Melo , Brendan Gregg , Adrian Hunter , Cody P Schafer , "David S. Miller" , He Kuang , =?GB2312?Q?J=A8=A6r=A8=A6mie_Galarneau?= , Jiri Olsa , Kirill Smelkov , Li Zefan , Masami Hiramatsu , Namhyung Kim , Peter Zijlstra , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <938F6A13-5258-43E0-8692-903AEA2553AF@163.com> References: <1454680939-24963-1-git-send-email-wangnan0@huawei.com> <1454680939-24963-15-git-send-email-wangnan0@huawei.com> <20160212142341.GK16190@krava.redhat.com> To: Jiri Olsa X-CM-TRANSID: DMCowAAHt9KD7b1W5XO0BA--.9064S2 X-Coremail-Antispam: 1Uf129KBjvJXoWruF13Gw45Xr4fAr1xAFWxtFb_yoW8JryUpF WjkF1FkF4UGrs7CF12vF4kZ3yIgw1fXw48G34jgasIvrn8Zrn5Xw4jgr1jkr98JrnrZw10 qF4UX3WUCr1DCaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jYJP_UUUUU= X-Originating-IP: [118.125.191.235] X-CM-SenderInfo: lslt02xdpdqiywtou0bp/1tbiEwUNQFXldHK2egAAsh Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 发自我的 iPhone > 在 2016年2月12日,下午10:23,Jiri Olsa 写道: > > On Fri, Feb 05, 2016 at 02:01:39PM +0000, Wang Nan wrote: > > SNIP > >> >> +int parse_events__merge_arrays(struct parse_events_array *dest, >> + struct parse_events_array *another) >> +{ >> + struct parse_events_array new; >> + >> + if (!dest || !another) >> + return -EINVAL; >> + >> + new.nr_ranges = dest->nr_ranges + another->nr_ranges; >> + new.ranges = malloc(sizeof(new.ranges[0]) * new.nr_ranges); >> + if (!new.ranges) >> + return -ENOMEM; >> + >> + memcpy(&new.ranges[0], dest->ranges, >> + sizeof(new.ranges[0]) * dest->nr_ranges); >> + memcpy(&new.ranges[dest->nr_ranges], another->ranges, >> + sizeof(new.ranges[0]) * another->nr_ranges); >> + free(dest->ranges); >> + free(another->ranges); >> + *dest = new; >> + return 0; >> +} > > is there a user for this function in this patchset? can't find it.. > > I recall I've already seen it in earlier versions, but can't find it now ;-) > Sorry, I should remove this function. It is designed to be used in patch 15, but I found it require more code if use this function, so instead patch 15 does the merging inline, makes this function useless. Thank you. > jirka