From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CAD73890E5 for ; Mon, 16 Mar 2026 12:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773664709; cv=none; b=A+LNj8fref+CgMZDbyFUBuOVRxnNKgN74q1yptuoDsB+dwLfjydLlaXMeoL9SbiqRXrONDczbEgIJ3XqhDtAJvky7kx8IaAc6Jo1A7lk2Tr1DCLkAkrx2iBtBmpCSxjkvJONGEpeTAsUaPC1kWbwsiaagB63M3DKOookbMoa4/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773664709; c=relaxed/simple; bh=nsErYwbtChCQiapJkcrzg98OOqd8zCCGMK2ntR4jOqA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hGQjRzCACpDSb9dw3NdpuhHSp3P2jS5qYjp0MWXaSHQQH6NnA2cW64uIlgt7rmxPAyRqU8L8fVCIxS0GalojGw7PicQtrFjVm+Tvf6+1QNqelM8tSWOQxN3n7kdGriPB47JsaR/1QJXlq4/Km1BFJf8YrVeYo6t+rxe2bbn+UY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N7N5ZXRC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VwN5RBkO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N7N5ZXRC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VwN5RBkO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GBjhkl1428764 for ; Mon, 16 Mar 2026 12:38:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9J2Sbga2XlEXPDOHcokMKf1ZSnJnsrAxProE5RVBy1s=; b=N7N5ZXRCutQ6RBDz /S1ioW2HCgNopQ1FCnJtUN+Lp4kyIn5A9p6FMDVhoip9bNRqUYyJcLPd0I+OySh0 LIoM0aS3QK//H/GP7XDU9iyX4+Hg+KrIWjDBDUGQzQ07potR6yEcfhVu3aXBHuHP CaY4O4GU88ALZrVYZFJisjp294zZ3vc2u6tXkvpkSXHbfdHObH8FCh97ixhBlmR3 Sz8aPG6KrC4A8BmLYmMq74pDk+J5p/LrrLCgoLlxhq+fNuNRgjGXnhUW1KmlRamF aqnocV+LebWZqS90IWBWzFQQ//uFb9S3dyjVf9Yk+QBKcap9jAB+dKtbLaSBgD4x gJkgCw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxh99862h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 12:38:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35b96fbfc64so6743954a91.2 for ; Mon, 16 Mar 2026 05:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773664707; x=1774269507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9J2Sbga2XlEXPDOHcokMKf1ZSnJnsrAxProE5RVBy1s=; b=VwN5RBkOregDSQPPb4NXjyetAm1AerysCscHEEHLuT3vJUIvypK1thvPPrmS6zj0eg MIB5ayHN7zlK12wR5g5NrYPevehx1uR9OIA2aTNZj06q/+E5AOLVwiWMxOl0b8QCGk/O D6PMPfrSZ21X++A4YCDMdU04IL+UjPDccZVoiS4d4xjHfuatoPJ9BrlcZBV0jyNc89y5 9gP/hVFLP3x01H7tQWLODDSSSV5Ptb/EAqK9NpvB9vBnt9LFBgZLAX+KvuJsRBSi9Ucz tQR7HazJndlXIkMa0yjmuEi1G2jHtUuF+S24Mlk89kb3BOEQK7BZDzASAUznYwB45QPN CHHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773664707; x=1774269507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9J2Sbga2XlEXPDOHcokMKf1ZSnJnsrAxProE5RVBy1s=; b=nxc+P+OSSrk8v2Yl6MEzXS1vP6Tie3AnewV8ObPX65e41iawTnygSYxRE6rewDFEuY caU2JZuXiwpJ+7ekM1okwuawJjO5akmpZ9b7aTpYw1epUqaLGySGtUFrddDDnA5TazhC TcUODglWHoVxvQBV7s0YfGE8ECBbot5LHVqGVpltN03ZNnFkviUBPXZeLqtyVfKM5i4B wv0tRKMfK2rPWl0B+2JljOfR9Z8LFX7SvMCP3zrC9XweylBUCEECS0JTHaaQfgMQgbrT DosXBhX6/4d91Tou0YlsI/C+W9nOLKCibMvqINb2t7VQsH34xgPKrtEMRQhvW7/qGn62 LHCA== X-Forwarded-Encrypted: i=1; AJvYcCXAMLuAfYdHQ1NLEKdrZ3UM4pWLMqP/shwv+43Jj5G3yiOHUPNK8hPmE5eCHG9wqctfYAGw9UbNIhOmhxA=@vger.kernel.org X-Gm-Message-State: AOJu0Yze8f88DamIZ0YWikcw10I+UFWNFZ6/P2fkf715fHRc6xN8ATnS PzsRWkGeSc8chumobX56gNjpWieK4IXgpVzsfWHwbBIXC444Gq+bUPX/Q6HSO0QxQG+caoR90To Fpy0XRgcj3z9hPMUfeUhdQJg1moCLhaVgKRTIZhZyPk5jAedLHrfIiNfjqlODGGedPmc= X-Gm-Gg: ATEYQzx+huuMBo4FYLZbkvVQkN5nMROW3FOP+ysoOwC/M06eOYNaDkBzNB/DjBcFXzG ZEy/PS3rXuxM6euKbrv0FrKz/5wl0v6QIXxudCnpxcOaySjtULSUv1L4wSSWiDsp/zle/OLyF0g vSWn5uBArAMdMXZHX4OREk7xl/t8oGwkJkofK52bDbdsv/p0PH4ue5n878UNqSZPN6qcn5MFsWU 9BGhqalq3xwj1kXy/pIzj+pH4CY05od3m2TNxpRJLXVCH5hRmHF66PNQjP0g2hCMGf7IIvS2syh RbUOG+vpiFkdhDZDI9Et9dGJ5BXWDnizVQo2qKTpQHxpWVGp8JfgsPMlk/l+jRUFLkACQ93av1b 8C0tjC4+OcHVe4pgcWKTc9rWRpBjpJ7ssYGbaqxYldxG36fGA1rU= X-Received: by 2002:a17:90b:240e:b0:35b:9242:61ac with SMTP id 98e67ed59e1d1-35b924264fbmr3530211a91.10.1773664706862; Mon, 16 Mar 2026 05:38:26 -0700 (PDT) X-Received: by 2002:a17:90b:240e:b0:35b:9242:61ac with SMTP id 98e67ed59e1d1-35b924264fbmr3530174a91.10.1773664706318; Mon, 16 Mar 2026 05:38:26 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74028eecd4sm3718488a12.26.2026.03.16.05.38.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 05:38:25 -0700 (PDT) Message-ID: <938a2d30-200e-449e-8ccb-0d2576fd28d2@oss.qualcomm.com> Date: Mon, 16 Mar 2026 18:08:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> <2ac2efad-3533-490e-bb42-f21c4e950277@kernel.org> <972bd9c8-4671-4151-a3a9-d7eccdf83913@kernel.org> <87fe32f1-b2f2-4b9c-9e54-03be35c921f2@kernel.org> <48daa237-aff9-45ef-919e-665e5ed27f66@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RJ++3oi+ c=1 sm=1 tr=0 ts=69b7f9c3 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=SZXt-WhlXTLr8WwM2e8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA5NSBTYWx0ZWRfX2CO2As6jQzos a/0fpEF7E4jq35usrgiovuz4W4o54ZsAXCW8t/u0MYpELIpAuvTkwuhKnBNJe9d+5cxl0g6TyJV vqklZlMzTwfRfQaGIV9Cbw0ppLI4X2dUb7EILtPohSXtFwsyCGT1oquGBydf6faTABd7H8Q0AlY okB2I4nK5lnRKcvBa3nmNk6mHvgOiR6vpf9cCrTYWlg2uuWkkytLi5nvyLy/smPCHY/zHj1RRn5 xeeAtFHQOyD5hY5Qy7W6un5StxMk+llTmUfHNWu55pzaDhu5tAFnlWX7nO4f1Pcr/CdMemr+mDO H1NPn9tIsHujOiYQ95aAOtXq5GZ88AxIZHg8memusM5WRFZbVEiLafalmCnNCKVcmOk4TU8KrmA whSIKvTugWKQZca8O4oBjrSMW8nl1AkXzsszGoMr8sOso+k3inzQnCBuFK39YHFcNo/H5RI6Fxx SPmCnG7dDG/R1E1w6jg== X-Proofpoint-ORIG-GUID: uc-94GdVFYiZNzTaSzY4zgb1ETba2jyF X-Proofpoint-GUID: uc-94GdVFYiZNzTaSzY4zgb1ETba2jyF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160095 Hi Krzysztof, On 3/16/2026 4:39 PM, Krzysztof Kozlowski wrote: > On 16/03/2026 11:56, Harshal Dev wrote: >> Hello Krzysztof, >> >> On 3/13/2026 9:28 PM, Krzysztof Kozlowski wrote: >>> On 13/03/2026 12:45, Harshal Dev wrote: >>>>> Except new devices, like Eliza and Milos. And then this should go to >>>>> current fixes. >>>> >>>> I'm not sure if I understand correctly, do you mean to say that except for Eliza >>>> and Milos, new devices need to change their DT binding to 'required' with >>>> corresponding DTS changes. And then, the patch updating the DT binding also needs >>>> to be back-ported? >>> >>> No. All new devices must require this. You only preserve released ABI, >>> so fix unreleased ABI (Eliza and Milos) now, before it gets released. >>> >> >> I'm already being annoying, but I will disturb you one more time for clarification. :) >> >> By saying 'fix unreleased ABI now' do you mean to say that I should add another >> trailing commit at the end of this patch series which marks these resources as >> 'required' in the DT-binding without carrying the 'Fixes' tag? Specifically so that >> Eliza and Milos carry this constrain. > > Please post a v3 of this patch for crypto subsystem, doing what you did > here plus requiring these clocks for Eliza and Milos, with explanation > why this is a fix thus why this should go to current cycle. > Got it now, I will add additional bindings which make the clock and power-domain mandatory for Eliza (unreleased ABI) while keeping them optional for others (released ABI). But I feel I should add this as a separate commit which carries a Fixes tag for this: https://lore.kernel.org/all/20260223-eliza-bindings-crypto-ice-v1-1-fc76c1a5adce@oss.qualcomm.com/ This commit with it's current Fixes tag is required to be back-ported on LTS branches because they fail to boot for LeMans and Kodiak. Let me know if that's not good, and I should add the additional binding in the same commit. > >> >> From what I understood from Bjorn's comment, the DTS and ICE driver sources will reach >> from different trees and either could be merged first. To maintain bisectability we > > > They are applied to different trees. Period. This defines everything, > you cannot fix it post factum, you cannot fix bisectability afterwards. Ack. > >> should first merge this patch series followed by a subsequent patch which marks these >> resources as 'required' in the DT-binding along with accompanying ICE driver source > > Then you have a released ABI and you cannot change it, so what does this > achieve? Ack. > > Just look what is merged where and you will see the differences. I don't > see Milos crypto engine in current cycle, do you? I don't either. I believe only Eliza has been added till now, I'll re-base and add only for Eliza right now. Subsequent patches for Milos will know where the entry needs to be added. > > And bisectability has nothing to do here. You need to fix ABI before it > gets released. Got it. Thanks! Regards, Harshal > >> changes which fail probe when 'iface' clk isn't available. Of course, the subsequent >> patch will not be back-ported as a fix. > > > > > Best regards, > Krzysztof