From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AAFB42070 for ; Sat, 18 Jan 2025 17:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737220455; cv=none; b=bFFwDbghp1OcvXMkqJMZMGbV7nDtHySF2dITkzhHCIavkn/9NgOUJcTOp71GoAzfJa+JYKscVkmeDOzF0IES2QFp63RKtCKBLIFHW6BzABKKsF0Y3uE1ZptyFB27bDnvgu54r5ijFAIYQj/ueRBvq34Au4fQNxMyepS4Jjy3Dis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737220455; c=relaxed/simple; bh=gjsIOVX+ye+4kEXYWaQMgX6lCE4ryiEwsbDmLGNLT+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LP2DNLB5dqj7+N4ssV79UxY+CZZqcyFQsZRrLicPEMQm0txSyFwQdfylyhUppkrRkBXMdwHCp8BXE3dF1FJaT2CZpmosmHGP9TiR42a/2Rb39v+4RbyR/dELTVMte6OKBRHZKGhJFdKeUGkqQgeolaLi6Wi6+u6PI0bzJT2sWy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ODHLh0zy; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ODHLh0zy" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-29fe83208a4so1760581fac.0 for ; Sat, 18 Jan 2025 09:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1737220452; x=1737825252; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YZPu6FVwcORY2iGxdLdp/QzMj0EscoJgxJ/cxmxbvSc=; b=ODHLh0zyOv67DqfxlJJDkkyTXoelvLHiejmt6riUHUEJvPIdVVkFCoXFMztnj4vxrg tSzl+npbn+UtLI8qtr0IN2C01MB4hpv0d9cJPBCAXpBZegUjmVrp4atWdu0u/vmEbJ1/ umpmusOrB4D/sMq8kKBg0z87SzK154+MQvFHMtOA3KuAkHisTmLNdbGwUEIQNpcjwRXy Sa/E+o0MgCpcFIFyUzTWnRW8DlpiAMbFOj4LwLrrDv+I3ouck6on9tuP4OAK8LR8V6RP zuxLMvztn2oKSmK7oCO43ozyn1Ukyu2WUuhNfTRW9GN998OELCiniNZ4eZUkfAQxWu8R Iaqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737220452; x=1737825252; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YZPu6FVwcORY2iGxdLdp/QzMj0EscoJgxJ/cxmxbvSc=; b=ho3Ufb3R6g7NW824v853JFALxbHD8Q/YtbGpkUi+Pp9dgh1a+vk6KiLcV85Gal/xdg jyQxTYt1a9e70/KDTo8HdlHP3tB5+z9+bTtWCs2T3NettB3TJJzpWXLqn6AA4UhojiAi XYsBk/KPPbhnraplYETYjlNcu2AOuq7/b9mulzUSJXr9LH7hzQg1Dj1p3xn1qGjzxwrN WQPspxAYf8+b6Wd7CV/QEse1TRfSCFLQO2/jYm0eATZaRizuo9D+edhvh57GaIEIWKlO yLcMDBs17btv02og2SJ7sHELVKHUEuZNCRKj3IkIvIGR1vBMZHGoSxLFqG4s+x3sRhNu rcjA== X-Forwarded-Encrypted: i=1; AJvYcCX+HIvw26wOtk1j9I16WT0W3mZJ7tjt7YKp+dOpXxASaAHYrHPLE/p+D6McucL9N0kOwiva9mVZ80MWzeE=@vger.kernel.org X-Gm-Message-State: AOJu0YwM3LQPvYzp1TdnupV64VyuRAl6E5cJpnVGh2A3ZlYxN9SbX9Av VW6nQMoSZSQGm17tMIBBp/3b6VkqzzrUly06otkWbBytak58OpfI6VWP5OOQ6xQ= X-Gm-Gg: ASbGncvjRrehVz7rR/Jgld+4qeT/gj0tf9zTQIj5zs4KQiE7wY7Hwld3xaFbp3rFyqS K4lNbigUjjU3M3CEwYfxvhd+55yyW2SbLMyuj35CIW1gqQvHGhXXMiekWP9NMXP7hSxvQGSbN+q jOxSdSBNWq9GkKejNJ68CxeVFLC5Xl3mk6CyanWw9l53py02yfQ3MsiHLRIaN1EUtBk+ucjYvGv P8k2n9wAyydpBf0mQ2h+YpBYhQoFyaJgMIMtxRB1Yz8kKN7UzRJDGOCrwtt4KYDY6wGX93g/1PO VCzOKu/U1rmbfRKn9nomp2Hi9nTazcI= X-Google-Smtp-Source: AGHT+IF0KQ8N3yID9WKJ8pbLob3laSFOdEDYikjZQRGsX6bfpyeTJuEoWKPbPTkbFuS1VxUtjjfgjw== X-Received: by 2002:a05:6870:7f18:b0:29e:3d2a:a4a9 with SMTP id 586e51a60fabf-2b186a3f900mr8911931fac.5.1737220452365; Sat, 18 Jan 2025 09:14:12 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b1b8ce8777sm1812904fac.14.2025.01.18.09.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2025 09:14:10 -0800 (PST) Message-ID: <938e5570-8e56-4f8d-aff2-3c6354f3330c@baylibre.com> Date: Sat, 18 Jan 2025 11:14:09 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 1/2] iio: introduce the FAULT event type To: Guillaume Ranquet , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250116-ad4111_openwire-v3-0-ea9ebf29bd1d@baylibre.com> <20250116-ad4111_openwire-v3-1-ea9ebf29bd1d@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250116-ad4111_openwire-v3-1-ea9ebf29bd1d@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/16/25 9:01 AM, Guillaume Ranquet wrote: > Add a new event type to describe an hardware failure. > > Signed-off-by: Guillaume Ranquet > --- ... > enum iio_event_direction { > @@ -128,6 +129,7 @@ enum iio_event_direction { > IIO_EV_DIR_NONE, > IIO_EV_DIR_SINGLETAP, > IIO_EV_DIR_DOUBLETAP, > + IIO_EV_DIR_OPENWIRE, I think it would be a good idea to add additional namespace in the identifier to make it clear that OPENWIRE only should be used with IIO_EV_TYPE_FAULT. i.e. IIO_EV_DIR_FAULT_OPENWIRE > }; >