From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A69199D1 for ; Wed, 3 Jan 2024 12:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 28528626FB0A; Wed, 3 Jan 2024 13:55:35 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7xvMlIEQrAr9; Wed, 3 Jan 2024 13:55:34 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 897A9626FB0F; Wed, 3 Jan 2024 13:55:34 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id feRsaCc2sddh; Wed, 3 Jan 2024 13:55:34 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 630CD622F598; Wed, 3 Jan 2024 13:55:34 +0100 (CET) Date: Wed, 3 Jan 2024 13:55:34 +0100 (CET) From: Richard Weinberger To: chengzhihao1 Cc: david oberhollenzer , Miquel Raynal , Sascha Hauer , Tudor Ambarus , linux-kernel , linux-mtd Message-ID: <939427292.194880.1704286534231.JavaMail.zimbra@nod.at> In-Reply-To: References: <20231228014112.2836317-1-chengzhihao1@huawei.com> <1145531757.175508.1703844362355.JavaMail.zimbra@nod.at> <13b259ca-b32f-a8d6-5e11-8bb38df72f5c@huawei.com> <642239519.177270.1703884138999.JavaMail.zimbra@nod.at> <535616666.192239.1704228332389.JavaMail.zimbra@nod.at> <460eb02e-8937-282c-62c5-6ea606324b0e@huawei.com> Subject: Re: [PATCH RFC 00/17] ubifs: Add filesystem repair support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: Add filesystem repair support Thread-Index: BXUjUihmAOjaNq4Zv4hi8fz+n/56vw== ----- Urspr=C3=BCngliche Mail ----- > Von: "chengzhihao1" > How about merging 3(a) and 3(b) as one mode(dangerous mode)? If fsck can > get a good TNC(all non-leaf index nodes are valid), fsck executes as > 3(a) describes. If fsck cannot find a good TNC, fsck executes as 3(b) > and reminds user that "TNC is damaged, nodes dropping is not awared". Well, you can make all modes combinable. Right now I don't care much about the user interface. But offering much flexibility is a worthwhile goal. At the end it should be crystal clear to the user of fsck.ubifs whether it fixed the file system by applying dangerous methods or not. Want I want to avoid by all means is a tool which blindly alters the filesystem just to stop UBIFS complaining about it. Thanks, //richard