From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04A4C433EF for ; Tue, 19 Jul 2022 17:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbiGSRx2 (ORCPT ); Tue, 19 Jul 2022 13:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbiGSRx1 (ORCPT ); Tue, 19 Jul 2022 13:53:27 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C06E558CB; Tue, 19 Jul 2022 10:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658253206; x=1689789206; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2QpaWwyMGOI/87FV5yJoVCYewK4j2LMWRbyQ9ggcnqY=; b=Wez1ecgTptQXbFkRTSfxqrszlftCGgkQQLGJSY7WBIrw/s6zTa0hdZzs 8ZGLQG6P68RzIFDewNR0XAQRbbhxYA+tcsiUqc3bCFJCPRZqUZugUkV5g FXNr2tLFcHX81qLC6LwJh4n+0Vg6XX/FUYrAElnLzdGQU3Z7kfTNFvQBN a7rnatjLp+d4P/x9d9ThJWabYCbc3c+ZNXg/obeY+uLx7PtJHdJjgdjA0 0gATnyIx/vajxGcTebktMqng3HsvpY2HnQ+tCzuzleft7b12Lhne0q4bw WxDdMcF8Q4Rhh0SSoOvRfcox4n0yOrci6oZSigLR9EikPIHHzkoXCouFk Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="372859099" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="372859099" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 10:53:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="687198943" Received: from twliston-mobl1.amr.corp.intel.com (HELO [10.212.132.190]) ([10.212.132.190]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 10:53:25 -0700 Message-ID: <93960610-d7ff-8c7f-16ae-61191e6ed377@intel.com> Date: Tue, 19 Jul 2022 10:53:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] x86/sgx: Allow enclaves to use Asynchrounous Exit Notification Content-Language: en-US To: Haitao Huang , linux-kernel@vger.kernel.org, Dave Hansen Cc: Jarkko Sakkinen , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-sgx@vger.kernel.org, Sean Christopherson , "Huang, Kai" References: <20220705183648.3739111-1-dave.hansen@linux.intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/22 06:19, Haitao Huang wrote: > > I think you need add this change in arch/x86/kernel/cpu/sgx/ioctl.c, > inside sgx_encl_create function: > > -    encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | > SGX_ATTR_KSS; > +    encl->attributes_mask = SGX_ATTR_DEBUG | SGX_ATTR_MODE64BIT | > SGX_ATTR_KSS | SGX_ATTR_ASYNC_EXIT_NOTIFY; > > Otherwise, EINIT ioctl fails with this new attribute set in enclave secs. Makes sense. I'll add it there. I also just realized we need to update arch/x86/kvm/cpuid.c as well. It keeps a complete list of guest-available SGX attributes.