From: Andrew Lunn <andrew@lunn.ch>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux@armlinux.org.uk, hkallweit1@gmail.com,
alistair23@gmail.com, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 1/2] include: mdio: Remove mdio45_ethtool_gset()
Date: Tue, 12 Nov 2024 14:17:30 +0100 [thread overview]
Message-ID: <939ceeee-ce7b-47cf-80e4-873a0816f26a@lunn.ch> (raw)
In-Reply-To: <20241112105430.438491-1-alistair@alistair23.me>
On Tue, Nov 12, 2024 at 08:54:29PM +1000, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> mdio45_ethtool_gset() is never called, so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
With a pathchset, it would be normal to include a cover node, patch
0/X, which explains the big picture. There you could mention that you
are primarily doing this for Rust since it gives linker errors.
The patches themselves look O.K. Lets leave them for a couple of days
so 0-day can build test them and see if there are some users hiding
away which we both missed.
Andrew
next prev parent reply other threads:[~2024-11-12 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 10:54 Alistair Francis
2024-11-12 10:54 ` [PATCH 2/2] mdio: Remove mdio45_ethtool_gset_npage() Alistair Francis
2024-11-12 13:12 ` Russell King (Oracle)
2024-11-12 13:17 ` Andrew Lunn [this message]
2024-11-15 3:30 ` [PATCH 1/2] include: mdio: Remove mdio45_ethtool_gset() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=939ceeee-ce7b-47cf-80e4-873a0816f26a@lunn.ch \
--to=andrew@lunn.ch \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®