From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9266DC433E0 for ; Thu, 25 Jun 2020 19:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A123206A1 for ; Thu, 25 Jun 2020 19:55:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OOTJEsFi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436520AbgFYTzN (ORCPT ); Thu, 25 Jun 2020 15:55:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52167 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2406937AbgFYTzC (ORCPT ); Thu, 25 Jun 2020 15:55:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593114901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMmWD42emjWTjisxH2mhg8ooA/tzTNuz83b0inCszAo=; b=OOTJEsFiHL7qFTS9sWbEAwCUvg2YoaBg1eN+exgSZdJfJk+aoK1O/BUQHo5k1I6h1FerxR 1YMMZ4Z5Ti+H148Ff4jafpo5wbZmfHFQzhrfEO25cikE+grG/ahGVAIrTkS6zNjzp9jK8J 02EVR/9Av0gzKQT0craREic5LDwFBJw= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-1cBfhSU3NuWAYkvGx-KQ6g-1; Thu, 25 Jun 2020 15:54:59 -0400 X-MC-Unique: 1cBfhSU3NuWAYkvGx-KQ6g-1 Received: by mail-ed1-f72.google.com with SMTP id x3so5952662eds.14 for ; Thu, 25 Jun 2020 12:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=wMmWD42emjWTjisxH2mhg8ooA/tzTNuz83b0inCszAo=; b=qPy+2Ff9FDzOexVydR/b+AtK8TTltNdAYMntsunhCCblMkBqdLBeicg2hbTZl3txlo 7SUyvBjo53oWs2sconEiV+Cy9P6dWVqeuy7wUpgiUvkv16itItk3iVLzNh3bpVQiJ9Zb IwpZkPrvM3AEZj6yW+F+CTnlqnpjUToKTkTuGUQG9CCKvvZUIieBdH7Epb3hnmXhut+E RAdyordTAbjk8H/q+j5EJDAO1lqJBMmUmdewji1OWmntVy8mtqmlEnwZkL3G/UUaxFSh DvJdNCDwWBNwdMTOUFi3bFDCQoJP1Cxzvv6CF85S5NSUuW+voUeW7hc44lvQDhc0Ouuy UOog== X-Gm-Message-State: AOAM532eCf1DnZRrYDxF8DtkBvVRgEngjllIpiMudVWb2NXKpT+pV68z qmF7HiJKXEgVw0JJ2ykY9tqX3kWq7SKzwZKC5Ng3l2l0nguRHP7bAI1mmQ4ra/AN+hjef8vdiEy fPUZ41rCpJjSc7GMQ2EHO49/4 X-Received: by 2002:a17:906:81d2:: with SMTP id e18mr3825023ejx.341.1593114898270; Thu, 25 Jun 2020 12:54:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5E/w1rTnVuKXZNENv7G0eGJhbp6+G0E9LkJ3uLdKtkufHLsXOdh6ZMYC+QQ77kfhoMtI4gw== X-Received: by 2002:a17:906:81d2:: with SMTP id e18mr3825008ejx.341.1593114898113; Thu, 25 Jun 2020 12:54:58 -0700 (PDT) Received: from [192.168.3.122] (p4ff23f47.dip0.t-ipconnect.de. [79.242.63.71]) by smtp.gmail.com with ESMTPSA id d12sm12947661edx.80.2020.06.25.12.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 12:54:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH RFC] s390x/vmem: get rid of memory segment list Date: Thu, 25 Jun 2020 21:54:56 +0200 Message-Id: <93B4CEE2-3C8D-481F-89BC-09C931866201@redhat.com> References: <20200625193837.GA5050@osiris> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Vasily Gorbik , Christian Borntraeger , Andrew Morton , Gerald Schaefer In-Reply-To: <20200625193837.GA5050@osiris> To: Heiko Carstens X-Mailer: iPhone Mail (17F80) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 25.06.2020 um 21:38 schrieb Heiko Carstens := >=20 > =EF=BB=BFOn Thu, Jun 25, 2020 at 05:00:29PM +0200, David Hildenbrand wrote= : >> This smells like a leftover from ancient times, let's get rid of it. We >> can now convert vmem_remove_mapping() into a void function - everybody >> ignored the return value already. >=20 > This buys us what? Except that we get rid of a bit of code? I=E2=80=98m looking into virtio-mem support for s390x, including vmemmap/vme= m optimizations. Virtio-mem adds/removes memory in memory block granularity,= which results in one list entry for essentially each memory section. That s= eems to be easy to avoid. Thanks=