mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Esko Mobius <echoowall@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: davem@davemloft.net, pabeni@redhat.com, horms@kernel.org,
	kuba@kernel.org, kuniyu@google.com, shuah@kernel.org,
	edumazet@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, panweiping3@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] selftests/net: packetdrill: add TCP MTU probing test
Date: Tue, 10 Nov 2026 00:43:25 +0800	[thread overview]
Message-ID: <93CEDEF5-5204-42D1-AF92-C63D64546D31@gmail.com> (raw)
In-Reply-To: <CADVnQykAX6Fw8_86emqtTUDWgFzRd_jXTZKdDJLb0s8AUmfUaw@mail.gmail.com>

> AFAICT if we drop the tcp_timestamps=0 line here (so our SYN offers
> timestamps and the scripted SYN-ACK declines them), the script should
> pass unchanged with patch 1/4, and fail without it (2072-byte rather
> than 2048-byte TSO packets, i.e. 2 x 1036 bytes). So I'd suggest
> dropping that tcp_timestamps=0 line. That way this test also covers
> the active-side part of patch 1/4.

Thanks, Neal. I removed the timestamp override and updated the commit
message.

The revised test passed with patch 1 in all three IP modes on x86_64
KVM. On the same net-next base without patch 1, all three failed on the
first data packet. Packetdrill expected 2048 bytes of TCP payload and
received 2072, as you predicted.

v3 has this change.

Thanks,
Yongjian


  reply	other threads:[~2026-11-09 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 14:39 [PATCH net-next v2 0/4] tcp: fix tcp_base_mss on passive connections and test MTU probing Yongjian Wang via B4 Relay
2026-11-08 14:39 ` [PATCH net-next v2 1/4] tcp: initialize MTU probing before syncing MSS at connection setup Yongjian Wang via B4 Relay
2026-11-08 14:39 ` [PATCH net-next v2 2/4] selftests/net: packetdrill: test tcp_base_mss on passive connections Yongjian Wang via B4 Relay
2026-11-08 14:39 ` [PATCH net-next v2 3/4] selftests/net: packetdrill: add TCP black hole detection test Yongjian Wang via B4 Relay
2026-11-08 14:39 ` [PATCH net-next v2 4/4] selftests/net: packetdrill: add TCP MTU probing test Yongjian Wang via B4 Relay
2026-11-08 19:26   ` Neal Cardwell
2026-11-09 16:43     ` Esko Mobius [this message]
2026-11-08 14:42 ` [PATCH net-next v2 0/4] tcp: fix tcp_base_mss on passive connections and test MTU probing netdev-bot+sinfo
2026-11-08 14:58   ` Esko Mobius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93CEDEF5-5204-42D1-AF92-C63D64546D31@gmail.com \
    --to=echoowall@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=panweiping3@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®