From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746781F8EF8 for ; Wed, 18 Dec 2024 17:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734542116; cv=none; b=HA/dh7hHPKUYHydlyz9GteLnPTG9ZZL6XJmmKD1vKEbRZGtGd89Xbh4zEcdJzARZmc/DX5qCvNu7ExoRM23ZZ9F3nMu96qaq6B5l6sR2WOiFh4ypnigka17UnRbZNBIvT/P7QGQvvInAaGbNPdTrIwdoWk+NHyPNrGj77afe/eM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734542116; c=relaxed/simple; bh=LwMjKOCFKrEbHqXVci8ugRuf+pw41OQTrkbHpqo7eUQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VOLhxvqlardELJPmIK6Fvf1c2widRvR4mkTsm9ygkb1mSbirmlNwbdky7UNuYOMBx9gqynAIcD5aDWruMD0y0pjX/2EzF+dzwJT6DcxExLhxDiEVN7kImcpgu8mixwLezlp4wJfwfAvJdPwJkieyQuACO8FbXte4GFRu7pa8wS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=V51ahKhJ; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="V51ahKhJ" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4679fc9b5f1so55103081cf.1 for ; Wed, 18 Dec 2024 09:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1734542113; x=1735146913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zA5BofhhRKiZZMU/Z8fX0UGVPQfIoya9QikQ0q7ZGcc=; b=V51ahKhJHUmi4cpDEIy83mzW1GoOEyNyAj1R4O/uu1quLtAF0J+S4QinOxoOYJnN9T sF+xZAA44SBa0Onwqrl+x5blcEWktanxTynL1gbDL2yoBBdx1llD90E/BVyaYiLNYGhI Z3hNZCvgyc+nDxBiGaO/mQwdF31yjxVhiWWUk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734542113; x=1735146913; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zA5BofhhRKiZZMU/Z8fX0UGVPQfIoya9QikQ0q7ZGcc=; b=tBGBYfsTCZT4sF+S3MG2uBIv67KUk0XH/Bpng5H+X1hG/YZmb1L+75UmC8G0eUrqdn MAXYdT+yie4ZHegb4ODBr6Z46/ovexqmEJ6ZabHf06Md+IrZXs2QQnXbhVRlENgJG3sa BbKC0siJ1UGxxVmnOYB+Pkv99tkdGfdsZYcNSiOLx782ifCzMdLTeXOzdY61bc9A4aTM l2zOzHMVijHb/9GFyTaP53I2IOUxZp1esScrNuIgd7LDSmjSOjv9JKfzAZcV4ldMzC4G wNe3xzAro1m449NSbhDHUW4fscZznmbfOKPrd3HZyQafI6ahMHGaDbTNA2snzQ8anvbF Id1Q== X-Forwarded-Encrypted: i=1; AJvYcCV2jCsqHZZ8+fCYZDOmwMkogTm2uDzWW94yRB6pXPbY/i8deQhhl4eCMZac4y4NN+556hGacsa0+uWT52g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Ra9gs3No3+zdhVyTMii3ksiGQB/KaHxU4fRLyl/Tk1uiCUse +Sxm7ID1aHtp8pwCsRkXnrgZ5+ypLsMkhzUMevlQqxRLmrxRlX+ix4JMMqDRFg== X-Gm-Gg: ASbGnctneYr1EGm0GPYTuQnvPLbXwhKPGRv4ft/ywY+QIWNAzH7NkgatEguGiRphiL/ 6itGtd9lSdzXlbtTmIPOKXBPzPcJ4xdbGF58Xs5HC45knax2GHZlG5YxZ4Hvz+9nza+QsAHO66o 5mYcbeNAL/Q+ChqPHeGLA2sXLBRVg+ZVTyVNtCCOJjZFuHihzCbDumrxKLsiAKZVkXnQvqj6FGP TltIXkm2UTbNkOxdgXHWAM6M/35xE1OgKTjdUdaCfCH9H+G8CIPDDuWg5n420jhjTLe1qD5prqB 8kfMfqA97jvB/2WDTHcx X-Google-Smtp-Source: AGHT+IFqZplEyKFGjmYvKE9CeODhn/531JVf21AVcLOnv2HxLobs4qVuOupYcjNzN57b5zHMiJ82sw== X-Received: by 2002:ac8:5a95:0:b0:467:7b76:5957 with SMTP id d75a77b69052e-46908db11famr61173931cf.2.1734542113315; Wed, 18 Dec 2024 09:15:13 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2c69b10sm52913091cf.18.2024.12.18.09.15.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2024 09:15:11 -0800 (PST) Message-ID: <93a1333d-442f-4cec-b823-9b1a5ff6dc6b@broadcom.com> Date: Wed, 18 Dec 2024 09:15:08 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: memory-controller: Document rev c.1.5 compatible To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Conor Dooley , Broadcom internal kernel review list , "open list:MEMORY CONTROLLER DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20241217194439.929040-1-florian.fainelli@broadcom.com> <20241217194439.929040-2-florian.fainelli@broadcom.com> <2e33t7ft5ermsfr7c4ympxrn6l5sqdef3wml4hlbnhdupoouwj@gfjpbmowjadi> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <2e33t7ft5ermsfr7c4ympxrn6l5sqdef3wml4hlbnhdupoouwj@gfjpbmowjadi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/18/24 03:37, Krzysztof Kozlowski wrote: > On Tue, Dec 17, 2024 at 11:44:38AM -0800, Florian Fainelli wrote: >> Document the revision c.1.5 compatible string that is present on newer >> Broadcom STB memory controllers (74165 and onwards). >> >> Signed-off-by: Florian Fainelli >> --- >> .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml >> index 4b072c879b02..99d79ccd1036 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml >> @@ -29,6 +29,7 @@ properties: >> - brcm,brcmstb-memc-ddr-rev-c.1.2 >> - brcm,brcmstb-memc-ddr-rev-c.1.3 >> - brcm,brcmstb-memc-ddr-rev-c.1.4 >> + - brcm,brcmstb-memc-ddr-rev-c.1.5 > > You should use v2.1 fallback and drop driver patch. Or explain in > commit briefly why different approach is suitable. Are you suggesting that we should have fallback compatible strings, such that we have something like this: compatible = "brcm,brcmstb-memc-ddr-rev-c.1.5", "brcm,brcmstb-memc-ddr-rev-c", "brcm,brcmstb-memc-ddr" and the driver only needs to match on "brcm,brcmstb-memc-ddr-rev-c" and apply the adequate register offset table? If so, that is not how the current binding, and therefore DTBs are being deployed, so that will introduce a breakage until we update all DTBs in the field... -- Florian