mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Larsson <andreas@gaisler.com>
To: Ma Ke <make24@iscas.ac.cn>, davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] sparc: fix error handling in scan_one_device()
Date: Mon, 22 Sep 2025 07:48:58 +0200	[thread overview]
Message-ID: <93a6baf0-bafe-4855-8679-aec375debaa6@gaisler.com> (raw)
In-Reply-To: <20250920125312.3588-1-make24@iscas.ac.cn>

On 2025-09-20 14:53, Ma Ke wrote:
> Once of_device_register() failed, we should call put_device() to
> decrement reference count for cleanup. Or it could cause memory leak.
> So fix this by calling put_device(), then the name can be freed in
> kobject_cleanup().
> 
> Calling path: of_device_register() -> of_device_add() -> device_add().
> As comment of device_add() says, 'if device_add() succeeds, you should
> call device_del() when you want to get rid of it. If device_add() has
> not succeeded, use only put_device() to drop the reference count'.
> 
> Found by code review.
> 
> Cc: stable@vger.kernel.org
> Fixes: cf44bbc26cf1 ("[SPARC]: Beginnings of generic of_device framework.")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> Changes in v3:
> - also fixed the same problem in arch/sparc/kernel/of_device_32.c as suggestions.
> Changes in v2:
> - retained kfree() manually due to the lack of a release callback function.
> ---
>  arch/sparc/kernel/of_device_32.c | 1 +
>  arch/sparc/kernel/of_device_64.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c
> index 06012e68bdca..284a4cafa432 100644
> --- a/arch/sparc/kernel/of_device_32.c
> +++ b/arch/sparc/kernel/of_device_32.c
> @@ -387,6 +387,7 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
>  
>  	if (of_device_register(op)) {
>  		printk("%pOF: Could not register of device.\n", dp);
> +		put_device(&op->dev);
>  		kfree(op);
>  		op = NULL;
>  	}
> diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c
> index f98c2901f335..f53092b07b9e 100644
> --- a/arch/sparc/kernel/of_device_64.c
> +++ b/arch/sparc/kernel/of_device_64.c
> @@ -677,6 +677,7 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
>  
>  	if (of_device_register(op)) {
>  		printk("%pOF: Could not register of device.\n", dp);
> +		put_device(&op->dev);
>  		kfree(op);
>  		op = NULL;
>  	}


Reviewed-by: Andreas Larsson <andreas@gaisler.com>

Picking this up to my for-next.

Thanks,
Andreas


      reply	other threads:[~2025-09-22  5:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20 12:53 Ma Ke
2025-09-22  5:48 ` Andreas Larsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93a6baf0-bafe-4855-8679-aec375debaa6@gaisler.com \
    --to=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=make24@iscas.ac.cn \
    --cc=sparclinux@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®