From: Karolina Stolarek <karolina.stolarek@intel.com>
To: Calvince Otieno <calvncce@gmail.com>
Cc: <outreachy@lists.linux.dev>, <gustavo@embeddedor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: vc04_services: remove empty functions
Date: Thu, 19 Oct 2023 12:55:11 +0200 [thread overview]
Message-ID: <93a6d8b0-140c-983e-1b78-6f5a4e03e62e@intel.com> (raw)
In-Reply-To: <ZTD677iqMkRPxT27@lab-ubuntu>
On 19.10.2023 11:46, Calvince Otieno wrote:
> The functions vchiq_debugfs_init(), vchiq_debugfs_deinit(),
> vchiq_debugfs_add_instance(), and vchiq_debugfs_remove_instance()
> are declared and defined but contains no code or statements.
> They do nothing.
>
> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> ---
> .../interface/vchiq_arm/vchiq_arm.c | 3 ---
> .../interface/vchiq_arm/vchiq_debugfs.c | 16 ----------------
> .../interface/vchiq_arm/vchiq_debugfs.h | 8 --------
> .../interface/vchiq_arm/vchiq_dev.c | 4 ----
> 4 files changed, 31 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index eef9c8c06e66..b802d1ecc8f6 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1806,8 +1806,6 @@ static int vchiq_probe(struct platform_device *pdev)
> if (err)
> goto failed_platform_init;
>
> - vchiq_debugfs_init();
> -
> vchiq_log_info(vchiq_arm_log_level,
> "vchiq: platform initialised - version %d (min %d)",
> VCHIQ_VERSION, VCHIQ_VERSION_MIN);
> @@ -1838,7 +1836,6 @@ static void vchiq_remove(struct platform_device *pdev)
> {
> vchiq_device_unregister(bcm2835_audio);
> vchiq_device_unregister(bcm2835_camera);
> - vchiq_debugfs_deinit();
> vchiq_deregister_chrdev();
> }
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> index dc667afd1f8c..7e45076e5ebd 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> @@ -228,20 +228,4 @@ void vchiq_debugfs_deinit(void)
>
> #else /* CONFIG_DEBUG_FS */
We need to have these definitions, so a kernel with no CONFIG_DEBUG_FS
selected builds. Have you experimented with this config with your
changes applied?
All the best,
Karolina
>
> -void vchiq_debugfs_init(void)
> -{
> -}
> -
> -void vchiq_debugfs_deinit(void)
> -{
> -}
> -
> -void vchiq_debugfs_add_instance(struct vchiq_instance *instance)
> -{
> -}
> -
> -void vchiq_debugfs_remove_instance(struct vchiq_instance *instance)
> -{
> -}
> -
> #endif /* CONFIG_DEBUG_FS */
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> index e9bf055a4ca9..76424473c32b 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> @@ -10,12 +10,4 @@ struct vchiq_debugfs_node {
> struct dentry *dentry;
> };
>
> -void vchiq_debugfs_init(void);
> -
> -void vchiq_debugfs_deinit(void);
> -
> -void vchiq_debugfs_add_instance(struct vchiq_instance *instance);
> -
> -void vchiq_debugfs_remove_instance(struct vchiq_instance *instance);
> -
> #endif /* VCHIQ_DEBUGFS_H */
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> index 841e1a535642..953f39f537a8 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> @@ -1185,8 +1185,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
> instance->state = state;
> instance->pid = current->tgid;
>
> - vchiq_debugfs_add_instance(instance);
> -
> init_completion(&instance->insert_event);
> init_completion(&instance->remove_event);
> mutex_init(&instance->completion_mutex);
> @@ -1297,8 +1295,6 @@ static int vchiq_release(struct inode *inode, struct file *file)
>
> free_bulk_waiter(instance);
>
> - vchiq_debugfs_remove_instance(instance);
> -
> kfree(instance);
> file->private_data = NULL;
>
next prev parent reply other threads:[~2023-10-19 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 9:46 Calvince Otieno
2023-10-19 10:55 ` Karolina Stolarek [this message]
2023-10-19 11:21 ` Calvince Otieno
2023-10-19 12:34 ` Karolina Stolarek
2023-10-19 12:50 ` Ricardo B. Marliere
2023-10-19 15:29 ` Greg Kroah-Hartman
2023-10-19 15:58 ` Ricardo B. Marliere
2023-10-19 15:31 ` Greg Kroah-Hartman
2023-10-20 14:25 ` kernel test robot
2023-11-06 17:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a6d8b0-140c-983e-1b78-6f5a4e03e62e@intel.com \
--to=karolina.stolarek@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=calvncce@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®