From: Markus Elfring <Markus.Elfring@web.de>
To: Chenyuan Yang <chenyuan0y@gmail.com>,
linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
netdev@vger.kernel.org,
Angelo Gioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Richard Cochran <richardcochran@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Zijie Zhao <zzjas98@gmail.com>
Subject: Re: [PATCH] pinctrl: Fix potential NULL pointer dereference
Date: Wed, 12 Feb 2025 13:45:18 +0100 [thread overview]
Message-ID: <93a7e08f-8a3b-42cc-8d36-f570f02087c8@web.de> (raw)
In-Reply-To: <20250210232552.1545887-1-chenyuan0y@gmail.com>
> The `chip.label` could be NULL. Add missing check in the
> rza2_gpio_register().
Another wording suggestion:
The data structure member “chip.label” could become NULL
after a failed devm_kasprintf() call in the implementation
of the function “rza2_gpio_register”.
Thus add a check for such a return value.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc2#n145
Can a summary phrase like “Prevent null pointer dereference in rza2_gpio_register()”
be nicer?
> This is similar to commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
> Besides, mediatek_gpio_bank_probe() in drivers/gpio/gpio-mt7621.c also
> has a very similar check.
I find such auxiliary information not so relevant here.
Regards,
Markus
prev parent reply other threads:[~2025-02-12 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 23:25 Chenyuan Yang
2025-02-11 7:38 ` Geert Uytterhoeven
2025-02-12 8:35 ` Matthias Brugger
2025-02-12 12:45 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a7e08f-8a3b-42cc-8d36-f570f02087c8@web.de \
--to=markus.elfring@web.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chenyuan0y@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=zzjas98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®