mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinyang He <hejinyang@loongson.cn>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
	Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Nathan Chancellor <nathan@kernel.org>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] LoongArch: Fix unreachable instruction warnings about entry functions
Date: Thu, 4 Sep 2025 09:26:43 +0800	[thread overview]
Message-ID: <93a93bcf-8778-a6a3-142d-c8aeb3cee5cd@loongson.cn> (raw)
In-Reply-To: <ots6w2ntyudj5ucs5eowncta2vmfssatpcqwzpar3ekk577hxi@j45dd4dmwx6x>

On 2025-09-04 03:22, Josh Poimboeuf wrote:

> On Mon, Sep 01, 2025 at 03:21:56PM +0800, Tiezhu Yang wrote:
>> +++ b/arch/loongarch/kernel/Makefile
>> @@ -3,8 +3,6 @@
>>   # Makefile for the Linux/LoongArch kernel.
>>   #
>>   
>> -OBJECT_FILES_NON_STANDARD_head.o := y
>> -
>>   always-$(KBUILD_BUILTIN)	:= vmlinux.lds
>>   
>>   obj-y		+= head.o cpu-probe.o cacheinfo.o env.o setup.o entry.o genex.o \
>> diff --git a/arch/loongarch/kernel/head.S b/arch/loongarch/kernel/head.S
>> index e3865e92a917..a11880f3a7e1 100644
>> --- a/arch/loongarch/kernel/head.S
>> +++ b/arch/loongarch/kernel/head.S
>> @@ -42,6 +42,7 @@ SYM_DATA(kernel_fsize, .long _kernel_fsize);
>>   	.align 12
>>   
>>   SYM_CODE_START(kernel_entry)			# kernel entry point
>> +	UNWIND_HINT_UNDEFINED
> Should this not be UNWIND_HINT_END_OF_STACK?
>
> I notice Loongarch doesn't seem to use that anywhere.  How does any ORC
> unwind succeed?
IIRC, unwinder stops when fail when call __kernel_text_address(bt_address),
or success when call 
arch/loongarch/kernel/unwind_orc.c::is_entry_func(bt_address).
> UNWIND_HINT_UNDEFINED sets an error condition which
> should cause a livepatch transition to stall.
>


  reply	other threads:[~2025-09-04  1:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  7:21 [PATCH v1 0/3] Fix objtool warnings if LTO is enabled for LoongArch (Part 2) Tiezhu Yang
2025-09-01  7:21 ` [PATCH v1 1/3] objtool/LoongArch: Fix fall through warning about efi_boot_kernel() Tiezhu Yang
2025-09-01  8:16   ` Peter Zijlstra
2025-09-01  8:31     ` Tiezhu Yang
2025-09-03 19:17       ` Josh Poimboeuf
2025-09-04  2:15         ` Tiezhu Yang
2025-09-04  2:17         ` Huacai Chen
2025-09-04 17:26           ` Josh Poimboeuf
2025-09-05  4:33             ` Huacai Chen
2025-09-05  9:53               ` Tiezhu Yang
2025-09-01  7:21 ` [PATCH v1 2/3] objtool/LoongArch: Fix unreachable instruction warnings about EFISTUB Tiezhu Yang
2025-09-01  8:19   ` Peter Zijlstra
2025-09-01  8:39     ` Tiezhu Yang
2025-09-03 19:19       ` Josh Poimboeuf
2025-09-04  2:18         ` Tiezhu Yang
2025-09-04  2:21           ` Huacai Chen
2025-09-04  3:50             ` Tiezhu Yang
2025-09-04  3:59               ` Huacai Chen
2025-09-04 17:39                 ` Josh Poimboeuf
2025-09-04 21:46                   ` Josh Poimboeuf
2025-09-05  4:36                     ` Huacai Chen
2025-09-05 16:04                       ` Josh Poimboeuf
2025-09-09  3:59                         ` Tiezhu Yang
2025-09-09  4:10                           ` Huacai Chen
2025-09-09 16:05                             ` Josh Poimboeuf
2025-09-10  6:55                               ` Huacai Chen
2025-09-11  3:23                                 ` Josh Poimboeuf
2025-09-11  8:28                                   ` Huacai Chen
2025-09-01  7:21 ` [PATCH v1 3/3] LoongArch: Fix unreachable instruction warnings about entry functions Tiezhu Yang
2025-09-01  8:20   ` Peter Zijlstra
2025-09-03 19:22   ` Josh Poimboeuf
2025-09-04  1:26     ` Jinyang He [this message]
2025-09-04  3:18     ` Tiezhu Yang
2025-09-04 17:16       ` Josh Poimboeuf
2025-09-02 15:43 ` [PATCH v1 0/3] Fix objtool warnings if LTO is enabled for LoongArch (Part 2) Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93a93bcf-8778-a6a3-142d-c8aeb3cee5cd@loongson.cn \
    --to=hejinyang@loongson.cn \
    --cc=chenhuacai@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®