mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	David Disseldorp <ddiss@suse.de>
Cc: Christian Brauner <brauner@kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	Steven Rostedt <rostedt@goodmis.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach
Date: Tue, 27 Jan 2026 14:08:07 -0800	[thread overview]
Message-ID: <93b5c10e-747d-4164-9733-947a63b4f25d@zytor.com> (raw)
In-Reply-To: <aW_xA0wbC2bf981d@smile.fi.intel.com>

On 2026-01-20 13:17, Andy Shevchenko wrote:
>>
>> I.e. a "0x" isn't specified as valid prefix. I don't feel strongly
>> regarding diverging from existing behaviour,
> 
>> but it should still be
>> considered (and documented) as a potentially user-visible regression.
> 
> I disagree, this is not specified and should not be used. The CPIO archive in
> the original form doesn't specify leading 0 for octals (at least how I read it,
> please correct me, if I'm wrong).
> 
> https://pubs.opengroup.org/onlinepubs/007908799/xcu/pax.html
> 

This is the "newc" or "crc" format used by BSD (header magic 070701 and
070702, respectively), those were never standardized by POSIX.

These formats use 8-character hexadecimal (%08x).

As far as a 0x prefix, or upper case -- no, that is technically not according
to spec, but we DO NOT break user space tools that have been working for 20+
years, unless it is either (a) a security problem or (b) is holding back
further development (e.g. because the format is ambiguous. This is Postel's
law in action.

	-hpa



  reply	other threads:[~2026-01-27 22:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 20:38 [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 1/4] initramfs: Sort headers alphabetically Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach Andy Shevchenko
2026-01-20 20:12   ` David Disseldorp
2026-01-20 20:34     ` Andy Shevchenko
2026-01-20 21:00       ` David Disseldorp
2026-01-20 21:17         ` Andy Shevchenko
2026-01-27 22:08           ` H. Peter Anvin [this message]
2026-01-19 20:38 ` [PATCH v1 3/4] vsprintf: Revert "add simple_strntoul" Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 4/4] kstrtox: Drop extern keyword in the simple_strtox() declarations Andy Shevchenko
2026-01-20 11:20 ` [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Christian Brauner
2026-01-20 12:46   ` Andy Shevchenko
2026-01-23 12:22     ` Christian Brauner
2026-01-23 14:12       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b5c10e-747d-4164-9733-947a63b4f25d@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brauner@kernel.org \
    --cc=ddiss@suse.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®